Tim Abbott
46b5c942aa
test_narrow: Fix remaining case of search tests flaking with "lunch".
...
We apparently were using the default of num_before=1, not
num_before=0, which meant that if the very last randomly generated
message was one by cordelia mentioning lunch,
test_get_messages_with_search would fail because there were actually 3
matches.
2017-08-16 07:37:06 -07:00
Tim Abbott
5184c64a92
upload: Fix uploading files with Python 3.
...
Apparently there's a bug in typeshed's stubs for uploading files,
which resulted in our S3 upload code being broken on Python 3.
2017-08-16 07:33:23 -07:00
Umair Khan
3afa8ad6a6
test_users: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
d051bfbcb4
test_urls: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
d3ced34152
test_uploads: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
b9785cd4d6
test_subs: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
b14603249f
test_realm_filters: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
bab6893dbb
test_realm_emoji: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
ed12419061
test_reactions: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
02aab6a43f
test_presence: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
70996de415
test_messages: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
0e119c0ec2
test_bugdown: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
2b6c6d823d
test_bots: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
366d2927c3
test_attachments: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Umair Khan
64c961f5de
test_alert_words: Upgrade to HttpResponse.json().
2017-08-16 07:06:58 -07:00
Aditya Bansal
0716702558
management: Log number of soft deactivated/reactivated users.
2017-08-15 22:05:19 -07:00
Aditya Bansal
5f5d99550e
soft-deactivation/management: Raise exception for non existant emails.
2017-08-15 22:05:19 -07:00
Aditya Bansal
cd11cbea14
soft-deactivation/management: Rename variable to make more sense.
...
We rename variable user_ids_to_deactivate to users_to_deactivate
since it was storing UserProfiles anyway.
2017-08-15 22:05:19 -07:00
Aditya Bansal
4578b9c613
soft-deactivation: Return list of soft deactivated/reactivated users.
...
do_soft_activate_users() and do_soft_deactivate_users() are modified
so as to maintain/return the list of affected users.
2017-08-15 22:05:19 -07:00
Aditya Bansal
34d30706da
soft-deactivation: Log users which were soft deactivate/reactivated.
2017-08-15 22:05:19 -07:00
Aditya Bansal
f5713297c4
digest: Stop generating digest emails for soft-deactivated users.
2017-08-15 22:04:52 -07:00
Tim Abbott
890417f8eb
test_helpers: Add 'method' to HostRequestMock.
2017-08-15 19:47:03 -07:00
Tim Abbott
fd1b8c7a3c
decorator: Fix SOCKET requests being broken with REALMS_HAVE_SUBDOMAINS.
...
This code path broken in a recent refactoring meant that sending
messages via websockets didn't work if REALMS_HAVE_SUBDOMAINS.
2017-08-15 19:22:17 -07:00
Tim Abbott
7c4eb43f34
test_notifications: Fix reply-to email for test suite.
...
It turns out that moving NOREPLY_EMAIL_ADDRESS DEFAULT_SETTINGS
unexpectedly changed its value in the test suite.
2017-08-15 18:33:15 -07:00
neiljp (Neil Pilgrim)
bb83742906
mypy: Correct 2 type annotations in zerver/middleware.py.
2017-08-15 17:50:18 -07:00
neiljp (Neil Pilgrim)
52ed997d23
mypy: Reorder and annotate variables around if statements.
2017-08-15 17:50:18 -07:00
neiljp (Neil Pilgrim)
2d3b95a088
mypy: Annotate sent_time_in_epoch_seconds taking Optional[UserMessage].
2017-08-15 17:50:18 -07:00
neiljp (Neil Pilgrim)
26e03bb14b
mypy: Annotate completely_open(realm) input as Optional[Realm].
2017-08-15 17:50:18 -07:00
Brock Whittaker
83184d5c60
/about/: Merge with /authors, redesign page.
...
This adds the authors to the Zulip repository on GitHub from
/authors/ along with re-styling the page to fit the same
aesthetic as /for/open-source/ and other product-pages.
2017-08-15 16:09:01 -07:00
Tim Abbott
ba411b0539
digest: Use get_user_profile_by_id.
2017-08-15 12:53:48 -07:00
Tim Abbott
353a61b1d8
test_signup: Clean up re-fetching of user objects.
2017-08-15 12:52:23 -07:00
Jack Zhang
a533ab5881
context_processors.py: Add flag for whether user is logged in.
2017-08-15 12:15:21 -07:00
Jack Zhang
182570d5f3
Deduplicate header markup for portico and portico-help templates.
2017-08-15 12:15:21 -07:00
Jack Zhang
b82bdc82bf
context_processors.py: Add flag for whether page is help center.
...
This is needed once the header markup is deduplicated.
2017-08-15 12:15:21 -07:00
Tim Abbott
93aa28ed08
decorator: Clean up ugly validation comment.
2017-08-15 10:55:32 -07:00
Tim Abbott
5a63ea0170
decorator: Extract validate_account_and_subdomain and deduplicate.
...
This fixes the significant duplication of code between the
authenticate_log_and_execute_json code path and the `validate_api_key`
code path.
These's till a bit of duplication, in the form of `process_client` and
`request._email` interactions, but it is very minor at this point.
2017-08-15 10:54:23 -07:00
Tim Abbott
127222e7e5
decorator: Clean up process_client call with positional argument.
2017-08-15 10:54:23 -07:00
Tim Abbott
0262609c3d
decorator: Use validate_api_key in api_key_only_webhook_view code path.
...
This completes the effort to deduplicate the main code of our
authentication decorators.
2017-08-15 10:54:23 -07:00
Tim Abbott
319ea62cd9
decorator: Extract zerver/lib/profile.py.
...
This lets us remove this debugging function from our core
authentication codebase.
2017-08-15 10:54:23 -07:00
Tim Abbott
077c05fc78
decorator: Remove ancient client_name hack for iOS.
...
The old iOS app has been gone from the app store for 8 months, never
had a huge userbase, and its latest version didn't need this hack. So
this code is unlikely to do anything in the future; remove it to
declutter our authentication decorators codebase.
2017-08-15 10:54:23 -07:00
Tim Abbott
b46af40bd3
decorator: Refactor more code into validate_api_key.
2017-08-15 10:54:23 -07:00
Tim Abbott
5d2d939310
validate_api_key: Stop using 'profile' local variable.
2017-08-15 10:54:23 -07:00
Tim Abbott
25ec30dcf1
decorator: Deduplicate validate_api_key by using new helper function.
...
This should eliminate a bunch of duplicated code between these two
code paths.
2017-08-15 10:54:23 -07:00
Tim Abbott
cc03c8766f
test_helpers: Expand HostRequestMock variables.
2017-08-15 10:54:23 -07:00
Tim Abbott
5b8d04e18f
decorator: Remove now-unnecessary cast.
2017-08-15 10:54:23 -07:00
Tim Abbott
5ebe507c9b
decorator: Fix check for incoming webhook bots and move later
...
The check itself was correct, but the error message was in fact the
opposite of what this check is for. In other words, the only things
these users can do is post messages, and the error message when you
tried to do something else was to tell you that the user can't post
messages.
2017-08-15 10:54:23 -07:00
Tim Abbott
3c37795675
decorator: Add localhost/Tornado hack to access_user_by_api_key.
...
This should make it possible to share that code with other code paths.
2017-08-15 10:54:23 -07:00
Tim Abbott
1144eed48b
decorator: Clean up 'profile' variable reuse.
2017-08-15 10:54:23 -07:00
Tim Abbott
a2011b5a48
decorator: Simplify control flow in validate_api_key.
...
This technically changes the behavior in the case that
!settings.ZILENCER_ENABLED but is_remote_zulip_server(role).
Fortunately, that case is mostly irrelevant (in that remote zulip
servers is a Zilencer feature). The old behavior was also probably
slightly wrong, in that you'd get a zilencer-specific error message in
that case.
2017-08-15 10:52:46 -07:00
Tim Abbott
a6647f335f
decorator: Reorganize remote Zulip server code into one block.
2017-08-15 10:51:29 -07:00