zulip

Commit Graph

Author	SHA1	Message	Date
Steve Howell	c88c69db2e	bug fixes: Clean up hotkey mappings. We simplify hotkey mappings by using different hashes for keydown and keypress events. There are browser bugs (iOS, for example) where keypress events have the wrong keyCode values. This led us, under iOS, to interpret "!" as "page up." This fix also helps us disinguish escape from shift-escape. Brock Whittaker helped on figuring out the keypress/keydown issues that are addressed in this commit. Fixes #4019	2017-03-13 21:38:23 -07:00
Steve Howell	cc6fc3c41a	node tests: Add hotkey.js tests. The initial version of the tests cover most normal keys, but they do not cover special keys like enter/tab/escape or arrow keys or home/end/page-down/page-up yet.	2017-03-13 15:09:53 -07:00

Author

SHA1

Message

Date

Steve Howell

c88c69db2e

bug fixes: Clean up hotkey mappings.

We simplify hotkey mappings by using different hashes for
keydown and keypress events.  There are browser bugs (iOS, for
example) where keypress events have the wrong keyCode values.
This led us, under iOS, to interpret "!" as "page up."

This fix also helps us disinguish escape from shift-escape.

Brock Whittaker helped on figuring out the keypress/keydown
issues that are addressed in this commit.

Fixes #4019

2017-03-13 21:38:23 -07:00

Steve Howell

cc6fc3c41a

node tests: Add hotkey.js tests.

The initial version of the tests cover most normal keys, but they
do not cover special keys like enter/tab/escape or arrow keys
or home/end/page-down/page-up yet.

2017-03-13 15:09:53 -07:00

1 2

52 Commits