Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
11,425 Commits 28 Branches 143 Tags 605 MiB
Commit Graph

26 Commits

Author SHA1 Message Date
Kartik Maji f8bb7503e6 Add ability to pin streams to top of the streams sidebar list. 
Based on work by Lauren Long, with some tweaks by tabbott.
 2016-06-30 22:26:09 -07:00
Eklavya Sharma 63a5323259 zerver/views/streams.py: Type annotate variables. 2016-06-27 17:52:22 +05:30
acrefoot e4ed9195dc Remove rest_dispatch hack and optimize imports. 
For a long time, rest_dispatch has had this hack where we have to
create a copy of it in each views file using it, in order to directly
access the globals list in that file.  This removes that hack, instead
making rest_dispatch just use Django's import_string to access the
target method to use.

[tweaked and reorganized from acrefoot's original branch in various
ways by tabbott]
 2016-06-24 16:11:03 -07:00
Tim Abbott 80d92c1651 Add comment documenting confusing list_to_streams code. 2016-06-21 11:45:35 -07:00
Eklavya Sharma 9d7a2fdf9d zerver/views/streams.py: Fix annotations. 
Mainly fix `str` to `text_type` and use abstract containers.
 2016-06-13 20:01:01 +05:30
Vishnu Ks b926826ea1 Remove default_stream addition and deletion from update_stream_backend. 
Default stream addition/removal is done via the /default_stream REST
endpoints.
 2016-06-10 16:59:15 -07:00
Vishnu Ks f9f31b79d0 Make default_streams web controllable. 
Fixes: #665
 2016-06-09 15:24:32 -07:00
David Adamec 9e8ea93d3d Add annotations for zerver/lib/validator. 2016-06-03 23:53:49 -07:00
Pei-Wei Wu 8d2733ae8c Add mypy type annotations to zerver/views/streams.py. 2016-06-02 15:44:43 -07:00
Umair Khan 08fbd57245 [i18n] Make error messages translatable. 
Make all strings passing through `json_error` and `JsonableError`
translatable.

Fixes #727
 2016-05-31 07:40:42 -07:00
Tim Abbott 960144a49e Desupport using uninstantiated REQ with has_request_variables. 
This makes life difficult for doing static type annotations, and
didn't make the code look that much better anyway.
 2016-05-31 07:31:15 -07:00
Tim Abbott baec0f12cf Add a proper annotation for REQ in streams.py. 2016-05-30 11:41:16 -07:00
Eklavya Sharma efab224bd1 zerver/lib/actions.py: Remove unneeded `return {}` statements. 2016-05-29 04:26:17 -07:00
Tim Abbott e781136132 Fix subscribing to existing streams when can_create_streams=False. 
Previously, a user with can_create_streams=False would be incorrectly
unable to subscribe to streams, whether the streams previously existed
or not.
 2016-05-18 18:47:24 -07:00
Tim Abbott 620debc5fd Change PrincipalError to return status code 403 by default. 2016-05-10 09:50:57 -07:00
Tim Abbott 3cde06ea33 Add support for setting HTTP status codes in JsonableError. 2016-05-10 09:50:48 -07:00
Ashish Kumar 48be2e33f8 Delete old route for /json/get_public_streams. 2016-04-29 12:57:57 -07:00
Tim Abbott 49799440a4 Replace use of django-guardian with fields on UserProfile. 
As documented in https://github.com/zulip/zulip/issues/441, Guardian
has quite poor performance, and in fact almost 50% of the time spent
running the Zulip backend test suite on my laptop was inside Guardian.

As part of this migration, we also clean up the old API_SUPER_USERS
variable used to mark EMAIL_GATEWAY_BOT as an API super user; now that
permission is managed entirely via the database.

When rebasing past this commit, developers will need to do a
`manage.py migrate` in order to apply the migration changes before the
server will run again.

We can't yet remove Guardian from INSTALLED_APPS, requirements.txt,
etc. in this release, because otherwise the reverse migration won't
work.

Fixes #441.
 2016-04-20 21:51:52 -07:00
Varshit 4e1060076d Purge 'from typing import *' from zerver/. 
This is a partial implementation of #636.
 2016-04-07 14:07:07 -07:00
Tim Abbott ec7bb0b011 Add PEP-484 type annotations to zerver/views/. 2016-04-03 15:40:23 -07:00
Eklavya Sharma 9e3c3e14f5 Partially apply Python 3 libmodernize.fixes.fix_dict_six. 
Refer to #256
 2016-03-19 15:52:58 -07:00
Tim Abbott 620411c0ea Fix type mismatches in streams.py. 2016-02-03 19:25:19 -08:00
Tim Abbott 5bacda3662 python3: Fix usage of .keys()/.values() to handle iterators. 
This fixes the places where we use the result of .keys(), .items(),
and .values() that wouldn't work with an iterator to wrap them with
list().
 2016-01-26 21:11:25 -08:00
Tim Abbott 6528b18ad3 Switch all urllib/urlparse usage to six.moves.urllib. 
This provides Python 2+3 compatibility for our use of urllib.

Also add a test to avoid future regressions.
 2016-01-26 21:09:43 -08:00
Tim Abbott 9cec758854 Remove now obsolete /json/subscriptions/add endpoint. 2015-12-12 18:14:08 -08:00
Tim Abbott 37d4a11610 Move streams views into their own file. 2015-11-24 05:20:37 -08:00