711a50f1e8
Add internal_prep_private_message().
...
The new function takes a full UserProfile object for the sender,
which allows us to avoid O(N) calls when creating the stream to
find the user profile of the notification bot. (The calls were
already cached, so this won't necessarily be a huge performance
win.)
We also don't have to worry about sending a blank subject any more.
2017-05-01 16:23:38 -07:00
0f4de8e37d
Add internal_prep_stream_message().
...
The new, more direct interface for prepping internal stream
messages circumvents the bug-prone extract_recipients() method,
which has the pitfall that it will try to parse a stream name
as JSON. It also takes a UserProfile object for the sender, so
it's a bit more type-safe.
2017-05-01 16:23:38 -07:00
e3edc4d829
Send welcome messages for new streams.
2017-05-01 16:23:38 -07:00
f599b517d3
Switch checkbox styling to new style in #invite.
...
The checkboxes in invite are now converted in this commit to the new
style.
2017-05-01 16:01:36 -07:00
3ff55034fe
admin: Restyle administration checkboxes to match new style.
...
This restyles the administration checkboxes to look similar to those
that are currently present in the settings section.
2017-05-01 16:01:36 -07:00
84008b9c37
context_processors: Rename confusingly named add_settings context.
...
Also document this.
2017-05-01 15:47:58 -07:00
f4262e0169
message_edit: Fix exception closing "view source".
...
This fixes a regression introduced in
81a575e4d5
2017-05-01 15:08:01 -07:00
03b7be17a6
settings: Fix unnecessary/ugly exclamations in error messages.
...
The previous code would produce errors of the form "Failed!: ...".
2017-05-01 14:50:20 -07:00
f13d6a18eb
realm-emoji: Add realm emoji uploading instead url providing.
...
- Add file_name field to `RealmEmoji` model and migration.
- Add emoji upload supporting to Upload backends.
- Add uploaded file processing to emoji views.
- Use emoji source url as based for display url.
- Change emoji form for image uploading.
- Fix back-end tests.
- Fix front-end tests.
- Add tests for emoji uploading.
Fixes #1134
2017-05-01 14:50:20 -07:00
0785c377a4
zephyr: Fix link to webathena login from error bar.
...
This was apparently broken when we moved the webathena login errors
out of the right sidebar.
2017-04-30 21:31:25 -07:00
445cf8c680
reactions: Add a test for the Zulip emoji.
...
This fixes a coverage problem introduced by recent emoji refactoring.
Also, it'll help prevent us from breaking this feature in the future.
2017-04-30 20:16:51 -07:00
85805cf380
bugdown: Simplify logic for constructing unicode_emoji_list.
2017-04-30 16:40:58 -07:00
8b3be3cd3a
bugdown: Pass a codepoint, not a URL, to make_emoji.
2017-04-30 16:40:58 -07:00
a7efe222ee
tests: Use slightly_smiling_face instead of simple_smile.
...
The latter name is likely to be removed in the near future.
2017-04-30 16:40:58 -07:00
565370a365
bugdown: Create make_realm_emoji function.
...
Currently, this is a duplicate of the existing make_emoji, but the
plan is to change that in some upcoming refactoring.
2017-04-30 16:40:58 -07:00
18bd566958
bugdown: Extract unicode_emoji_to_codepoint.
2017-04-30 16:40:58 -07:00
e0a8f383b3
bugdown: Remove unnecessary first argument to make_emoji.
2017-04-30 16:40:58 -07:00
cfeff245c1
emoji: Manage Zulip emoji as a custom/extra realm emoji.
...
This is prerequisite for converting our emoji system to work off of
iamcal sprite sheets.
Also, fixes #4308 .
2017-04-30 16:40:31 -07:00
5321e2e2c1
hotkey: Reorder compose and emoji picker escape handlers.
...
This fixes an issue where escape could close the compose box, not the
compose emoji picker.
2017-04-30 15:15:33 -07:00
df817f12f4
emoji: Rename reaction-popover to emoji-popover.
...
The name emoji-popover should now be more appropiate, as there's no more
need to distinguish between reacting to messages and composing messages.
2017-04-30 15:15:33 -07:00
a9505654da
emoji: Replace the old compose emoji picker with the reactions picker.
...
This removes the old compose emoji picker in its entirety, changing
the few callbacks needed to launch the reactions-style emoji picker
instead and hook it up properly.
Callbacks for reactions and composing messages are distinguished by
selecting for, respectively, the .reaction and .composition classes.
Fixes #4122 .
2017-04-30 15:14:42 -07:00
58a92a0eff
emoji: Extend reaction_popover_content template for compose.
2017-04-30 15:09:43 -07:00
87d06268ca
toggle_reactions_popover: Support being passed no message ID.
...
This is intended to facilitate calling this function for the compose
picker, where there is no message yet.
2017-04-30 15:08:51 -07:00
3c257a19c0
emoji-picker: Extract generate_emoji_picker_content.
...
This is a pure refactor, with no functional changes.
2017-04-30 15:02:12 -07:00
66f927762b
emoji_picker: Extract compute_placement function.
...
Thanks to Jack Zhang for identifying this useful refactoring.
2017-04-30 14:41:54 -07:00
f8b3ce7d15
emoji: Move all emoji picker logic/events into emoji_picker module.
...
Added emoji_picker.js to static asset pipeline.
2017-04-30 14:13:36 -07:00
889547ff5e
configure-rabbitmq: Add support for RABBITMQ_NODE flag.
...
This can potentially be used by things like a Docker configuration
that runs RabbitMQ on another server.
2017-04-29 15:03:05 -07:00
8ef18463d6
github_webhook: Use author's full name if username is not available.
...
In cases where the webhook payload doesn't have the username for the
author of a particular commit (this can happen if the author doesn't
have a GitHub account or the author's email is not associated with
their GitHub account), we now use the author's full name to format
messages.
2017-04-29 14:57:57 -07:00
cab87fef2a
Refactor: Extract default-language-modal to be a partial.
...
We are doing this refactor for the sake of keeping our template
consistent with the indentation policy and maintaining its
readability at the same time.
2017-04-29 08:35:25 -07:00
78f2df5649
home.py: move initial_pointer as pointer to register_ret.
...
This is the last of the fields in page_params that could come from
register_ret but wasn't doing so.
2017-04-28 23:39:14 -07:00
d3e7e6542a
home.py: move user_profile full_name to register_ret.
...
Move the user_profile data section down into fetch_initial_state_data
so it entirely pulls from register_ret for #3853 .
2017-04-28 23:31:28 -07:00
d5421f25e1
home.py: move user_profile email to register_ret.
...
Move the user_profile data section down into fetch_initial_state_data so
it entirely pulls from register_ret for #3853
2017-04-28 23:27:34 -07:00
9daf9faa5c
home.py: move enter_sends to register_ret.
...
Move the user_profile data section down into fetch_initial_state_data so
it entirely pulls from register_ret for #3853
2017-04-28 23:26:28 -07:00
6f770c2465
home.py: move user_id to register_ret.
...
Move the user_profile data section down into fetch_initial_state_data so
it entirely pulls from register_ret for #3853
2017-04-28 23:26:28 -07:00
6159b8e21a
home.py: move is_admin to register_ret.
...
Move the user_profile data section down into fetch_initial_state_data so
it entirely pulls from register_ret for #3853
2017-04-28 23:26:27 -07:00
d92da7d193
home.py: move can_create_streams to register_ret.
...
Move the user_profile data section down into fetch_initial_state_data
so it entirely pulls from register_ret for #3853 .
This field requires some changes to the events race handling.
2017-04-28 23:23:21 -07:00
379a8afaae
home.py: move autoscroll_forever to register_ret.
...
Move the user_profile data section down into fetch_initial_state_data so
it entirely pulls from register_ret for #3853
2017-04-28 23:16:32 -07:00
22be291d96
home.py: move default_desktop_notifications to register_ret.
...
Move the user_profile data section down into fetch_initial_state_data so
it entirely pulls from register_ret for #3853
2017-04-28 23:16:32 -07:00
df8f4a837c
home: Get page_params.enable_desktop_notifications from register_ret.
2017-04-28 23:15:35 -07:00
c4eeb13353
account-settings: Always display the medium-size avatar.
2017-04-28 23:09:32 -07:00
4696819629
Restructure format of avatar events and push into register_ret.
...
This moves the avatar_ fields in page_params to come from
register_ret. Unlike many fields, changing this had a bit of
complexity, because the avatar update events didn't actually contain
some of the details required for moving these into register_ret to
work correctly without races.
We fix that as part of this change.
Modified significantly by tabbott.
2017-04-28 23:04:01 -07:00
c63466cae3
home: Get pm_content_in_desktop_notifications from register_ret.
2017-04-28 22:06:32 -07:00
2a16cc1d24
home: Get enable_stream_desktop_notifications from register_ret.
2017-04-28 22:01:46 -07:00
2a8a101fe2
home: Get page_params.enable_stream_sounds from register_ret.
2017-04-28 21:56:58 -07:00
30db811167
home: Get page_params.enable_sounds from register_ret.
2017-04-28 21:54:05 -07:00
a0ef1210eb
home: Get enable_offline_email_notifications from register_ret.
2017-04-28 21:51:41 -07:00
1141111b74
home: Get enable_online_push_notifications from register_ret.
2017-04-28 21:51:07 -07:00
68cdbdd478
home: Get enable_offline_push_notifications from register_ret.
2017-04-28 21:50:41 -07:00
ba384240b0
home: Get enable_digest_emails from register_ret.
2017-04-28 21:50:12 -07:00
83191cfadf
home.py: move timezone to register_ret.
...
Moving the user_profile data section down into fetch_initial_state_data
so it entirely pulls from register_ret in #3853
2017-04-28 21:40:37 -07:00
Steve Howell
Brock Whittaker
Tim Abbott
K.Kanakhin
Jack Zhang
Alexander Trost
Eeshan Garg
Aditya Bansal
fionabunny