Aman Agrawal
e7a5588cb3
drafts: Remove unused css property.
...
Since width of drafts-container is set to 58% above, this
property never gets used.
2020-11-02 12:09:34 -08:00
Aman Agrawal
93e99d0ebd
settings: Remove unused css property.
...
There is no sidebar-bottom-anchor in our codebase, because it was
removed in 96caebf38f
.
2020-11-02 12:07:30 -08:00
akshatdalton
620e9cbf72
markdown: Fix merging of separate quotations.
...
Initally, when writing two or more quotes, having
a blank line in between them, merges those quotes.
This created confusion especially in "quote and reply".
This commit fixes such issues. Now two or more quotes
having a blank line in between them, will not get merged.
This change is correct both for usability and for improving our
compatibility with CommonMark.
Fixes #14379 .
2020-10-30 15:21:15 -07:00
Tim Abbott
cba7425cdc
docs: Clean up email testing docs a bit more.
2020-10-30 12:15:27 -07:00
Tim Abbott
f2b9109be5
docs: Tweak email testing notes a bit more.
2020-10-30 12:08:36 -07:00
Vishnu KS
ebe92fe70a
docs: Simplify email testing notes section.
...
No good reason for one note to be bold compared to
other notes.
2020-10-30 11:50:30 -07:00
Vishnu KS
7a6285ede7
email testing: Store the SMTP settings in dev-secrets.
...
It's super annoying to set this up each time I have to test
email templates in gmail.
2020-10-30 11:50:30 -07:00
Vishnu KS
95cd031274
version: Bump provision version for updating email templates.
2020-10-30 11:50:30 -07:00
Vishnu KS
ff754ee528
emails: Pass help link as variable in password reset email.
2020-10-30 11:50:30 -07:00
Vishnu KS
0eec12ad8b
emails: Pass reset link as variable in notify new login email.
2020-10-30 11:50:30 -07:00
Vishnu KS
0853c866a9
emails: Use link tag macro for realm uri in password reset email.
2020-10-30 11:50:30 -07:00
Vishnu KS
e53008410a
emails: Use email tag macro for email in password reset email.
2020-10-30 11:50:30 -07:00
Vishnu KS
1c08ea8134
emails: Use trans tag for ladap username in followup day 1 email.
2020-10-30 11:50:30 -07:00
Vishnu KS
abc5fb6cea
emails: Use email tag macro for email in followup day1 email.
2020-10-30 11:50:30 -07:00
Vishnu KS
df882d1563
emails: Use link tag macro for realm_uri in followup day1 email.
2020-10-30 11:50:30 -07:00
Vishnu KS
cb6ab43ba2
emails: Use link tag macro for realm_uri in realm reactivation email.
2020-10-30 11:50:30 -07:00
Vishnu KS
36b00b6b96
emails: Use email tag macro for old and new emails in confirm new email.
2020-10-30 11:50:30 -07:00
Vishnu KS
c06d8f9e45
emails: Use link tag macro for realm_uri in confirm new email.
2020-10-30 11:50:30 -07:00
Vishnu KS
4b784f8869
emails: Use macros for link tags in new login email.
2020-10-30 11:50:30 -07:00
Vishnu KS
8abf6897cb
emails: Use macros for email tags in realm reactivation email.
2020-10-30 11:50:30 -07:00
Vishnu KS
01a92abf12
emails: Use macros for email tags in notify new login email.
2020-10-30 11:50:30 -07:00
Vishnu KS
3bac784590
emails: Use macros for email tags in notify change in email.
2020-10-30 11:50:30 -07:00
Vishnu KS
689c636e29
emails: Use macros for email tags in confirm registration email.
2020-10-30 11:50:30 -07:00
Vishnu KS
0d56f3d73e
emails: Use macros for email tags in verify new email.
2020-10-30 11:50:30 -07:00
Vishnu KS
2caee3d68c
emails: Use macros for email tags in invitation reminder email.
2020-10-30 11:50:30 -07:00
Vishnu KS
eb008fc864
emails: Use macros for email tags in invitation email.
2020-10-30 11:50:30 -07:00
Anders Kaseorg
b98434682e
styles: Convert [readonly] selector to :read-only pseudo-class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:46:57 -07:00
Anders Kaseorg
192f1eb0fc
styles: Convert [disabled] selectors to :disabled pseudo-class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:46:57 -07:00
Mateusz Mandera
cbeeadab16
delete_realm: Register a post_delete Realm handler.
...
By registering a post_delete handler to clear appropriate caches in a
nicer way, we can get rid of the ugly flush-memcached call in the
delete_realm command.
2020-10-30 11:43:03 -07:00
Alex Vandiver
bff503feb4
delete_realm: Add command to completely remove realms.
...
This will need some tweaking in upcoming commits.
2020-10-30 11:42:40 -07:00
Anders Kaseorg
3c663e48db
url_encoding: Skip unnecessary encode before quote.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Anders Kaseorg
df10b306a6
python: Remove force_bytes.
...
We are generally good enough at types to know whether a value is str
or bytes.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Anders Kaseorg
cc55393671
python: Open text files as text to skip decode operations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Anders Kaseorg
18d0e4664c
python: Replace binascii with bytes.hex to skip some decode operations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Anders Kaseorg
aaa7b766d8
python: Use universal_newlines to get str from subprocess.
...
We can replace ‘universal_newlines’ with ‘text’ when we bump our
minimum Python version to 3.7.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Anders Kaseorg
9281dccae4
python: Serialize lxml elements directly to str.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Anders Kaseorg
7c4f68d9cf
python: Skip unnecessary decode before BeautifulSoup parsing.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Anders Kaseorg
86e8d81c7f
python: Skip unnecessary decode before JSON parsing.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Anders Kaseorg
1802a50cc9
python: Use requests.Response.text instead of decoding content.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
Tim Abbott
5fb667cf9e
templates: Make sure users know deletion is for everyone.
...
Implements a proposal I suggested in #16426 .
2020-10-29 17:25:40 -07:00
Tim Abbott
5bfafae764
docs: Improve linking of documentation around message deletion.
...
This should help users confirm their understanding of how deletion
works in Zulip starting from the actual deletion UI.
2020-10-29 17:12:49 -07:00
aryanshridhar
c591141d7c
popover: Fixed color-picker popover responsiveness.
...
Color-picker overflows the screen width when an user
attempts to change color of the stream in small devices.
Fixed by making it fullscreen in narrow devices.
Fixes #16477
2020-10-29 16:56:02 -07:00
Vishnu KS
2ae70ff76c
i18n: Translate who reacted tooltip message.
2020-10-29 16:50:01 -07:00
Tim Abbott
067cd3a97a
docs: Remove incorrect references to chat.zulip.org.
...
Most of these are Help Center links that should be pointing to the
production Help Center.
2020-10-29 16:46:40 -07:00
Vishnu KS
d4f5cea559
docs: Mark chat.zulip.org as an external link for testing.
...
The comment explains the background, but basically there's no purpose
in trying to verify this via CI.
2020-10-29 16:42:17 -07:00
Harsh Sharma
966bbf6b3d
right_sidebar: Change keyboard help tooltip to float left.
...
Floating upwards caused a weird flickering effect if the mouse floated
onto the tooltip's body, and it's still reasonable UI floating left
(and also there's guaranteed to be space).
Fixes #16438 .
2020-10-29 16:17:33 -07:00
Tim Abbott
3b9c726fc6
outgoing_webhook: Avoid logging a bytes string.
...
This fixes the new assertLogs() tests failing in CI; we fixed the
weird use of bytes in the test, but not in the runtime code.
2020-10-29 15:55:11 -07:00
sahil839
7106069d4d
migration: Add migration to remove default status of private streams.
...
This commit adds migration which removes default status of exisitng
default private streams, i.e. private stream exists but they are no
longer default.
2020-10-29 15:47:34 -07:00
sahil839
8d783e9d46
streams: Show error when trying to make a default stream private.
...
We show failure message in stream privacy modal when user tries to
set a default stream as private.
2020-10-29 15:47:34 -07:00
sahil839
1477416515
stream_data: Exclude private streams from get_non_default_stream_names.
...
We do not show private streams in default streams typeahead as we do
not allow to set private stream as default.
2020-10-29 15:47:34 -07:00