If we don't do this, we get all kinds of nasty shadowing where
references to 'search.whatever' seem to be references to the
HTML input element, rather than our search.js module.
(imported from commit 4e4b562ddf895baea9619316d9fab27ae5e9fc4e)
Personals are now just private messages between two people (which
sometimes manifests as a private message with one recipient). The
new message type on the send path is 'private'. Note that the receive
path still has 'personal' and 'huddle' message types.
(imported from commit 97a438ef5c0b3db4eb3e6db674ea38a081265dd3)
And having the onchange there e.g. breaks shift+tab in the subject
field after you've entered new text into the subject field
(imported from commit 080e81bd847a1b6d3defadb62b6c3640910e5aa0)
This reverts commit 429e055d3eca65af8bc0fe58481a7becf9ced66a.
There is some inconsistency between the names 'huddle' and 'personal' that is
breaking things.
(imported from commit 4c81853fca9d88d13ce8f23e2d6884c33cdc57d2)
This reverts commit 1a52ceaf00670e0861f5b7f043da78baff6bebe5.
It actually makes the composebox somewhat glitchy,
which I didn't notice locally.
(imported from commit cee0fac9bb61a710923301de1d51f86f7ffa5067)
This isn't used by our CSS or Javascript, and we're trying to get rid of the
"zephyr" name.
(imported from commit c3cae24168088eef2bb64944d9a1bd1d8be4b59d)
Documentation variously says to disable on the form or on the input box, e.g.:
https://developer.mozilla.org/en-US/docs/How_to_Turn_Off_Form_Autocompletionhttp://msdn.microsoft.com/en-us/library/ms533486%28VS.85%29.aspx
However, at least in Chrome, disabling on the form produces an ugly
"This webpage has disabled autocomplete" message if you try to arrow
down on an input box as if there were suggestions, so I've just put it
on the input element. This still works on recent versions of Safari
and Firefox.
(imported from commit b47f438d6e1d930d7d6871070858c97c6479a0ae)
This reverts commit 074011dfe7dfa4d3cb331b32fc6cf465f98d095f. For
some reason this introduces some buggy behavior, and if anything I
should debug it more locally first.
(imported from commit 182193e6bb466a5668c2bb64e41712a793fa7ca2)
The order is:
- Stream/huddle selector buttons
- Stream name or huddle recipients
- Subject (in stream mode only)
- Body
- Send button
In huddle mode you can't Shift-Tab back to the selector buttons. I'm not sure
how to fix this.
We leave gaps in the numbering, BASIC style, to simplify future changes.
(imported from commit 562742c8e7d31620eac3ef171397d830b5eb3bb8)
Ideally this would be part of hiding zhome, but right now zhome/zfilt are
assumed to the tables themselves, and changing that seems unfortunately
invasive. And it's not crazy to think of the "loading controls" as a logically
separate thing that we might show/hide independently.
Longer term, we may want an indication in narrowed view that there could be
more messages on the server.
(imported from commit eb72d720da7c03f6f1378ae18ab6e973bf98247f)
Waseem Daher
Zev Benjamin
Jeff Arnold
Tim Abbott
Keegan McAllister
Jessica McKellar