104 Commits

Author	SHA1	Message	Date
Harshit Bansal	d827cc878b	emoji.js: Remove unnecessary indirection. ... Remove unnecessary function `emoji_name_to_css_class()` called while populating `emojis_name_to_css_class` dict.	2017-05-17 08:09:50 -07:00
Steve Howell	87f5c22593	Simplify how we find the current user's emoji reactions. ... This adds the current_user_has_reacted_to_emoji() helper. This new helper is easier to use and slightly more efficient than calling get_user_list_for_message_reaction() and then indexOf(). This also replaces one call to get_user_list_for_message_reaction() with a list of user_ids that we already had locally. The node tests were improved a bit here, including a minor whitespace fixup.	2017-05-11 09:39:17 -07:00
Steve Howell	cf6545a71f	reactions: Only warn for unknown user ids. ... If we get reactions for deactivated users, or otherwise missing users, we only issue a blueslip warning now. The function get_message_reactions() was indirectly causing blueslip errors before this fix, but we can downgrade to warnings now that this function has better unit tests around it. We eventually want to track deactivated users on the client. Fixes #4289	2017-03-26 11:51:36 -07:00
Steve Howell	03b7e59b59	node tests: Add reactions.js test module. ... We test get_message_reactions() in our first test here.	2017-03-26 11:39:05 -07:00