zulip

Commit Graph

Author	SHA1	Message	Date
Steve Howell	5f53fb1561	refactor: Remove factory code for toggle component. We now have components.toggle simply return an object, without putting the object into a lookup table. The consumers of the objects have all been changed to just store the object in their own module scope. The diff is a bit hard to read here, but it's mostly de-denting code and removing these things: - we don't have opts.name - we don't have __toggle.lookup - we don't have keys - we don't create a sibling object to the prototype object	2018-04-20 13:45:58 -07:00
Steve Howell	f73bfd2a5c	refactor: Extract settings_toggle.js. This mostly moves code, and we also abandon the lookup mechanism for finding our toggler.	2018-04-20 13:45:58 -07:00

Author

SHA1

Message

Date

Steve Howell

5f53fb1561

refactor: Remove factory code for toggle component.

We now have components.toggle simply return an object, without
putting the object into a lookup table.  The consumers of the
objects have all been changed to just store the object in their
own module scope.

The diff is a bit hard to read here, but it's mostly de-denting
code and removing these things:

        - we don't have opts.name
        - we don't have __toggle.lookup
        - we don't have keys
        - we don't create a sibling object to the prototype object

2018-04-20 13:45:58 -07:00

Steve Howell

f73bfd2a5c

refactor: Extract settings_toggle.js.

This mostly moves code, and we also abandon the lookup mechanism
for finding our toggler.

2018-04-20 13:45:58 -07:00

2 Commits