Tim Abbott
76d49300b3
message_edit: Move original_topic variable to a better spot.
2016-10-22 18:52:49 -07:00
Tim Abbott
0acfcbe247
message_edit: Update currently_editing_messages in clearer place.
2016-10-22 18:52:49 -07:00
Tim Abbott
d2501396cf
message_edit: Reindent form definition.
2016-10-22 18:52:45 -07:00
Tim Abbott
2b58fa0a19
message_edit: Move some setup code closer to where it's used.
...
This has no functional changes.
2016-10-22 18:40:44 -07:00
Rishi Gupta
ebc8bfa6ca
javascript: Change all message.is_stream to (message.type === "stream").
...
We need message.is_stream for some handlebars template code, but
message.is_stream should be thought of as a private variable for that
template.
2016-10-22 18:11:08 -07:00
Steve Howell
c21fe60430
Add make_stream() to django testing docs.
2016-10-22 18:09:34 -07:00
Steve Howell
4d6af33bad
Use make_stream() in test_subs.py.
2016-10-22 18:09:34 -07:00
Steve Howell
2a739318b9
Use make_stream() in test_signup.py.
2016-10-22 18:09:34 -07:00
Steve Howell
8410159af2
Use make_stream() in test_narrow.py.
2016-10-22 18:09:34 -07:00
Steve Howell
b1ebb09c96
Use make_stream() in test_messages.py.
2016-10-22 18:09:34 -07:00
Steve Howell
0861421912
Use make_stream() in test_events.py.
2016-10-22 18:09:34 -07:00
Steve Howell
79b6f3d39d
Create ZulipTestCase.make_stream().
2016-10-22 18:09:34 -07:00
deekshaarul
be903382f8
lint: Add rule to check for misspellings of 'GitHub'.
2016-10-22 17:09:55 -07:00
K.Kanakhin
16c3da6db5
tests: Add tests for SEND_MISSED_MESSAGE_EMAILS_AS_USER=False.
...
- Add tests for SEND_MISSED_MESSAGE_EMAILS_AS_USER is False (the
default!).
- Reorganized test case code by removing repeated parts of code,
improving code style and moving common parts to separate class
methods.
Fixes #1697 .
2016-10-21 08:47:24 -07:00
Umair Khan
8891731d7d
is_template_database_current: Open file in write mode.
2016-10-21 08:35:30 -07:00
Umair Khan
b894135fae
Check postgres-init-dev-db in is_template_database_current.
2016-10-21 08:35:30 -07:00
Umair Khan
176825d335
Refactor is_template_database_current.
...
Now all the files whose hash is to be checked are passed as a list
argument.
2016-10-21 08:35:30 -07:00
Umair Khan
bf4e0800e3
is_template_database_current: Create hashes in var/test_db_status.
2016-10-21 08:35:30 -07:00
Umair Khan
a2c57db630
Use argparse in provision.py
2016-10-21 08:35:30 -07:00
Umair Khan
8ade9e2408
Add tests to check subdomains with auth decorators.
...
Fixes : #1870
2016-10-21 12:21:47 +05:00
Tomasz Kolek
6e1674aca5
Normalize github issue or PR comment event's subject and content.
2016-10-20 23:15:51 -07:00
Tomasz Kolek
56dd1a9b90
Normalize gitlab issue event's subject and content.
2016-10-20 23:15:30 -07:00
Tomasz Kolek
a8da46db92
Normalize bitbucket issue event's subject and content.
2016-10-20 23:15:30 -07:00
Tomasz Kolek
171a4861cc
Normalize github issue event's subject and content.
2016-10-20 23:15:30 -07:00
Tomasz Kolek
89d53a0640
Change name of PR subject template to be applicable for issues.
2016-10-20 23:15:30 -07:00
Tomasz Kolek
289f400c8c
Add git integrations method to build message for issues events.
2016-10-20 23:15:30 -07:00
Arpith Siromoney
ee97ba04fe
Add an API endpoint to send typing notification events.
...
POST to /typing creates a typing event
Required parameters are 'op' ('start' or 'stop') and 'to' (recipient
emails). If there are multiple recipients, the 'to' parameter
should be a JSON string of the list of recipient emails.
The event created looks like:
{
'type': 'typing',
'op': 'start',
'sender': 'hamlet@zulip.com',
'recipients': [{
'id': 1,
'email': 'othello@zulip.com'
}]
}
2016-10-20 23:05:18 -07:00
Prabhakar Gupta
bc6421fbfb
tools: Remove empty wrapper script build_emoji.
...
This renames the old `emoji_dump.py` to `build_emoji`, removing the
old shell essentially empty shell script. `emoji_dump.py` was always
a weird name, and this makes it a bit easier to read the code for this
system.
2016-10-20 22:57:45 -07:00
Sumana Harihareswara
2083ffa7a6
docs: Improve export documentation.
...
Added user and realm export guidance in production maintenance docs,
linked to conversion guide, and revamped the introduction and styled
the text that Steve wrote.
2016-10-20 22:52:32 -07:00
Sumana Harihareswara
d9d389f64f
docs: Add an initial code review document.
...
A first pass at a code review guide. Mostly Tim's draft; I added
polish and links.
Fixes : #758 .
2016-10-20 22:41:38 -07:00
Tim Abbott
f9f8b18e2f
lint: Ban use of json_success({}) instead of json_success().
2016-10-20 22:34:04 -07:00
Amy Liu
3ee777a11a
Add UI for deactivating your own Zulip account.
...
Fixes #1009 .
2016-10-20 22:29:30 -07:00
Tim Abbott
3d183ffe23
text_fixtures: Fix case where source_hash_file doesn't exist.
...
We unfortunately just broke provisioning because we didn't correctly
handle the case where the source_hash_file didn't exist.
2016-10-20 22:21:45 -07:00
Steve Howell
409a84698c
Handle peer_remove events correctly for subscriptions.
...
We now send peer_remove events to folks who have never subscribed
to the streams (except for private streams and zephyr).
We also use logic that is more similar to how
bulk_add_subscriptions() works.
2016-10-20 22:05:19 -07:00
Steve Howell
68ae4da626
Extract query_all_subs_by_stream().
...
This code was in bulk_add_subscriptions, but we want the same logic
to eventually happen in bulk_remove_subscriptions.
2016-10-20 22:05:19 -07:00
Steve Howell
d13b0554b3
Remove emails_by_stream in bulk_add_subscription().
...
There are so many collections in this function, it's hard to keep
them all straight. This one is fairly redundant, so it was easy
to remove.
2016-10-20 22:05:19 -07:00
Steve Howell
d706bfa69f
Move some code from notify_subscriptions_removed().
...
There are two reasons for this change. First, we want to be
consistent with notify_subscriptions_added(), which doesn't
handle "peer" events. Second, we want to fix this code in a
subsequent commit not to do one user at a time, which is
inefficient.
2016-10-20 22:05:19 -07:00
Steve Howell
dda4c61f2a
Remove do_remove_subscription().
2016-10-20 22:05:19 -07:00
Steve Howell
cba8be6bbb
Use bulk_remove_subscriptions() in remove_users_from_stream.
...
We are deprecating do_remove_subscription.
2016-10-20 22:05:19 -07:00
Steve Howell
4ae117ed14
Use bulk_remove_subscriptions() in do_deactivate_stream().
...
We are deprecating do_remove_subscription().
2016-10-20 22:05:19 -07:00
Steve Howell
77c75df284
Remove do_remove_subscription() calls in test_events.
2016-10-20 22:05:19 -07:00
Steve Howell
44bbece5a6
Remove do_remove_subscription() calls in tests.py.
2016-10-20 22:05:19 -07:00
Steve Howell
b2d06fad42
Extract get_peer_user_ids_for_stream_change().
2016-10-20 22:05:19 -07:00
Steve Howell
5eee77fe81
Remove do_add_subcription().
2016-10-20 22:05:19 -07:00
Steve Howell
76acab36b2
Remove do_add_subscription from Django testing docs.
2016-10-20 22:05:19 -07:00
Steve Howell
98e4452e07
Replace do_add_subscription() in add_users_to_streams.
2016-10-20 22:05:19 -07:00
Steve Howell
bea8ba620b
Replace do_add_subscription() in tests/tests.py.
2016-10-20 22:05:19 -07:00
Steve Howell
9408ba7ca8
Replace do_add_subscription() in test_subs.
2016-10-20 22:05:19 -07:00
Steve Howell
45790264c2
Replace do_add_subscription() in test_signup.
2016-10-20 22:05:19 -07:00
Steve Howell
f4fc8455de
Replace do_add_subscription() in test_narrow.
2016-10-20 22:05:19 -07:00