Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
49,496 Commits 28 Branches 143 Tags 633 MiB
Commit Graph

63 Commits

Author SHA1 Message Date
Steve Howell a49ba8c577 Extract user_message_exists_for_topic(). 2018-11-12 15:47:11 -08:00
Steve Howell 39e5c61d4a Extact MATCH_TOPIC constant. 2018-11-12 15:47:11 -08:00
Steve Howell 8981b65bbc Extract topic_column_sa(). 2018-11-12 15:47:11 -08:00
Steve Howell 226a2826b5 Remove "subject" from zerver/lib/message.py. 
We also lock this down file in the linter, so
that you can no longer introduce "subject"
to `message.py`.
 2018-11-08 14:45:16 +00:00
Steve Howell 592dd290b2 Avoid "subject" in MessageDict. 2018-11-08 14:33:44 +00:00
Steve Howell ff60055fa4 Use topic_match_sa() for topic searches. 
Note this introduce literal(), which makes the way
we handle topic mutes more consistent with general
topic searches.
 2018-11-07 10:03:53 -08:00
Steve Howell 79d5e36ca3 Extract topic_match_sa() helper. 
We'll also use this in zerver/views/messages.py, but
that's a bigger change.
 2018-11-07 10:03:53 -08:00
Steve Howell 2cf46f0122 Extract save_message_for_edit_use_case(). 
This is mostly extracted to help clean out
all "subject" references from actions.py.
 2018-11-07 10:03:53 -08:00
Steve Howell 0cf4cddc5b Extract update_messages_for_topic_edit(). 
This is somewhat hairy logic, so it's nice
to extract it and not worry about variable leaks.

Also, this moves some legacy "subject" references out
of actions.py.
 2018-11-07 10:03:53 -08:00
Steve Howell 0e854288ee Add some string constants to topic.py. 
The goal here is to make it easy to
forbid "subject" in actions.py.
 2018-11-07 10:03:53 -08:00
Steve Howell 7252861785 Extract filter_by_topic_name_via_message. 2018-11-07 10:03:53 -08:00
Steve Howell dc8f893494 Extract filter_by_exact_message_topic(). 2018-11-07 10:03:53 -08:00
Steve Howell 50e3f85557 Extract topic.py library. 
We start by including functions that do custom
queries for topic history.

The goal of this library is partly to quarantine
the legacy "subject" column on Message.
 2018-11-07 10:03:53 -08:00