umkay
c1a8fb615c
mypy: Fix strict-optional errors in webhooks directory.
2017-05-24 18:57:06 -07:00
Christian Hudon
8ab6a23a30
Fix most strict-optional issues in export.py.
2017-05-24 18:50:59 -07:00
Christian Hudon
1761a3b1c1
mypy: strict optional fixes.
2017-05-24 18:50:59 -07:00
Eklavya Sharma
2f227a97d3
mypy: Make zerver/lib/actions.py pass --strict-optional check.
2017-05-24 18:49:54 -07:00
Eklavya Sharma
1d8c316ff0
mypy: Make email_mirror pass --strict-optional check.
2017-05-24 18:49:54 -07:00
Eklavya Sharma
690b6025fb
mypy: Fix return type of a function.
2017-05-24 18:43:51 -07:00
Christian Hudon
14e871ce9c
Change order of arguments so output_dir is not optional. Helps mypy too.
2017-05-24 17:32:21 -07:00
Eeshan Garg
b5d271456a
webhooks/trello: Use parametric Markdown macros.
2017-05-24 17:00:19 -07:00
Eeshan Garg
e9b3b56105
webhooks/appfollow: Use parametric Markdown macros.
2017-05-24 17:00:19 -07:00
Eeshan Garg
c433a7981a
webhooks/airbrake: Use parametric Markdown macros for documentation.
2017-05-24 17:00:19 -07:00
Eeshan Garg
3cb758d339
templates: Support parametric Markdown macros for webhooks docs.
2017-05-24 17:00:19 -07:00
Tim Abbott
e9968a7a09
change_user_email: Use new get_user_for_mgmt function.
2017-05-24 15:29:59 -07:00
Vishnu Ks
17b1a8b260
Add get_user_for_mgmt function.
2017-05-24 15:27:48 -07:00
Tim Abbott
6aaca44e17
tests: Fix str/Text mypy issues in various tests.
2017-05-24 15:19:38 -07:00
Andrew Archer
6c3f89af1c
tests: Remove get_user_profile_by_email from numerous tests.
2017-05-24 15:19:20 -07:00
Rick Chern
e53d1c3885
tests: Remove get_user_profile_by_email from most tests.
2017-05-24 13:05:19 -07:00
Vishnu Ks
4403d179df
tests: Replace mit_user().email with mit_email().
2017-05-24 12:44:43 -07:00
Tim Abbott
e5f5e5c69f
tests: Remove unnecessary maxDiff settings.
...
Now that ZulipTestCase does this, we don't need it in all these
individual test modules.
2017-05-24 12:43:28 -07:00
umkay
ccc70445d6
mypy: Fix strict-optional errors for test files.
...
Fix mypy --strict-optional errors in zerver/tests
2017-05-24 12:43:28 -07:00
Tim Abbott
17328a7557
tests: Fix incorrect use of get_realm_by_email_domain.
2017-05-24 12:43:28 -07:00
Tim Abbott
895d4a795b
mypy: Fix a missing type annotation.
2017-05-24 12:14:13 -07:00
Umair Khan
9a04fef71b
testing: Reset active language.
...
After running translation tests, we should reset the active
language to isolate the change
2017-05-24 11:35:17 -07:00
Umair Khan
ebb9bd1a6a
testing: Avoid class variables to enforce isolation.
...
Class variables are shared between all instances and as a result
changes made by one instance are leaked to other instances.
2017-05-24 11:35:12 -07:00
Yago González
c0f2036435
api: Handle unregistered users in dev_fetch_api_key.
...
Fixes #4851 .
2017-05-24 09:39:44 -07:00
Andrew Archer
67cf4c4fb4
test_alert_words: Remove use of get_user_profile_by_email.
2017-05-23 22:14:10 -07:00
Eklavya Sharma
bac874b7e3
mypy: Allow None in passwords while creating users.
2017-05-23 21:56:50 -07:00
Eklavya Sharma
cc1937c8d5
mypy: Use Optional with strings where required.
2017-05-23 21:56:50 -07:00
kb0rg
eb2d0ebd09
Add test for do_deactivate_realm exit if deactivated.
...
Rename existing test_do_deactivate_realm to indicate test purpose
is to confirm user realm cache clears when a realm is deactivated.
2017-05-23 21:38:07 -07:00
kb0rg
e672ec62c1
Add test for encode_email_address with empty Gateway.
2017-05-23 21:38:07 -07:00
kb0rg
d625cca2f8
minor: Rename test class -> TestEmptyGatewaySetting.
2017-05-23 21:38:07 -07:00
vaibhav
f94c321567
Outgoing Webhook System: Add support for personal message triggers.
2017-05-23 21:35:09 -07:00
Lech Kaiel
6b49e667ef
tests: Replaced @zulip.com references with self.example_ functions.
...
This cleans up the excessive use of @zulip.com emails in the tests.
2017-05-23 20:59:50 -07:00
Mark Shannon
c7c47fe11d
Replace buggy NotImplemented with NotImplementedError().
2017-05-23 20:33:35 -07:00
ron-s
e5d4e0f0eb
Test: Add test_notify_of_new_user_internally.
2017-05-23 20:27:37 -07:00
Steve Howell
036f66aba3
Add test_get_avatar_url_with_user_profile_lookup test.
2017-05-23 18:35:45 -07:00
Vishnu Ks
b5c4a95ef1
test_bots.py: Use example_email instead of using the emails directly.
2017-05-23 18:31:43 -07:00
Vishnu Ks
dbdc0220b9
test_presence.py: Remove unused get_user_profile_by_email import.
2017-05-23 18:31:43 -07:00
Jason Michalski
a22d6d2c2a
test-backend: Enable test coverage in multi-process mode.
...
We enable data_suffix option when creating Coverage instances which
causes the output files to include the hostname, pid, and random id.
Before each run erase is called which clears all existing coverage data
files. And then at the end of the test run use the combine method which
merges the reports.
We collect coverage in the main process which collects data from
imports and also when running in single process mode. In the workers we
collect coverage in run_subsuite. This creates more stats files than
strictly required but I don't see a better place to save the stats when
stopping workers.
Note that this has the side effect of enabling parallel testing in
Travis CI.
2017-05-23 18:25:13 -07:00
Tim Abbott
109c5c677a
mypy: Fix return value annotation for google_oauth2_csrf.
2017-05-23 17:47:03 -07:00
Tim Abbott
17f87cfc9e
mypy: Fix missing Optional on process_exception.
2017-05-23 17:44:30 -07:00
Tim Abbott
315a9ee72e
handlers: Fix type of zulip_finish.
2017-05-23 17:36:19 -07:00
Sarah
4c4444b2dc
zerver/lib/actions: Fix PEP8 E712 error.
2017-05-23 16:29:49 -07:00
Tim Abbott
796cf8e5fd
mypy: Fix a buggy annotation in create_mirrored_message_users.
2017-05-23 15:45:56 -07:00
Andrew Archer
40b3330f2c
actions: Refactor get_user_profile_by_email to get_user.
2017-05-23 15:30:14 -07:00
Vishnu Ks
2b36df6b8f
test_sessions.py: Use helpers instead of get_user_profile_by_email.
2017-05-23 15:27:21 -07:00
Vishnu Ks
dafa89d52b
test_outgoing_webhook_system.py: Replace get_user_profile_by_email with example_user.
2017-05-23 15:27:21 -07:00
Vishnu Ks
f5d8e256aa
Add ZulipTestCase.example_email and ZulipTestCase.mit_email function.
2017-05-23 15:27:21 -07:00
Vishnu Ks
075b0cae70
test_bugdown.py: Remove unused get_user_profile_by_email import.
2017-05-23 15:27:21 -07:00
Vishnu Ks
7950f5242a
test_unread.py: Replace get_user_profile_by_email with get_user.
2017-05-23 15:27:21 -07:00
Vishnu Ks
789ef217a8
send_email.py: Remove unused get_user_profile_by_email import.
2017-05-23 15:27:21 -07:00
Tim Abbott
a833fa39b8
test_messages: Fix tests failing due to error message change.
2017-05-23 15:27:21 -07:00
Yago González
83f3959906
api: Remove unnecessary period for consistency.
2017-05-23 15:01:26 -07:00
Matt Long
19363b2b77
notification_settings: Refactor notification preference settings.
...
Previously, all notification preference setting had a dedicated test
and setter. Now, all are handled through a modular function using the
property_types framework.
2017-05-23 14:47:46 -07:00
Christian Hudon
c80e6edb4e
mypy: Declare models with null=True Optional.
2017-05-23 14:36:40 -07:00
Rick Chern
70d68f7e71
Refactoring: Replace get_user_profile_by_email() in lib/upload.py
2017-05-23 12:37:49 -07:00
Steve Howell
484f32646b
Rename file to test_new_users.py.
...
The old file name of test_send_login_emails was
overly specific, and we want to add some tests
related to other parts of the signup process.
2017-05-23 12:34:44 -07:00
umkay
dd55d5b683
mypy: Fix bad type annotation
2017-05-23 10:42:44 -07:00
umkay
a67e427293
mypy: Add comment for future use of Deque.
...
In the future, the type annotation should use Deque in order to be
compatible with the latest mypy version. See
https://github.com/python/mypy/pull/2845 for more info.
2017-05-23 10:42:44 -07:00
Konstantin Gukov
c40759562c
streams: Refactor get_user_profile_by_email to get_user.
2017-05-23 10:32:53 -07:00
Konstantin Gukov
dd76222a3f
Fetch system bots using new get_system_bot function.
...
This eliminate a bunch of uninteresting calls to
get_user_profile_by_email.
2017-05-23 10:30:40 -07:00
vaibhav
287aaa21b6
Outgoing Webhook System: Add outgoing webhook queue worker.
2017-05-23 08:21:08 -07:00
vaibhav
c7524f2f38
Outgoing Webhook System: Prevent infinite loops with outgoing webhooks.
2017-05-23 08:20:45 -07:00
vaibhav
53a8b2ac87
Outgoing Webhook System: Add DoRestCall and helper functions
2017-05-23 08:19:16 -07:00
Vishnu Ks
820dc9dd9a
Replace espuser@mit.edu with mit_user('espuser').
2017-05-22 19:02:42 -07:00
Vishnu Ks
99fc0e9e62
Replace starnine@mit.edu with mit_user('starnine').
2017-05-22 19:02:42 -07:00
Vishnu Ks
c680c5f1e8
Replace sipbtest@mit.edu with mit_user('sipbtest').
2017-05-22 19:02:42 -07:00
Vishnu Ks
7f06a7fa2a
Add ZulipTestCase.mit_user() function.
2017-05-22 19:02:42 -07:00
Vishnu Ks
05951074be
Make MITNameTest use ZulipTestCase instead of TestCase.
2017-05-22 19:02:42 -07:00
Eeshan Garg
ed8c6943f2
webhooks/airbrake: Use Markdown macros for documentation.
2017-05-22 18:19:14 -07:00
Eeshan Garg
baff121115
app_filters: Render HTML to render Jinja2 syntax within Markdown macros.
...
If a Markdown macro contains Jinja2 template code, it isn't rendered
because render_markdown_path calls template.render on the including
.md file before the macro has been included. And then the including
.md file is converted to HTML. Therefore, the template code within
a Markdown macro (if any) never gets rendered and is returned as it is.
Now, after the source .md file is converted to HTML,
render_markdown_path renders the resulting HTML so that any template
code within included macros (if any) is finally rendered.
2017-05-22 18:19:14 -07:00
JoshuaGoldin
0b88957d12
views: Use property_types for display settings.
...
This reduces semi-duplicated code here.
2017-05-22 18:11:08 -07:00
Lukasz Prasol
5eaccc550a
rate_limit: Make retry-after data machine-readable.
...
Fixes #4831 .
2017-05-22 17:35:12 -07:00
Lukasz Prasol
01f7d9d651
zerver/lib/events: Refactor get_user_profile_by_email to get_user.
...
Fixes #4831 .
2017-05-22 17:32:36 -07:00
Tim Abbott
accc7406da
views/presence: Refactor get_user_profile_by_email -> get_user.
2017-05-22 16:43:08 -07:00
Lech Kaiel
7995dd2de6
views/users: Refactor get_user_profile_by_email to get_user.
2017-05-22 16:42:16 -07:00
umkay
510b7a0489
mypy: Add ignore type for dynamically added field on LogRecord.
...
mypy will error because of the attribute "request" on the LogRecord
object. Since this field is added in our tests dynamically and is not
on the base object, for now we will ignore the type.
2017-05-22 14:38:39 -07:00
Vishnu Ks
bdf7c6c02f
models: Add get_user function.
...
This is intended to replace get_user_profile_by_email.
2017-05-22 11:26:44 -07:00
Tim Abbott
040067b2a2
invite: Remove obsolete bulk_invite_users endpoint.
2017-05-17 17:30:15 -07:00
Aditya Bansal
092d670e85
pep8: Add compliance with rule E261 to zerver/views/user_settings.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
cc2b334020
pep8: Add compliance with rule E261 to zerver/views/streams.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
11aeeec2ab
pep8: Add compliance with rule E261 to zerver/views/registration.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
5cdfd899dc
pep8: Add compliance with rule E261 to zerver/views/realm.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
db3c05002a
pep8: Add compliance with rule E261 to zerver/views/presence.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
634c08c3dd
pep8: Add compliance with rule E261 to zerver/views/messages.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
35e3d57ed9
pep8: Add compliance with rule E261 to zerver/views/invite.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
1979476152
pep8: Add compliance with rule E261 to zerver/views/integrations.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
fe3b42c8f8
pep8: Add compliance with rule E261 to zerver/views/home.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
c504b013b1
pep8: Add compliance with rule E261 to views/auth.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
57bc847874
pep8: Add compliance with rule E261 to test_urls.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
85aa07e2d4
pep8: Add compliance with rule E261 to zerver/lib/upload.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
b7c49299a6
pep8: Add compliance with rule E261 to test_runner.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
e3003653c7
pep8: Add compliance with rule E261 to test_helpers.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
26ff19f005
pep8: Add compliance with rule E261 to zerver/lib/test_classes.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
1f1fbd7648
pep8: Add compliance with rule E261 to zerver/lib/notifications.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
84eadc0562
pep8: Add compliance with rule E261 to zerver/lib/message.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
03e43b78ee
pep8: Add compliance with rule E261 to zerver/lib/html_diff.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
b822e75a4b
pep8: Add compliance with rule E261 to export.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
4c373dde63
pep8: Add compliance with rule E261 to events.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
1a184263b8
pep8: Add compliance with rule E261 to zerver/lib/db.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
420230b342
pep8: Add compliance with rule E261 to actions.py.
2017-05-18 03:00:32 +05:30