60a25b2721
docs: Fix spelling errors caught by codespell.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-11 10:23:06 -07:00
2928bbc8bd
logging: Report stack_info on logging.exception calls.
...
The exception trace only goes from where the exception was thrown up
to where the `logging.exception` call is; any context as to where
_that_ was called from is lost, unless `stack_info` is passed as well.
Having the stack is particularly useful for Sentry exceptions, which
gain the full stack trace.
Add `stack_info=True` on all `logging.exception` calls with a
non-trivial stack; we omit `wsgi.py`. Adjusts tests to match.
2020-08-11 10:16:54 -07:00
36bae2e86c
message_fetch: Use strings as dict keys.
...
JSON keys must be strings, and orjson enforces this.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-07 11:12:32 -07:00
80c0e60edc
integrations: Decode webhook responses to str.
...
bytes is not JSON serializable, and orjson enforces this.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-07 11:12:32 -07:00
28143c0ee2
drafts: Use strings as dict keys.
...
JSON keys must be strings, and orjson enforces this.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-07 10:53:06 -07:00
bb46b21123
find_account: Fix the email search query.
...
The search should be case-insensitive.
2020-08-02 12:37:20 -07:00
a9af80d7a2
streams: Make /streams endpoint return also web-public streams.
...
This commit modifies the /streams endpoint so that the web-public
streams are included in the default list of streams that users
have access to.
This is part of PR #14638 that aims to allow guest users to
browse and subscribe themselves to web public streams.
2020-07-29 17:52:36 -07:00
21c9adbb3c
drafts: Add an API endpoint for fetching drafts.
...
This endpoint will allow a user to fetch their drafts.
Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-28 17:18:35 -07:00
630fd10be1
drafts: Add an API endpoint for deleting drafts.
...
This endpoint will allow a user to delete a single draft.
Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-28 17:18:35 -07:00
2d307c760e
drafts: Add an API endpoint for editing drafts.
...
This endpoint will allow a user to edit a single draft.
Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-28 17:18:35 -07:00
a0f71b7458
drafts: Add an API endpoint for creating drafts.
...
This endpoint will allow a user to create drafts in bulk.
Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-28 17:18:35 -07:00
9583554d44
auth: Add check_config for apple auth.
...
Apple has some other obligatory settings other than key and secret.
To handle that this commit adds a function check_config() similar
to that of SAML.
2020-07-28 17:12:49 -07:00
87d8a54b91
help: Stop collapsing sidebar sections.
...
Three reasons:
1. The sliding was disorienting.
2. The collapsing disallowed searching for other pages with Ctrl+F.
3. The collapsing mechanism wasn't accessible (not usable with the
keyboard / no ARIA tags).
Tweaked by tabbott to center the left sidebar on the selected page.
Part of #15948 .
2020-07-28 16:28:58 -07:00
ad23c6e808
emoji: Switch to `user_profile.realm` for cross-realm reactions.
...
A temporary fix to enable cross-realm emoji reactions till `Message.realm`
is denormalized.
Fixes #15866 .
2020-07-24 13:11:27 -07:00
0d79b55b2e
audit_log: Record RealmAuditLog in do_change_notification_settings.
...
Removed logging with log_event and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 12:04:40 -07:00
94d2de8b4a
audit_log: Record RealmAuditLog while changing default streams.
...
Removed logging with log_event and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 12:00:31 -07:00
753713fde7
audit_log: Record RealmAuditLog in do_change_subscription_property.
...
Removed logging with log_subscription_property_change
and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 12:00:29 -07:00
e6f54a3278
audit_log: Record RealmAuditLog in do_change_icon_source.
...
Removed logging with log_event and used RealmAuditLog instead.
Added tests in test_audit_log for the same.
2020-07-24 11:56:40 -07:00
ccdf52fef6
audit_log: Log RealmAuditLog for realm notification properties.
...
Log RealmAuditLog for do_set_realm_notifications_stream and
do_set_realm_signup_notifications_stream function.
Added tests for the same.
2020-07-24 11:51:47 -07:00
8f6a1c3f40
actions.py: Removed do_set_realm_message_deleting function.
...
Used do_set_realm_property function instead of
do_set_realm_message_deleting and removed it.
2020-07-24 11:51:47 -07:00
422fa0ff7d
audit_log: Log RealmAuditLog for do_set_realm_message_editing.
...
Log RealmAuditLog for do_set_realm_message_editing. Added tests for
same.
2020-07-24 11:51:46 -07:00
9e0ff58a6d
team: Rename contrib to contributors in page_params.
2020-07-23 10:22:28 -07:00
1fa6ae1e16
refactor: Extract build_page_params_for_home_page_load.
2020-07-22 17:15:03 -07:00
27072289ce
refactor: Extract zerver/lib/home.py.
...
The two functions extracted here are mostly
copied verbatim, but we use dataclasses
to marshal the values back.
2020-07-22 17:15:02 -07:00
26e4d34e81
refactor: Move code up higher in home view.
...
The two pieces of code here don't need to be
intermingled with the bigger task of building
page_params.
2020-07-22 17:13:53 -07:00
67bacd6e31
billing: Don't allow guest users to upgrade.
2020-07-22 16:57:49 -07:00
9efec1f929
auth: Clean up DevAuthBackend error messages.
...
We had a user confused by these error messages, which suggested they
needed to enable something rather than using a development
environment.
2020-07-21 12:55:11 -07:00
6be3fca037
auth: Remove short_name from LDAP API.
...
As best I can tell, we fetched this field and then ignored it, so
unlike the last few commits, this is more a code cleanup than a
functional change.
2020-07-17 11:28:08 -07:00
c44500175d
database: Remove short_name from UserProfile.
...
A few major themes here:
- We remove short_name from UserProfile
and add the appropriate migration.
- We remove short_name from various
cache-related lists of fields.
- We allow import tools to continue to
write short_name to their export files,
and then we simply ignore the field
at import time.
- We change functions like do_create_user,
create_user_profile, etc.
- We keep short_name in the /json/bots
API. (It actually gets turned into
an email.)
- We don't modify our LDAP code much
here.
2020-07-17 11:15:15 -07:00
c60f4236a9
api: Do not require short_name to create user.
...
When you post to /json/users, we no longer
require or look at the short_name parameter,
since we don't use it in any meaningful way.
An upcoming commit will eliminate it from the
database.
2020-07-17 11:15:15 -07:00
a2428017e9
audit_log: Log RealmAuditLog in do_set_realm_authentication_methods.
...
Log RealmAuditLog in do_set_realm_authentication_methods and added
tests for it.
2020-07-06 17:38:20 -07:00
ba92666dbd
audit_log: Log RealmAuditLog in do_set_realm_property.
...
Log RealmAuditLog in do_set_realm_property and do_remove_realm_domain.
Tests for the changes are written in test_events because it will save
duplicate code for test_change_realm_property.
2020-07-06 17:38:19 -07:00
6af337c07e
audit_log: Log RealmAuditLog when stream is deactivated.
2020-07-06 17:32:11 -07:00
87aaa84b42
audit_log: Log acting_user in do_change_user_role.
2020-07-06 17:32:11 -07:00
01f12b9fc2
audit_log: Log acting_user in user creation and user activation.
2020-07-06 17:32:09 -07:00
653928bdfe
audit_log: Log acting_user in do_change_avatar_fields.
2020-07-06 17:24:18 -07:00
2279fef316
audit_log: Log acting_user in do_change_logo_source.
2020-07-06 17:24:18 -07:00
2fb96e94f1
registration: Fix strict_optional errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-06 11:25:48 -07:00
50cbe1b19b
minor: Rename var to max_message_id.
...
We are phasing out the concept of pointer.
2020-07-03 13:08:40 +00:00
cbd73a6dc1
home: Use get_customer_by_realm for getting customer.
2020-07-01 16:45:38 -07:00
4c6350fa4b
billing: Add option to request a sponsorship in /upgrade.
2020-07-01 16:45:38 -07:00
a74cdf3123
18n: Cleanup strings to be translated in add_subscriptions_backend.
...
Also expand the test to check the details of the user who created the
stream.
2020-07-01 11:03:29 -07:00
eb50ecf07a
18n: Cleanup strings to be translated in you_were_just_subscribed_message.
2020-07-01 11:03:29 -07:00
f2e7076e2a
decorator: Replace type: ignore with cast, avoid Any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-30 18:58:23 -07:00
dcbc8e66fb
decorator: Remove authenticated_json_post_view.
...
It’s effectively a combination of require_post with
authenticated_json_view and has one use.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-30 18:58:23 -07:00
d6ecb67d75
report: Split hostname from port more carefully.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-29 22:19:47 -07:00
bbec1f72a8
refactor: Rename bugdown to markdown in message_edit.py.
...
This commit is part of series of commits aimed at renaming bugdown to
markdown.
2020-06-29 15:03:20 -07:00
9392e8bec7
emails: Add a custom header specifying the organization when possible.
...
Closes #15135 .
2020-06-28 13:33:02 -07:00
69be97e365
pointer: Remove pointer from API and page_params.
...
There is still some miscellaneous cleanup that
has to happen for things like analytics queries
and dead code in node tests, but this should
remove the main use of pointers in the backend.
(We will also still need to drop the DB field.)
2020-06-27 16:44:38 -07:00
3f5fc13491
refactor: Rename zerver.lib.bugdown to zerver.lib.markdown .
...
This commit is first of few commita which aim to change all the
bugdown references to markdown. This commits rename the files,
file path mentions and change the imports.
Variables and other references to bugdown will be renamed in susequent
commits.
2020-06-26 17:08:37 -07:00
Anders Kaseorg
Alex Vandiver
Mateusz Mandera
Clara Dantas
Hemanth V. Alluri
Dinesh
Gittenburg
majordwarf
arpit551
Vishnu KS
Steve Howell
Tim Abbott
Mohit Gupta