64acf84ab1
reload: Save narrow when event queues expire.
...
Along with the issues with our reload data passing system that are
fixed in the next commit, this is responsible for #3411 .
2017-03-22 22:28:35 -07:00
ee4b948873
bankruptcy: Fix narrow being lost on declaring bankruptcy.
...
This was actually being done in 2 ways: via not saving the narrow in
the reload and second through calling `change_tab_to('#home')`. The
code is so ancient that it seems unlikely that this behavior was still
intentional.
Fixes part of #3687 (the remainder is fixed in a few commits).
2017-03-22 22:28:18 -07:00
37ac0e6e6d
server_events: Remove obsolete 'tool old' handler.
...
This error predates the transition to an event queue system and hasn't
been possible for years.
2017-03-22 21:16:39 -07:00
61e6ed8c31
bankruptcy: Fix clicking outside bankruptcy modal.
...
Previously, this would leave the unread UI disabled forever, showing 0
unread counts for anything, which was a super confusing failure mode.
2017-03-22 20:50:44 -07:00
977e7b0fdc
unread: Move bankruptcy code out of click_handlers.js.
2017-03-22 20:49:05 -07:00
1f89058023
Fix broken size for message actions popover.
...
This fixes a regression introduced in
23a5f56023
2017-03-22 16:44:23 -07:00
ccb38a1e9c
compose: Fix missing opts argument to show_box.
...
This fixes a regression in the recent compose.get_focus_area
refactoring that I did.
2017-03-22 16:32:53 -07:00
97bd9d5186
Fix positioning of message-info-popover.
2017-03-22 16:04:38 -07:00
ed72ee476f
Make user_popover use user_info_popover template.
2017-03-22 16:04:38 -07:00
b2fc8d6fa2
Rename message_info_popover* templates to user_info_popover*.
2017-03-22 16:04:38 -07:00
23a5f56023
Add sender avatar in message popover.
2017-03-22 16:04:38 -07:00
3ac8f52a73
Remove title of message info popup.
2017-03-22 16:04:38 -07:00
32bc5893d0
Remove arrow from message info popover by providing template.
...
Provide custom template (user_info_popover.handlebars) to message info popover.
2017-03-22 16:04:38 -07:00
2a5269baa9
docs: Document the frontend hashchange system.
2017-03-22 15:21:36 -07:00
d6716838ad
bugdown: Remove trailing whitespace on fence code blocks.
...
This fixes fenced code blocks that are copy-pasted from certain
clients having trailing whitespace anoyingly often.
Fixes #3998 .
2017-03-22 14:17:34 -07:00
5ed482cf2c
compose: Apply consistent styling for compose buttons.
...
This applies the consistent :hover effect for all compose buttons.
Fixes : #4239 .
2017-03-22 13:15:44 -07:00
3d3f9bc58e
devlogin: Link to the normal login page.
2017-03-22 13:03:45 -07:00
dbcd19bcfa
streams: Add hotkey for content-editable enter.
...
When you enter, it should click the checkmark, which would save the
current input of the input section.
2017-03-22 12:21:21 -07:00
d21fe68e9e
streams: Fix content-editable cursor shifting to beginning.
2017-03-22 12:21:08 -07:00
956106ae92
streams: Fix closing of content-editable area on escape key press.
...
Pressing Escape key while editing stream description now closes
the editing.
Fixes #4202 .
2017-03-22 12:19:59 -07:00
9a339a7053
streams: Prevent cursor jump to the end of editing stream-descr.
...
This prevents the cursor to jump at the end of the content-editable
area when the user types in the middle.
Fixes #4202 .
2017-03-22 12:19:59 -07:00
9707c74f33
message_edit: Added copy to clipboard button.
...
A copy-to-clipboard button is added over message-edit textarea.
Closes #3239 .
2017-03-22 11:00:18 -07:00
2991c19fea
Extract typing indicator inbound timing logic.
...
We now track our inbound timing events using code in
typing_data.js.
This code may be a little more robust with variations on how
recipients are represented in events, although there are no known
bugs here.
2017-03-22 08:20:21 -07:00
4fb8339954
Extract typing_events.js.
2017-03-22 07:29:42 -07:00
cde1861655
typing indicators: Validate PM emails.
2017-03-22 07:01:20 -07:00
1ec392a18e
Extract compose.get_invalid_recipient_emails().
2017-03-22 07:01:20 -07:00
84b31a5532
typing indicators: Limit to PM conversations.
...
We now only send outbound typing indicators if we are
composing a private message.
2017-03-22 07:01:20 -07:00
642be6ad18
Revamp state tracking for outbound typing indicators.
...
This change moves most of the logic related to starting and
stopping outbound typing indicators to a new module called
typing_status.js that is heavily unit tested.
While this was in some sense a rewrite, the logic was mostly
inspired by the existing code.
This change does fix one known bug, which is that when we
were changing recipients before (while typing was active), we
were not stopping and starting typing indicators. This was
a fairly minor bug, since usually users leave the compose
box to change recipients, and we would do stop/start under
that scenario. Now we also handle the case where the user
does not leave the compose box to change recipients.
2017-03-22 07:01:20 -07:00
f89c9d6629
Avoid deprecated report_success() call.
...
We are moving to ui_report to break dependencies.
2017-03-22 06:53:21 -07:00
2076338eaa
mark_subscribed: Add a blueslip check for color code path.
...
This code path might be unused, and it seems worth verifying, since if
it is, we can delete some extra complexity.
2017-03-21 23:36:47 -07:00
01904385a4
Fix thrashing color when resubscribing to a stream.
...
Previously, we would let the backend pick a color and send it to the
frontend; then the frontend would ignore that color and pick a
different color and send it to the backend, which would in turn resync
to us.
Fixes #3572 .
Fixes #3858 .
2017-03-21 23:35:50 -07:00
832aa398b0
subscription_settings: Move email address into toggled area.
2017-03-21 23:09:32 -07:00
1ad0d35966
subs: Clean up ancient collapsing logic.
2017-03-21 23:09:32 -07:00
bfc67f6602
subs: Toggle notification settings on subscribe.
2017-03-21 23:09:32 -07:00
dfddea77b7
subscriptions: Show stream settings after toggling checkbox.
...
Based on Aakash Tiyagi's work in #4026 .
Fixes #3971 .
2017-03-21 23:09:32 -07:00
9347fc4742
subs: Move show_stream_row earlier in file.
2017-03-21 23:09:29 -07:00
a7610c8b7e
subs: Clarify show_stream_row arguments.
2017-03-21 23:07:28 -07:00
e70bf13bef
subs: Extract setup_subscriptions_stream_hash.
2017-03-21 22:17:50 -07:00
c13809c83f
invite: Display and check default streams in invite modal.
...
This fixes two bugs:
* If a user is not subscribed to a default stream, he or she would not
be have the option to invite users to that default stream.
* The initial streams checked in the invite modal were the
non-invite-only streams the user was subscribed to, not their
default streams.
Fixes : #4209 .
2017-03-21 20:56:34 -07:00
a765b6e781
settings: Fix user edit form not being shown.
...
Added an if condition to checks whether person is a bot before fetching
information about bot owner in *static/js/admin.js*.
2017-03-21 20:52:11 -07:00
1dfac12c4b
hotkeys: Add arrow key navigation in streams/subscriptions menu.
...
Fixes #4198 .
2017-03-21 20:32:28 -07:00
b8f71c5d24
Document how to set up an Asana integration via Zapier.
...
Fixes #3948 .
2017-03-21 19:56:47 -07:00
bd04ea02d3
Use new JS data layer for typing notifications.
...
The old code may have had some subtle bugs related to sorting of
ids or stringification or failed Dict lookups. The new data
layer should be more robust. We had some tracebacks recently
from the old code, and they should go away now.
2017-03-21 17:24:40 -07:00
67a2094ed1
Add typing_data.js, which can track users who are typing.
...
(A subsequent commit will actually integrate this into the app.)
2017-03-21 17:24:40 -07:00
8b9e78e486
compose: Extract and test get_focus_area.
2017-03-21 17:24:40 -07:00
82ec083066
compose: Fix new topic button behavior in home view.
2017-03-21 17:24:40 -07:00
34a9e1ae11
markdown: Add TeX typesetting support.
...
Co-authored-by: Reid Barton <rwbarton@gmail.com>
Fixes #2056 .
2017-03-21 16:40:00 -07:00
bddcfb1c96
Add realm-level settings to control inline image and url preview.
...
This gives users more control in case they don't want previews,
especially for the "previews of linked websites" feature.
Fixes : #2640 .
2017-03-21 15:46:17 -07:00
a27f8f2f30
Fix up YouTube embed issues and styling.
...
This fixes the styling to stay on the screen of most reasonably sized
monitors along with extending the JavaScript code to allow for the
video to be keyed to in the lightbox.
2017-03-21 14:28:13 -07:00
1b31f9be38
Move lightbox events to lightbox.js from clickhandlers.js.
...
This consolidates lightbox logic to lightbox.js.
2017-03-21 14:28:13 -07:00
Tim Abbott
hackerkid
hollywoodno
Brock Whittaker
Raghav Jajodia
Steve Howell
James Wang
digi0ps
Cynthia Lin
Eeshan Garg
Yago González
Ayush Jain