09e40b27c2
github_webhook: throw an exception on unhandled events types.
2016-04-21 17:03:58 -07:00
fafc9cb742
github_webhook: remove redundant parenthesis.
2016-04-21 17:02:49 -07:00
43b0cfaebc
github_webhook: Use more one-line pythonic assignments.
2016-04-21 17:00:47 -07:00
decb686255
github_webhook: factor out is_test_repository function.
2016-04-21 16:57:19 -07:00
e1079d8475
github_webhook: extract the constants to the top of the file.
2016-04-21 16:56:44 -07:00
84e23dd015
Document code copied from Django and then modified.
2016-04-21 14:59:39 -07:00
ae047f8551
Fix slightly ugly login page URL of /login?next=/.
2016-04-21 14:59:39 -07:00
8a278cbe3a
Switch to using a Zulip version of @login_required.
...
Currently the code is the unmodified Django upstream implementation;
this commit is preparation for modifying it.
2016-04-21 14:59:39 -07:00
d9dba5d2c2
deactivate_realm: Improve error handling for unknown realm.
2016-04-21 09:02:00 -07:00
c2237c60c0
deactivate_realm: Fix help string.
2016-04-21 09:02:00 -07:00
d890011442
Add a script to reactivated deactivated realms.
2016-04-21 09:02:00 -07:00
79297898f1
Remove obsolete AppleDeviceToken model.
2016-04-20 21:51:52 -07:00
49799440a4
Replace use of django-guardian with fields on UserProfile.
...
As documented in https://github.com/zulip/zulip/issues/441 , Guardian
has quite poor performance, and in fact almost 50% of the time spent
running the Zulip backend test suite on my laptop was inside Guardian.
As part of this migration, we also clean up the old API_SUPER_USERS
variable used to mark EMAIL_GATEWAY_BOT as an API super user; now that
permission is managed entirely via the database.
When rebasing past this commit, developers will need to do a
`manage.py migrate` in order to apply the migration changes before the
server will run again.
We can't yet remove Guardian from INSTALLED_APPS, requirements.txt,
etc. in this release, because otherwise the reverse migration won't
work.
Fixes #441 .
2016-04-20 21:51:52 -07:00
ee39f5009f
Make message_list.js work like the other modules.
2016-04-20 15:29:30 -07:00
28d1a3105c
models: Add a __repr__ for Client.
2016-04-20 15:26:51 -07:00
552caf661a
Caching: Fix 'update_fields' not being present in .delete()
2016-04-20 15:12:53 -07:00
9c56027627
lint: Add CSS lint rule for whitespace after {.
2016-04-20 11:50:01 -07:00
a46b5d7bbe
Add lint check for missing whitespace after =.
2016-04-20 11:37:03 -07:00
a72385246e
Fix missing whitespace after '=' in python/js code.
2016-04-20 11:36:14 -07:00
ece96ef3fe
Jira's "issue created" message should @-notify the assignee.
2016-04-20 10:54:30 -07:00
82f1cdb085
Add send_webhook_fixture_message command.
...
This tool simplifies the process of producing nice screenshots for
documenting webhook integrations.
Fixes #658 .
2016-04-20 10:45:27 -07:00
c7a93cba22
Add tests for checking image validity in SetAvatarTest.
2016-04-20 12:27:23 +05:30
af7c3de5f5
Add SetAvatarTest to test_upload.py.
...
Test multiple file uploads for /json/set_avatar.
Test no file upload for /json/set_avatar.
Add test images for SetAvatarTest.
2016-04-20 12:23:22 +05:30
126273b1e7
Add a test for local file uploads.
2016-04-20 12:00:13 +05:30
4e18d856e3
Prevent 500 error when user uploads invalid avatar.
...
When uploaded avatar image is not a valid image file, PIL raises
IOError. Catch the IOError raised by PIL and raise JsonableError.
This will return a response with status code 400.
2016-04-20 12:00:13 +05:30
2d60a1d0f3
Move upload-related tests to test_upload.py.
...
Move S3Test, FileUploadTest and SanitizeNameTests from
test_external.py to test_upload.py.
2016-04-19 16:48:30 -07:00
c75c5fb3e1
Use a different uploads directory when running tests.
2016-04-19 16:48:30 -07:00
1b988de30a
Integration guide: clean up description of plugin integrations.
2016-04-19 16:21:33 -07:00
92f9a789b8
integration guide: Improve introduction.
2016-04-19 16:21:33 -07:00
0669262ccb
/integrations: Document how to contribute integrations.
2016-04-19 16:21:33 -07:00
3179434f93
Move keep_pointer_in_view to pointer.js.
2016-04-19 15:23:45 -07:00
b655e090a6
check_all: Move viewport to modules list.
...
It was previously incorrectly listed as a global variable.
2016-04-19 15:23:24 -07:00
a2b59b8b51
lint: Check whitespace rules for txt files.
2016-04-14 14:36:29 -07:00
78febc3abb
Fix missing newlines at end of .txt files.
2016-04-14 14:36:29 -07:00
39950b8f4f
lint: Check whitespace rules in markdown files too.
2016-04-14 14:30:29 -07:00
1a162ecb97
Fix tab-based whitespace in stress-test README file.
2016-04-14 14:30:29 -07:00
2b76f6223e
Make 'no newline at end of file' lint error more actionable.
...
There's a handy sed command to fix this, so we might as well document
it.
2016-04-14 10:55:06 -07:00
e71d8bb4b6
lint-all: Require newlines at end of JSON files.
2016-04-14 10:49:12 -07:00
5195d1ecb7
Fix missing newlines at ends of JSON files.
2016-04-14 10:48:52 -07:00
1bf11f6b7f
Split FileUploadTest out of S3Test.
...
S3Test is now only the S3-specific test (which isn't even run), so we
can now invest in making FileUploadTest have good coverage of the
(local) file upload code paths.
2016-04-14 10:35:10 -07:00
4ce4f88a03
Fix formatting in directory-structure.rst.
2016-04-13 15:44:10 -07:00
74abd47684
Fix EMAIL_GATEWAY_BOT not being set by default in production.
...
Previously the DEFAULTS value of None for EMAIL_GATEWAY_BOT was
overriding the initialization code.
2016-04-13 13:19:02 -07:00
ae48f6394b
migrations: Disable prompting about content-type deletion.
...
The main function of prompting inside `manage.py migrate` is to ask
the user if they want to delete stale content-types, which is
unimportant and likely scary, so we disable doing so.
2016-04-13 13:19:02 -07:00
d0f2c46f25
generate_test_credentials: Use the email variable properly.
...
This makes it a bit easier to change the email in the test
credentials.
2016-04-13 13:19:02 -07:00
26463bb34d
Fix nondeterministic subscriptions for default test users.
...
Previously, the UserProfile objects were created in the order
generated by a Set, which meant tests would randomly start failing if
the code that runs before this part of populate_db changed (and thus
caused the Set object used to pass users into bulk_create_users to
have a different order when enumerated).
This fixes the issue in two ways -- one by sorting the users inside
bulk_create_users, and second by attaching subscriptions to users
based on a deterministic ordering.
2016-04-13 13:19:02 -07:00
81143a8c98
02-narrow: Use Denmark as the test second stream.
...
It's less easily confused with "Verona", and prevents the next commit
from breaking the tests (since Iago will lose his subscription to
"Venice").
2016-04-13 13:19:02 -07:00
f6edc21981
Change stream used in test_get_old_messages_with_only_searching_anchor.
...
This prevents this test from breaking when in a few commits we fix a
nondeterminism issue in the populate_db test fixtures.
2016-04-13 13:19:02 -07:00
ffccb572f0
Don't autoreload Tornado when running inside test suite.
...
The restarted Tornado processes seemed to escape the process group and
thus continue running after run-dev.py finished.
While we're at it, we don't need to dump/reload event queues in the
test suite either.
2016-04-13 13:19:01 -07:00
98d5f64f36
webpack: Use the correct port in Casper tests.
...
Previously we used 9994 unconditionally, whereas we should be using
9984 or 9994 depending whether it's being run manually or via the
Casper tests.
2016-04-13 13:18:38 -07:00
47879c5e00
Fix nondeterminism in test_successful_subscriptions_add.
...
Previously this test would fail if the streams list generated by
populate_db contained more than 2 streams.
2016-04-13 13:18:24 -07:00
Tomasz Kolek
Tim Abbott
Vishnu Ks
David Payne
Eklavya Sharma
Sumana Harihareswara