zulip

Commit Graph

Author	SHA1	Message	Date
sahil839	eaf69bbf16	edit_fields_modal: Show error message in the body not heading. Placing error message at the top of the body looks better than placing it below the heading.	2021-07-06 15:15:50 -07:00
sahil839	19362f393e	edit_fields_modal: Rename modal_body_html and modal_label. This commit renames modal_body_html and modal_label to html_body and html_heading respectively. This change will help us easily deduplicating the confirm_dialog and edit_fields_modal code.	2021-07-06 15:15:50 -07:00
sahil839	36560da0f0	modals: Add edit_fields_modal.js and edit_field_modals.hbs. We create a new widget edit_fields_modal such that this common framework can be used in bot-edit modal, linkifier-edit modal and user-edit modal, which have very similar implementations. The "edit-fields-modal-status" is used only for edit-linkifier modal and remains empty for others, so this change does not cause problems with other modals.	2021-06-24 16:55:22 -07:00

Author

SHA1

Message

Date

sahil839

eaf69bbf16

edit_fields_modal: Show error message in the body not heading.

Placing error message at the top of the body looks better than
placing it below the heading.

2021-07-06 15:15:50 -07:00

sahil839

19362f393e

edit_fields_modal: Rename modal_body_html and modal_label.

This commit renames modal_body_html and modal_label to
html_body and html_heading respectively. This change
will help us easily deduplicating the confirm_dialog
and edit_fields_modal code.

2021-07-06 15:15:50 -07:00

sahil839

36560da0f0

modals: Add edit_fields_modal.js and edit_field_modals.hbs.

We create a new widget edit_fields_modal such that this common
framework can be used in bot-edit modal, linkifier-edit modal
and user-edit modal, which have very similar implementations.

The "edit-fields-modal-status" is used only for edit-linkifier
modal and remains empty for others, so this change does not
cause problems with other modals.

2021-06-24 16:55:22 -07:00

3 Commits