Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
30,131 Commits 28 Branches 143 Tags 605 MiB
Commit Graph

22 Commits

Author SHA1 Message Date
Tim Abbott a64c434b9e topics: Fix messages_for_topic to use iexact matching. 
This fixes the archive codebase to use our covention of using
case-insensitive matching for message topics.
 2019-01-24 17:55:15 -08:00
Steve Howell eb4d279bbc Extract get_turtle_message(). 
This seems like kind of a silly function to extract
to topic.py, but it will theoretically help us sweep
"subject" if we change the DB.

It had test coverage.
 2018-11-14 23:24:06 -08:00
Steve Howell 27d79352da topic -> subject: Extract get_topic_from_message_info(). 
This changes files where it's safe to just assume caller
may use either "topic" or "subject", and we prefer "topic"
but support "subject".
 2018-11-14 23:24:06 -08:00
Steve Howell aa4e9cec2d minor: Add a code comment and move two constants. 2018-11-14 23:24:06 -08:00
Steve Howell d86dd165da gitter/slack/hipchat: Remove "subject" from conversions. 
We (lexically) remove "subject" from the conversion code.  The
`build_message` helper calls `set_topic_name` under the hood,
so things still have "subject" in the JSON.

There was good code coverage on `build_message`.
 2018-11-12 15:47:11 -08:00
Steve Howell e55fc144b9 Add alias support to REQ helpers for subject/topic. 
The alias support is generic here, and we use it for
migrating subject -> topic in REQ_topic().
 2018-11-12 15:47:11 -08:00
Steve Howell de6c08a842 Extract messages_for_topic(). 2018-11-12 15:47:11 -08:00
Steve Howell 754795c0b7 Extract REQ_topic() helper. 
For now we use it only in the send path, not the update
path.
 2018-11-12 15:47:11 -08:00
Steve Howell 0a171bf9bf Fix "prev_subject" with LEGACY_PREV_TOPIC. 
I added `LEGACY_` prefix to the var, because
otherwise you'd have really confusing code
where you change the key from `PREV_TOPIC`
to "prev_topic".
 2018-11-12 15:47:11 -08:00
Steve Howell a49ba8c577 Extract user_message_exists_for_topic(). 2018-11-12 15:47:11 -08:00
Steve Howell 39e5c61d4a Extact MATCH_TOPIC constant. 2018-11-12 15:47:11 -08:00
Steve Howell 8981b65bbc Extract topic_column_sa(). 2018-11-12 15:47:11 -08:00
Steve Howell 226a2826b5 Remove "subject" from zerver/lib/message.py. 
We also lock this down file in the linter, so
that you can no longer introduce "subject"
to `message.py`.
 2018-11-08 14:45:16 +00:00
Steve Howell 592dd290b2 Avoid "subject" in MessageDict. 2018-11-08 14:33:44 +00:00
Steve Howell ff60055fa4 Use topic_match_sa() for topic searches. 
Note this introduce literal(), which makes the way
we handle topic mutes more consistent with general
topic searches.
 2018-11-07 10:03:53 -08:00
Steve Howell 79d5e36ca3 Extract topic_match_sa() helper. 
We'll also use this in zerver/views/messages.py, but
that's a bigger change.
 2018-11-07 10:03:53 -08:00
Steve Howell 2cf46f0122 Extract save_message_for_edit_use_case(). 
This is mostly extracted to help clean out
all "subject" references from actions.py.
 2018-11-07 10:03:53 -08:00
Steve Howell 0cf4cddc5b Extract update_messages_for_topic_edit(). 
This is somewhat hairy logic, so it's nice
to extract it and not worry about variable leaks.

Also, this moves some legacy "subject" references out
of actions.py.
 2018-11-07 10:03:53 -08:00
Steve Howell 0e854288ee Add some string constants to topic.py. 
The goal here is to make it easy to
forbid "subject" in actions.py.
 2018-11-07 10:03:53 -08:00
Steve Howell 7252861785 Extract filter_by_topic_name_via_message. 2018-11-07 10:03:53 -08:00
Steve Howell dc8f893494 Extract filter_by_exact_message_topic(). 2018-11-07 10:03:53 -08:00
Steve Howell 50e3f85557 Extract topic.py library. 
We start by including functions that do custom
queries for topic history.

The goal of this library is partly to quarantine
the legacy "subject" column on Message.
 2018-11-07 10:03:53 -08:00