Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
40,999 Commits 28 Branches 143 Tags 606 MiB
Commit Graph

10 Commits

Author SHA1 Message Date
Anders Kaseorg bc55aa6a01 Revert "starred_messages: Add support to unstar all messages in a topic." 
This reverts commit 6fba17599f (#16898).

@chrisbobbe reported this crash:

Uncaught TypeError: Cannot read property 'stream_id' of undefined
    at starred_messages.js:43
    at Array.filter (<anonymous>)
    at Object.e.get_topic_starred_msg_ids (starred_messages.js:40)
    at stream_popover.js:221
    at HTMLSpanElement.<anonymous> (stream_popover.js:358)
    at HTMLUListElement.dispatch (jquery.js:5429)
    at HTMLUListElement.v.handle (jquery.js:5233)

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-26 16:41:04 -05:00
Abhishek-Balaji 6fba17599f starred_messages: Add support to unstar all messages in a topic. 
Adds a "unstar messages in topic foo" option to the topic sidebar
popover, if there are any starred messages in that topic, known
to the frontend.

Altered existing "unstar all messages" confirmation modal to mention
the topic name, in the case that it was opened by the topic sidebar
codepath.

This is just a v1, and will not unstar old messages from that
topic, if they have not been fetched by the frontend.

Fixes #12194

Co-authored-by: Abhijeet Bodas <abhijeetbodas2001@gmail.com>
 2021-02-15 07:38:37 -05:00
sahil839 ab90abfa4c stream_data: Rename sub.is_admin to sub.is_realm_admin. 
This commit renames sub.is_admin to sub.is_realm_admin such that
we can clearly differentiate between realm and stream admins.
 2020-09-14 22:05:31 -07:00
Mohit Gupta 5cef548708 popovers: Add keyboard support for topic popovers in left sidebar. 
This commit adds arrow, vim_up/vim_down and enter hotkey support for
navigating the popover menu.
 2020-08-31 22:55:28 -07:00
SiddharthVarshney b122ad7da4 topic-popover: Add chevron-right icon in topic popover title. 2020-06-20 14:57:54 -07:00
Tim Abbott 6f159ce5c5 templates: Clean up wording around topic moves. 
This switches us to cleaner, simpler labels for moving topics; while
also avoiding claiming that we're only allowing moving topics to other
streams.
 2020-06-10 12:12:17 -07:00
Siddharth Varshney 309ab0eb6f topic-popover: Change design of topic popover. 
Extracts the topic name from the list items and display
it in the popover title.

Add a seperator between normal user and admin only options.
 2020-05-24 17:28:50 -07:00
Tim Abbott b9098a42d4 messages: Allow moving a topic to another stream. 
This completes the implementation of support for moving a topic to
another stream by adding a basic UI for it.

Fixes #6427, which was previously the most-upvoted issue request in
Zulip.

There are likely to be a bunch of follow-up UI improvements on top of
this change to fully flesh out the feature.
 2020-05-04 10:03:03 -07:00
Siddharth Varshney 962684f189 ui: replace all mute icons from eye/eye-slash with bell/bell-slash. 
eye/eye-slash icon is generally used for toggling hiding actions and we are using that same icon for mute action which can be a bit confusing
 2020-03-22 12:31:48 -07:00
Anders Kaseorg 3c3471b720 templates: Rename *.handlebars ↦ *.hbs and - ↦ _. 
Tweaked by tabbott to avoid accidentally disabling the linter for
handlebars templates.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-07-12 21:11:03 -07:00