Aditya Bansal
74f40a0a58
compose.js: Add node test coverage for report_as_received() function.
2017-06-30 19:57:15 +05:30
Aditya Bansal
4b3c2931ea
compose.js: Add test coverage for mark_rendered_content_disparity().
2017-06-30 19:57:15 +05:30
Aditya Bansal
7e585acfa5
compose.js: Add coverage for send_message_success() function.
2017-06-30 19:57:15 +05:30
Aditya Bansal
7f4781e17d
compose.js: Add test coverage for update_email().
2017-06-30 19:57:15 +05:30
Aditya Bansal
3d043d0109
compose.js: Add coverage for get_invalid_recipient_emails().
2017-06-30 19:57:15 +05:30
Aditya Bansal
9437895c9e
compose.js: Add coverage for validate_stream_message() function.
2017-06-30 19:57:15 +05:30
Aditya Bansal
28ec32d757
compose.js: Use get_subscriber_count in show_all_everyone_warning().
2017-06-30 19:57:14 +05:30
Umair Khan
f60d4849b7
Revert "lint: Don't allow handlerbars within translatable text."
...
This reverts commit 3c7b9cdc94
.
2017-06-30 10:12:31 -04:00
Umair Khan
74d83cc47e
lint: Disallow handlebars within {{#tr}}{{/tr}}.
...
This commit adds a new linter which runs from tools/travis/backend.
It runs over the translations.json file and checks if any of the
translatable string contains handlebars in it.
Fixes #5544
2017-06-30 10:12:31 -04:00
Umair Khan
4f33a650af
i18n: Use double lowdash instead of handlebars.
...
We do not allow handlebars within {{#tr}}{{/tr}}.
2017-06-30 10:12:31 -04:00
Steve Howell
6cf4c65d92
node tests: Add 100% coverage for channel.js.
2017-06-30 09:48:04 -04:00
Steve Howell
ef815e9e79
Remove unused channel.abort_all().
2017-06-30 09:48:04 -04:00
Steve Howell
0b60538570
node tests: Extract test_get_reaction_section().
2017-06-30 08:05:10 -04:00
Rishi Gupta
2012913cc1
prod_settings_template: Update description of NOREPLY_EMAIL_ADDRESS.
2017-06-29 17:54:33 -07:00
Rishi Gupta
85d38bd17b
emails: Remove DEFAULT_FROM_EMAIL from prod_settings_template.
2017-06-29 17:54:33 -07:00
Rishi Gupta
577e201df0
emails: Replace DEFAULT_FROM_EMAIL with ZULIP_ADMINISTRATOR.
...
We're getting rid of DEFAULT_FROM_EMAIL from prod_settings_template, since
we only really need one of {DEFAULT_FROM_EMAIL, ZULIP_ADMINISTRATOR}.
2017-06-29 17:54:33 -07:00
Rishi Gupta
36cd122905
models: Change default org_type to CORPORATE.
...
Once we implement org_type-specific features, it'll be easy to change a
corporate realm to a community realm, but hard to go the other way. The main
difference (the main thing that makes migrating from a community realm to a
corporate realm hard) is that you'd have to make everyone sign another terms
of service.
2017-06-29 15:14:58 -07:00
Cory Lynch
4327402d57
docs: Add tip to record GIFs with Chrome Capture.
2017-06-29 13:26:38 -07:00
Harshit Bansal
fc6eedb831
bugdown: Make `unicode_emoji_regex` global.
2017-06-29 13:26:07 -07:00
Aditya Bansal
1e18863a98
timerender.js: Use stubbed version of i18n from zjsunit.
2017-06-29 15:18:08 -04:00
Aditya Bansal
5eb5b33f21
settings_org.js: Use stubbed version of i18n from zjsunit.
2017-06-29 15:18:08 -04:00
Aditya Bansal
a103949c2b
i18n.js: Fix issue of i18n stub not returning 'translated: ' prefix.
2017-06-29 15:18:08 -04:00
Aditya Bansal
4d84be16ca
i18n.js: Fix issue with i18n being cleaned up in namespace cleanup.
2017-06-29 15:18:08 -04:00
Rishi Gupta
81220e050b
context_processors: Remove zulip_admin from zulip_default_context.
...
There is no real distinction between zulip_admin and support_email in the
codebase, so fold them into a single variable.
2017-06-29 11:20:32 -07:00
Rishi Gupta
bf996f91ba
deactivated.html: Use support_email instead of custom context variable.
2017-06-29 11:20:32 -07:00
Rishi Gupta
78790ce825
send_password_reset_email: Remove spurious send_mail import.
...
Make grepping for and otherwise understanding our email pathways slightly
easier.
2017-06-29 10:51:12 -07:00
Aditya Bansal
2be5046144
compose.js: Use stream_data.get_subscriber_count in message mentions.
...
In this commit we basically start using the get_subscriber_count
function from stream data to get subscriber count.
2017-06-29 10:34:47 -04:00
Aditya Bansal
7531a85c4d
stream_data: Add get_subscriber_count() function.
2017-06-29 10:34:47 -04:00
Aditya Bansal
cc34e3d382
compose.js: Add coverage for validate_stream_message_address_info().
2017-06-29 18:02:25 +05:30
Aditya Bansal
7a0387e0b1
compose.js: Add return true for subscribed streams.
...
This is basically going to fix a regression which was introduced in
89090cd
which made code early return in case of subscribed streams.
2017-06-29 18:02:25 +05:30
Umair Khan
12b124ba71
single_message.handlerbars: Use __starred_status__ in tooltip.
...
We do not allow handlerbars within tranlation tags. To use variables in
translatable strings, enclose variables with double lowdashes.
2017-06-29 07:39:20 -04:00
Umair Khan
d44c62e894
update_starred: Make the status translatable.
2017-06-29 07:39:20 -04:00
Umair Khan
8921496ccc
message_list_view: Add starred_status to message objs.
...
This starred_status property can be used to provide the context in
the single_message.handlebars template to show the proper tooltip.
2017-06-29 07:39:20 -04:00
Umair Khan
3c7b9cdc94
lint: Don't allow handlerbars within translatable text.
...
Fixes : #5544
2017-06-29 07:39:20 -04:00
Steve Howell
aae3250155
node tests: Add test_with_view_stubs() for reactions.js.
2017-06-29 07:19:52 -04:00
Steve Howell
9b75daaa60
Extract reactions.view.remove_reaction().
2017-06-29 07:19:52 -04:00
Steve Howell
e2ae4aeb16
Extract reactions.view.update_existing_reaction().
2017-06-29 07:19:52 -04:00
Steve Howell
8cf6ef95b1
Extract reactions.view.insert_new_reaction().
2017-06-29 07:19:52 -04:00
Steve Howell
791e489938
Use a proper context in insert_new_reaction().
...
Before this change, we were piggybacking fields on to the event
object, which coupled us to any other function that relies on
the event.
2017-06-29 07:19:52 -04:00
Greg Price
e1ce3daaff
scripts/upgrade-zulip-from-git: Don't cache the repo URL, only the contents
...
We document the `deployment.git_repo_url` setting in `/etc/zulip/zulip.conf`
to control where this script fetches from, and don't say that it's
only read on the first such upgrade and cached thereafter. The documented
behavior seems like the right behavior. So use the currently configured
URL every time, by writing it anew into the config of our cache repo.
2017-06-28 15:49:57 -07:00
Rohitt Vashishtha
8851f1c5dd
bots: Add dependencies management.
...
Adds the file api/bots_api/provision.py that installs dependencies
for bots using pip. This file is also used by run.py when running
a bot. However, for testing, you need to separately provision the bots.
2017-06-28 12:00:13 -04:00
vaibhav
7f9b4d3a94
Outgoing Webhook System: Add usage of Interfaces in DoRestCall.
2017-06-28 11:11:21 -04:00
vaibhav
a60552930e
Outgoing Webhook System: Add base interface class and Generic class.
2017-06-28 11:11:21 -04:00
Aditya Bansal
84b52661bb
compose.js: Remove small piece of dead code.
...
In this commit we remove a small piece of dead code from
check_stream_for_send() function and also rename it to
check_unsubscribed_stream_for_send() which makes more sense.
2017-06-28 07:45:21 -04:00
Aditya Bansal
89090cd3af
compose.js: Refactor validate_stream_message_address_info().
...
In this commit we just refactor validate_stream_message_address_info
function to early return in case of stream_data.is_subscribed()
returns true.
2017-06-28 07:45:21 -04:00
Aditya Bansal
92b43c7965
compose.js: Add test for validate_stream_message_address_info().
...
In this commit we add only one test for the case of unsubscribed
streams in validate_stream_message_address_info() function."
2017-06-28 07:45:21 -04:00
Aditya Bansal
6c787ac569
compose.js: Add test for validate_stream_message_address_info().
...
In this commit we only add a single test for the case of subscribed
stream to validate_stream_message_address_info() function.
2017-06-28 07:45:21 -04:00
Aditya Bansal
eec9a9babb
compose.js: Export validate_stream_message_address_info().
2017-06-28 07:45:21 -04:00
Aditya Bansal
63401833b4
compose.js: Add node test coverage for validate function.
2017-06-28 07:45:21 -04:00
Aditya Bansal
232966a948
activity.js: Remove unnecessary override of i18n as global var.
2017-06-28 07:34:04 -04:00