60e5071843
subscriptions: Confirm inviting 100+ users to a new stream.
...
Our current workflow for creating a new stream allows the user to
invite as many other users as they like but since there can be
mistakes in doing so, we now open a modal with a warning if the
number of invites are more than 100 just to confirm that user indeed
wanted to do this.
Fixes : #1663 .
2017-07-07 19:08:04 -07:00
d5517bae36
Delete the old zulip.com "referrals" system.
...
This system hasn't been in active use for several years, and had some
problems with it's design. So it makes sense to just remove it to declutter
the codebase.
Fixes #5655 .
2017-07-07 14:59:18 -07:00
fcd944447e
common.js: Don't set default password quality/length in frontend.
...
The min quality/length values are always available via data
attributes. So there is no point of specefying a default value
in common.js.
2017-07-07 14:48:06 -07:00
f273e83a85
portico: Explain why password is weak to user.
2017-07-07 14:48:06 -07:00
75617d07de
search_suggestions: Prioritize recent huddles.
...
Fixes #5612 . What this specifically does is that if you are
typing a group PM, this logic iterates through the possible
search suggestions for the next autocomplete. If that suggestion
contains a group PM that already exists, then prioritize it with
the most recent one on top.
2017-07-07 12:12:30 -07:00
7efba29b0c
search_suggestions: Hide own name in huddle suggestions.
2017-07-07 12:12:30 -07:00
cf2dec539f
urls: Use POST for zerver.views.realm_icon.upload_icon.
...
This upload_icon endpoint is changed from PUT to POST becuase
this endpoint is not idempotent.
2017-07-07 10:31:43 -07:00
e99067cfc3
compose.js: Add node test coverage for abort_xhr() function.
2017-07-07 12:01:41 -04:00
d9009f0c84
node tests: Add test_trigger_submit_compose_form().
...
(Steve Howell also contributed to this.)
2017-07-07 12:01:26 -04:00
ada54d4574
compose.js: Add node test coverage for update_fade().
...
(Steve Howell made small changes.)
2017-07-07 11:57:43 -04:00
cf2a9b74d5
compose.js: Add node test coverage to initialze() function.
...
(Steve Howell contributed to this as well.)
2017-07-07 11:19:02 -04:00
a6082a2b95
compose.js: Add coverage for transmit_message() function.
2017-07-07 08:29:33 -04:00
f7e37d37b3
compose.js: Add coverage for finish() function.
2017-07-07 07:50:02 -04:00
c17efffa6a
compose.js: Add coverage for enter_with_preview_open() function.
2017-07-07 07:50:02 -04:00
55f05a5f53
compose.js: Add coverage for send_message() function.
2017-07-06 17:44:27 -04:00
1466cfaf0c
Add node tests for zjquery.
...
These tests should serve as a basic form of documentation on
how to use zjquery. It covers most of the basic principles.
2017-07-06 14:31:34 -04:00
74f9612147
node tests: Simplify trigger stubbing in stream_events.js.
...
This test verifies the following line of code:
$(document).trigger($.Event('subscription_remove_done.zulip', {sub: sub}));
Before this change, the mocking mechanism used `$(document).on(...)`
to set the function that gets called on trigger, but it didn't clear
any of the other handlers.
Since all we care about is making sure that the event gets triggered,
we now just override `$(document).trigger`.
2017-07-06 10:27:09 -04:00
38e3d2fc11
node tests: Use get_on_handler in stream_list.js.
2017-07-06 09:23:06 -04:00
6a8fa55521
node tests: Use get_on_handler() in message_store.js.
2017-07-06 09:13:19 -04:00
99a6a9b70d
node tests: Replace trigger() calls in activity.js.
...
We now use get_on_handler() to call event handlers, rather
than simulating a triggered event.
2017-07-06 08:46:36 -04:00
43544cef28
stream_events: Add tests for mark_unsubscribed.
2017-07-05 17:57:52 -04:00
2627c1cde3
stream_events: Add tests for mark_subscribed.
2017-07-05 17:57:52 -04:00
c8281de492
stream_events: Add tests for update_property.
2017-07-05 17:57:52 -04:00
a6cd460f72
emoji: Rename `emoji.realm_emojis` to `emoji.all_realm_emojis`.
2017-07-05 13:02:41 -07:00
77dc5df56a
uploads: Display year in attachments UI upload timestamp.
...
Modified timerender.js absolute_time() to include the
year in the returned time stamp string.
Fixes #5600 .
2017-07-04 16:13:20 -07:00
b13265d135
util: Remove execute_early.
...
This function was removed in favor of loading everything in
ui_init.js. The asynchronous nature of jQuery 3 document-ready
events may cause an undesirable order in which these are executed.
2017-07-04 13:54:33 -07:00
e33b178054
message_store: Move initialization to ui_init.js.
2017-07-04 13:54:33 -07:00
d3d6712fa3
left-sidebar: Update the size of the scrollbar after narrowing to a stream.
2017-07-03 09:53:41 -07:00
3cddc4ac93
settings: Add node test for url input box toggle.
...
This contains node test for toggling the url inputbox of
outgoing webhooks service url in the "Add new bot" form.
2017-07-03 11:09:40 -04:00
30c7629212
Change code block typeahead to only sometimes close fence.
...
Fixes #5556 .
Some tests needed to be moved around to make sure the
stubbing wouldn't break future tests.
2017-07-03 11:05:18 -04:00
4cb8ac100a
emoji: Fix the title and alt text for unicode emojis.
...
Unicode emojis when rendered should display canonical short name.
Similarly, the alt text should be of the format `:<short_name>:`.
For both of these we currently display the actual unicode symbol.
As some systems don't have the fonts necessary for displaying them
properly, they are rendered as empty square blocks. This commit also
ensures that the markup generated for emoji generated by canonical
name and by an unicode emoji is same.
Fixes : #5555 .
2017-07-01 11:14:24 -07:00
8abbb6d781
search: Remove in:all token from suggestions.
2017-07-01 12:19:52 -04:00
3fe6d12ab6
node tests: Test server_events_dispatch.js directly.
...
The dispatch.js tests now no longer go through server_events.js,
so the tests are isolated from some of the setup you have to
do for the main event loop. They now directly call into
server_events_dispatch.js.
2017-07-01 08:50:50 -04:00
74f40a0a58
compose.js: Add node test coverage for report_as_received() function.
2017-06-30 19:57:15 +05:30
4b3c2931ea
compose.js: Add test coverage for mark_rendered_content_disparity().
2017-06-30 19:57:15 +05:30
7e585acfa5
compose.js: Add coverage for send_message_success() function.
2017-06-30 19:57:15 +05:30
7f4781e17d
compose.js: Add test coverage for update_email().
2017-06-30 19:57:15 +05:30
3d043d0109
compose.js: Add coverage for get_invalid_recipient_emails().
2017-06-30 19:57:15 +05:30
9437895c9e
compose.js: Add coverage for validate_stream_message() function.
2017-06-30 19:57:15 +05:30
6cf4c65d92
node tests: Add 100% coverage for channel.js.
2017-06-30 09:48:04 -04:00
0b60538570
node tests: Extract test_get_reaction_section().
2017-06-30 08:05:10 -04:00
1e18863a98
timerender.js: Use stubbed version of i18n from zjsunit.
2017-06-29 15:18:08 -04:00
5eb5b33f21
settings_org.js: Use stubbed version of i18n from zjsunit.
2017-06-29 15:18:08 -04:00
a103949c2b
i18n.js: Fix issue of i18n stub not returning 'translated: ' prefix.
2017-06-29 15:18:08 -04:00
4d84be16ca
i18n.js: Fix issue with i18n being cleaned up in namespace cleanup.
2017-06-29 15:18:08 -04:00
7531a85c4d
stream_data: Add get_subscriber_count() function.
2017-06-29 10:34:47 -04:00
cc34e3d382
compose.js: Add coverage for validate_stream_message_address_info().
2017-06-29 18:02:25 +05:30
12b124ba71
single_message.handlerbars: Use __starred_status__ in tooltip.
...
We do not allow handlerbars within tranlation tags. To use variables in
translatable strings, enclose variables with double lowdashes.
2017-06-29 07:39:20 -04:00
aae3250155
node tests: Add test_with_view_stubs() for reactions.js.
2017-06-29 07:19:52 -04:00
791e489938
Use a proper context in insert_new_reaction().
...
Before this change, we were piggybacking fields on to the event
object, which coupled us to any other function that relies on
the event.
2017-06-29 07:19:52 -04:00
Harshit Bansal
Vaida
Vishnu Ks
Cory Lynch
Aditya Bansal
Steve Howell
David Coleman
vaibhav
Umair Khan