bde31a54c7
bot_data: Rename delete to del.
...
`delete` is a reserved keyword that would interfere with the migration
to an ES6 module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-04 16:48:33 -07:00
b2939cdf19
lint: Fix comma spacing in node tests.
...
I apparently failed to check the tests codebase before merging the
last linter commit. Oops.
2018-12-07 13:14:28 -08:00
5759d5a762
statis/js/bot_data.js: Add `get_bot_owner_email` function.
2018-11-16 09:52:05 -08:00
2d8f7843a2
node tests: Consolidate some set_global() calls.
...
Hopefully these cleanups will make it a little easier
to migrate our tests to take advantage of a true
module loading system.
2018-08-02 08:02:12 -04:00
26b48b95dc
refactor: Export settings_bots.render_bots().
...
We also now call this explicitly when we need to
re-render (instead of triggering a custom event).
2018-07-03 06:02:49 -07:00
f74d298478
node tests: Use run_test helper in bot_data.js.
2018-06-02 06:10:34 -04:00
ebe6144326
node tests: Avoid sneaky throttle/debounce delays.
...
For all of our current tests, we want to just execute
throttled functions immediately.
2018-04-26 08:42:47 -07:00
7046409e12
Revert "quick fix: Revert ES6 idiom that istanbul warns about."
...
This reverts commit 55ff9a6806
2018-04-23 15:27:16 -04:00
55ff9a6806
quick fix: Revert ES6 idiom that istanbul warns about.
2018-04-20 16:33:33 -07:00
b1c5f6c07d
node_tests: Update bot_data.js to use es6.
...
bot_data.js uses let/const for variables, and uses rest operator
instead of _.extends.
2018-04-20 15:46:28 -04:00
3a5b0841e4
node tests: Remove minor cruft from bots_data.js.
2018-04-17 17:52:19 -07:00
a78024f53d
bots: Delete bot from bot_data set on realm_bot delete event.
...
Fixes #8577 .
2018-03-08 07:54:19 -08:00
044b0beeab
frontend: Store embedded bot data in bot_data.js.
...
In specific, this stores config_data and service_name
for embedded bots.
2018-03-01 08:25:43 -08:00
02bc506518
bot_data.js: Fix dict indentation.
2018-02-09 12:30:24 -08:00
4cc8c74aaa
frontend: Internally refer to bots by ID.
...
This is done by using a bot's ID instead of email in
the handler methods for bot_data.bots and bot_data.services,
and updating all code paths involved.
2018-01-23 07:29:00 -05:00
bd6fa385a5
frontend: Add outgoing webhook config entries to the "edit bot" menu.
...
This allows users to edit an outgoing webhook's endpoint URL
and interface type after it has been created.
Fixes #7411 .
2018-01-23 07:29:00 -05:00
e63dd59065
node tests: Use zrequire in bot_data.js.
2017-11-08 12:24:17 -08:00
f25c16b573
node tests: Add coverage for get_all_bots_for_current_user.
2017-05-25 09:54:05 -07:00
115b2f6b6b
node tests: Fix indentation.
2017-05-25 09:54:05 -07:00
74ad90533d
node: Fix missing bot_data initialization.
...
This was making the frontend tests fail.
2017-05-24 19:59:40 -07:00
c02f4b4756
Add people.initialize().
...
This makes us not have to stub jquery in many of our node
tests!
2017-05-23 19:35:08 -07:00
84c4d67916
home.py: move bot_list as realm_bots to register_ret.
...
Simplify the page_params generation logic #3853
2017-04-28 21:24:44 -07:00
153c24d071
Remove dead code related to bot/stream settings.
...
We had never-enabled code to allow users to set default
streams for their bots (for event registration, default sending, etc.).
This commit removes the code.
2017-04-07 15:20:12 -07:00
bbcd927375
bot_data.js: Replace `remove()` with `deactivate()`.
...
On receiving a `remove` event of type `realm_bot`, instead
of deleting the bot from `bots` dict, set it's `is_active`
flag to false.
2017-02-26 23:56:51 -08:00
53308b49b2
refactor: Remove last uses of page_params.email in JS code.
...
Earlier commits removed all uses of page_params.email outside
of people.js, and it turns out we have page_params.user_id, so
we don't even need page_params.email for seeding the data.
2017-01-21 21:45:12 -08:00
5bce806c4e
refactor: Introduce people.my_current_email().
...
This commit doesn't change any behavior yet, but it starts us
down the road of deprecating page_params.email and allowing
people.js to control all access to the current user's email,
which will be important for email changes.
2017-01-21 21:45:12 -08:00
73125e2718
refactor: Move is_current_user() to people.js.
...
We no longer have it in util.js, because we will
want to encapsulate this better for upcoming commits
related to email changes.
2017-01-21 21:45:12 -08:00
0329b67048
admin: Limit bots in settings page.
...
Updated `get_editable()` so that organization admins only see their
own bots in their personal settings page; this removes a lot of
unnecessary clutter.
Fixes #2657 .
2016-12-14 19:29:02 -08:00
459421d045
eslint: Update node tests to use new comma-dangle rules.
...
* In most cases, eslint --fix with the right comma-dangle settings was
able to update the code correctly.
* The exceptions were cases where the parser incorrectly treated the
arguments to functions like `assert_equal` as arguments; we fixed
these manually. Since this is test code, we can be reasonably
confident that just fixing the failures suffices to correct any bugs
introduced by making changes automatically.
2016-12-03 15:00:24 -08:00
c90da24541
eslint: change keyword-spacing from warning to error and fix violations.
2016-12-01 14:22:15 -08:00
b25562ca1d
Add and use util.is_current_user helper function.
...
Previously, we were checking if a particular user was the current user
in dozens of places in the codebase, and correct case-insensitive
checks were not used consistently, leading to bugs like #502 .
2016-06-07 21:58:44 -07:00
10657c1d53
Move node tests to node_tests/.
2015-10-28 10:11:47 -07:00
Anders Kaseorg
Tim Abbott
Yashashvi Dave
Steve Howell
Joshua Pan
Priyank Patel
Shubham Padia
Robert Hönig
Yago González
Steve Howell
fionabunny
Harshit Bansal
Tommy Ip
Tim Abbott