Tomasz Kolek
f4bd9dfda5
integrations doc: Move phabricator doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
4a6acc4fb9
integrations doc: Move perforce doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
5426725c43
integrations doc: Move openshift doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
484fef059b
integrations doc: Move nagios doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
489a7d1784
integrations doc: Move mercurial doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
372c7224f0
integrations doc: Move jira-plugin doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
f0ace02e6c
integrations doc: Move jenkins doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
34500f755c
integrations doc: Move hubot doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
bd1103373d
integrations doc: Move google-calendar doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
6ff130b829
integrations doc: Move git doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
d1b4a4546d
integrations doc: Move email doc to separate file.
2017-04-05 13:43:47 -07:00
Tomasz Kolek
3c0287cfc7
integrations doc: Move codebase doc to separate file.
2017-04-05 13:37:37 -07:00
Tomasz Kolek
cbe00e020c
integrations doc: Move capistrano doc to separate file.
2017-04-05 13:37:37 -07:00
Tomasz Kolek
a39c55b4ab
integrations doc: Move asana doc to separate file.
2017-04-05 13:19:58 -07:00
Tomasz Kolek
5b17622589
docs: Move integrations.html to integrations/index.html.
...
Add omiting rule for all of integrations docs in test_templates.
2017-04-05 13:19:58 -07:00
Tomasz Kolek
62603940a7
integrations doc: Remove basecamp old-style doc.
2017-04-05 13:19:58 -07:00
Tim Abbott
cfe8871dfc
test_audit_log: Put all tests in a single test class.
...
This simplifies the process for adding new tests here a bit.
2017-04-05 12:53:59 -07:00
Maxim Averin
02900ff54a
Switch do_change_bot_owner to use RealmAuditLog.
...
This requires adding an `acting_user` parameter to the
`do_change_bot_owner` function.
2017-04-05 12:50:55 -07:00
Umair Khan
be65125d3d
Handle unicode characters in email mirror.
...
Fixes #2328 .
2017-04-05 12:18:41 -07:00
Cynthia Lin
59bfd4e1c7
integrations: Update logos.
...
Fixes #3219
2017-04-05 11:45:51 -07:00
Umair Khan
846e8686c4
makemessages: Exclude hidden files.
...
Fixes #3981 .
2017-04-05 11:09:32 -07:00
Umair Khan
8e87ba439d
github: Go to registration if email is invalid.
2017-04-04 18:03:33 -07:00
Umair Khan
3bac73159a
backends: Test authenticate() with kwargs.
...
Django uses arguments to differentiate between different authenticate
function so it is important to pass arguments in a predictable manner.
Keyword args will test the name of the argument as well.
2017-04-04 18:03:33 -07:00
Umair Khan
8c3a0126c1
test_auth_backends.py: Add get_username().
2017-04-04 18:03:33 -07:00
Umair Khan
07ea08c184
test_classes: Remove assert_max_length.
...
We should avoid this kind of assertions because they are
not deterministic.
2017-04-04 17:07:34 -07:00
Umair Khan
24dfc49792
test_users: Change assert_max_length to assert_length.
2017-04-04 17:07:34 -07:00
Umair Khan
5682b208ea
test_signup: Change assert_max_length to assert_length.
2017-04-04 17:07:34 -07:00
Umair Khan
1b8d9f186e
test_presence: Change assert_max_length to assert_length.
2017-04-04 17:07:34 -07:00
Umair Khan
cc96cefe75
test_messages: Change assert_max_length to assert_length.
2017-04-04 17:07:06 -07:00
Steve Howell
205f2c1562
Add ping_only flag for presence updates.
...
The web app doesn't need any presence data for its first ping to
the server, because it already has up-to-date presence info in
page_params. So now we can tell the server not to send us a big
payload that we were already ignoring.
2017-04-04 15:57:10 -07:00
Steve Howell
3a332aee0b
Exclude dormant users from buddy list queries.
...
If a user has not shown activity in two weeks, we exclude
them from the buddy list. This should help performance for
large realms and mobile clients.
2017-04-04 15:57:10 -07:00
Steve Howell
2718bd0b5d
Extract presence.js to track presence info.
...
Most of this code was simply moved from activity.js with some
minor renaming of functions like set_presence_info -> set_info.
Some functions were slightly nontrivial extractions:
is_not_offline:
came from activity.huddle_fraction_present
get_status/get_mobile:
simple getters
set_user_status:
partial extraction from activity.set_user_status
last_active_date:
pulled out of admin.js code
We also fixed activity.filter_and_sort to take user_ids.
2017-04-04 15:57:10 -07:00
Harshit Bansal
cebcfb8d29
test_realm_aliases.py: `realm_alias` to `realm_domain` migration.
...
* Remove any occurrences of `alias` or `realm_alias`.
* Rename `test_realm_aliases.py` to `test_realm_domains.py`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
b40a8ea20b
views/realm_aliases.py: `realm_alias` migration.
...
* Rename `views/realm_aliases.py` to `views/realm_domains.py`.
* Remove any occurrences of `alias`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
664b23c495
commands: Rename `realm_alias` command to `realm_domain`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
362ee482c0
commands/realm_alias.py: Remove any occurrences of `alias`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
fe4cba9aa7
test_events.py: Remove any remaining occurrences of `alias`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
711a3f8037
actions.py: Rename remaining occurrences of `alias' to `realm_domain`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
c226c651f7
actions.py: Rename `do_remove_realm_alias()` to `do_remove_realm_domain()`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
a08155b09e
actions.py: Rename `do_change_realm_alias()` to `do_change_realm_domain()`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
2da4fc0dc4
actions.py: Rename `do_add_realm_alias()` to `do_add_realm_domain()`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
983225612d
actions.py: Rename `get_realm_aliases()` to `get_realm_domains()`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
582d8a351f
zerver/models.py: Rename remaining occurences of `alias` to `realm_domain`.
2017-04-04 15:48:03 -07:00
Harshit Bansal
92c512d679
zerver/models.py: Rename can_add_alias() to can_add_realm_domain().
2017-04-04 15:48:03 -07:00
Harshit Bansal
6f0b46d84f
create_realm.py: Remove unnecessary imports.
2017-04-04 15:48:03 -07:00
Harshit Bansal
ac2172e233
models: Rename RealmAlias model to RealmDomain.
...
Includes a migration.
2017-04-04 15:48:03 -07:00
Kouhei Sutou
7c43aa1372
message: Use pgroonga.match_positions_character.
...
We can remove byte version text highlight method with this change.
pgroonga.match_positions_character was added in PGroonga 1.1.1:
http://pgroonga.github.io/reference/functions/pgroonga-match-positions-character.html
PGroonga 1.1.1 was released at 2016-08-31. So we can use it.
2017-04-04 14:05:45 -07:00
Eeshan Garg
da599ad28c
webhooks/gitlab: Add support for filtering GitLab branches.
2017-04-04 13:51:08 -07:00
Umair Khan
4f9b6303a7
test_narrow.py: Add workaround for Pgroonga regression.
...
Due to Pgroonga regression, there is a difference in search
result between Travis and development env due to which one of
our tests fails. This commit makes sure that the test passes
for both strings till the Pgroonga bug is resolved.
2017-03-29 22:12:15 -07:00
Sarah
dea563b27e
zerver/lib/test_events: Refactor realm update tests.
...
Created do_set_realm_property_test and refactored individual realm tests
to use this function for testing updating realm properties.
2017-03-30 02:17:10 +00:00
Rishi Gupta
754b547e88
populate_db: Change enter_sends to True for development users.
...
Fixes #4355 .
2017-03-29 18:38:30 -07:00
Tim Abbott
9aa77e491e
tests: Get hotspots to 100% test coverage.
2017-03-29 14:04:33 -07:00
Amy Liu
6f061beb46
hotspots: Add backend support for tutorial hotspots.
...
This commit adds the backend support for a new style of tutorial which
allows for highlighting of multiple areas of the page with hotspots that
disappear when clicked by the user.
2017-03-29 11:34:32 -07:00
Umair Khan
33c130a603
Make pgroonga tests pass to workaround pgroonga regression.
...
Note that the old behavior was correct; we're just merging this to
make the tests pass until upstream can fix it.
2017-03-29 11:32:37 -07:00
Tim Abbott
9a9f0f86e9
test_messages: Fix sometimes incomplete coverage in StarTests.
...
This test had nondeterministically incomplete test coverage.
2017-03-28 11:41:45 -07:00
Tim Abbott
5776ecfac2
test_audit_log: Fix unnecessary user creation.
2017-03-27 13:23:10 -07:00
Maxim Averin
f213369e1d
zerver: Replace log_event with RealmAuditLog in do_change_avatar_fields.
2017-03-27 13:23:10 -07:00
Tim Abbott
141469399b
RealmAuditLog: Add an extra_data field.
...
This will be useful for logging any additional details that we might
want to display.
2017-03-27 13:22:58 -07:00
Eeshan Garg
8933b5b31d
github_webhook: Filter specific GitHub branches.
...
Fixes : #4000
2017-03-26 13:32:24 -07:00
Tim Abbott
db92dec05e
test_events: Start using test_dict_only.
...
This is a proof of concept; we'll want to migrate the rest of the call
points soon.
2017-03-26 13:10:54 -07:00
Tim Abbott
2160088d94
test_events: Enforce length of events list.
2017-03-26 13:10:54 -07:00
Tim Abbott
118f2db22d
validators: Add a test_dict_only validator that bans other arguments.
...
This is primarily intended to be useful in EventsRegisterTest.
2017-03-26 13:10:54 -07:00
Tim Abbott
b5cf0067d5
logging_handlers: Avoid super long subject lines.
2017-03-26 13:10:43 -07:00
Tim Abbott
36bb2bf54a
AdminZulipHandler: Bring logging_handlers.py to 100% test coverage.
...
This involved fixing some unupdated code in one code path.
2017-03-26 13:10:43 -07:00
Tim Abbott
267346f5fb
AdminZulipHandler: Support passing a record without a request.
2017-03-26 13:10:43 -07:00
Tim Abbott
efa151b488
AdminZulipHandler: Extract add_request_metadata.
2017-03-26 13:10:43 -07:00
Tim Abbott
4276face7f
AdminZulipHandler: Construct report more dynamically.
2017-03-26 13:10:43 -07:00
Tim Abbott
1a17b11788
logging_handlers: Add tests for main error reporting code path.
2017-03-26 13:10:43 -07:00
Tim Abbott
033fd98e5f
decorator: Add rate limiting to zulip_login_required.
2017-03-26 13:10:43 -07:00
Tim Abbott
385551ff62
decorator: Add rate-limiting to JSON views.
2017-03-26 13:10:43 -07:00
Tim Abbott
6c4c8178f0
zulip_login_required: Set request._query.
...
This fixes an exception we had in the user_activity queue processor
when changing email addresses, since the URL containing the
confirmation key was longer than 50 characters.
2017-03-26 13:10:43 -07:00
Bao Chau
9b6e648acb
registration: Fetch length limits from the backend's actual sizes.
...
This makes these more likely to remain accurate over time.
Fixes #4211 .
2017-03-25 20:10:12 -07:00
Rishi Gupta
30024d0a8f
models: Remove Realm.domain.
2017-03-25 19:55:48 -07:00
Rishi Gupta
b416587aab
Change sender_domain to sender_realm_str in message dict.
2017-03-25 19:50:24 -07:00
Rishi Gupta
88abb7871d
Remove domain from list of pre-fetched fields for message recipients.
2017-03-25 19:50:24 -07:00
Harshit Bansal
11327fda7c
actions.py: Only admins and bot's owner should recieve bot related events.
...
Modify `bot_owner_user_ids()` to return the user_ids of only
admins and bot owners instead of all the current active users.
This was causing a traceback on the frontend.
Fixes : #3391 .
2017-03-25 18:22:15 -07:00
Elliott Jin
98ddb4453e
test-backend: Raise zerver/views/home.py test coverage to 100%.
2017-03-25 18:16:16 -07:00
Elliott Jin
1c0d58f897
test-backend: Raise zerver/views/auth.py test coverage to 100%.
2017-03-25 18:16:16 -07:00
K.Kanakhin
fe3213798d
retention: Add models to store expired messages.
...
This addresses part of #106 .
2017-03-25 18:12:06 -07:00
Tim Abbott
18e66983c4
signals: Fix mypy error.
2017-03-25 18:06:04 -07:00
K.Kanakhin
234a1f8e61
retention-period: Add retention period to front-end admin organization settings.
...
- Add message retention period field to organization settings form.
- Add css for retention period field.
- Add convertor to not negative int or to None.
- Add retention period setting processing to back-end.
- Fix tests.
Modified by tabbott to hide the setting, since it doesn't work yet.
The goal of merging this setting code now is to avoid unnecessary
merge conflicts in the future.
Part of #106 .
2017-03-25 17:57:18 -07:00
Tim Abbott
6a884acff5
signals: Avoid importing bugdown from early initialization.
...
This fixes `tools/build-release-tarballs` failing.
2017-03-25 17:27:46 -07:00
Tim Abbott
004133561b
realm_filters: Support ? in URL format strings.
2017-03-25 17:13:34 -07:00
Tim Abbott
22d284950d
trello: Clean up the documentation.
2017-03-25 17:04:52 -07:00
hollywoodno
75d9630258
Add notifications on new logins to Zulip.
...
This adds helpful email notifications for users who just logged into a
Zulip server, as a security protection against accounts being hacked.
Text tweaked by tabbott.
Fixes #2182 .
2017-03-25 16:50:52 -07:00
Tim Abbott
7bcf24d39c
test_management_commands: Reset settings.RUNNING_INSIDE_TORNADO.
...
This fixes a leak of this setting change that resulted from the
unusual way that our Tornado system sets this variable early in the
management command.
Fixes #3685 .
2017-03-23 23:56:10 -07:00
Tim Abbott
3617ebfd41
api: Rename get_old_messages to get_messages in the backend.
...
Fixes #1315 .
2017-03-23 23:52:44 -07:00
wizsid11
95789eb879
Add Slack webhook.
...
Adds a new webhook integration for Slack to receive messages
from one's Slack team's public channels.
Contains negative tests for broken, missing or invalid data.
Allows two different option for integration:
1. Receive notification on a single stream with different topics
for each of Slack's public channels.
2. Receive notification on different streams for each of Slack's
public channels.
Steps to choose between the two options is described in the documentation.
Fixes #3569 .
2017-03-23 23:32:38 -07:00
Tomasz Kolek
be0a2cb20b
Add basecamp3 webhook integration.
...
Fixes : #3949 .
2017-03-23 23:28:53 -07:00
Tomasz Kolek
09f5180da9
github_webhook: Return 200 OK if event is not supported.
...
Change raising exception when event is not supported to just logging it.
2017-03-23 23:26:55 -07:00
Tomasz Kolek
fcd091132d
jira: Return 200 OK if event is not supported.
2017-03-23 23:26:55 -07:00
Tim Abbott
a6ae546f59
test_events: Bring zerver/lib/events.py to 100% coverage.
2017-03-23 22:43:10 -07:00
Tim Abbott
0c16cc1c1e
test_events: Add a test for do_refer_friend.
2017-03-23 22:43:10 -07:00
Tim Abbott
055a18e71f
test_events: Add a test for do_update_embedded_data.
2017-03-23 22:43:10 -07:00
Tim Abbott
eb19a25aba
events: Fix races in stream creation event and add tests.
...
This fixes 2 issues:
* Being added to an invite_only stream did not correctly update the
"streams" key of the initial state.
* Once that's resolved, subscribe_to_stream when called on a
nonexistant stream would both send a "create" event (from
create_stream_if_needed) and an "occupy" event (from
bulk_add_subscriptions).
The second event should just be suppressed in that case, and this
implements that suppression.
2017-03-23 22:43:09 -07:00
Tim Abbott
8eb020d190
test_events: Add a test for do_update_muted_topic.
2017-03-23 22:27:39 -07:00
Tim Abbott
dbe3ea59aa
test_events: Add a failing presence test.
...
Apparently our presence real-time sync is slightly broken; this test
at least reveals that fact.
2017-03-23 22:27:39 -07:00
Tim Abbott
d1760a1bb9
validators: Add check_float validator.
2017-03-23 21:23:41 -07:00
Tim Abbott
12a6913bbf
test_events: Add a test for do_update_message_flags.
2017-03-23 21:11:33 -07:00
Tim Abbott
2b905d242d
events: Fix timezone realm-time sync and add test.
2017-03-23 19:11:34 -07:00
Tim Abbott
86e3d1effc
events: Fix default language realm-time sync and add test.
...
We previously didn't apply the default language event change
correctly.
Not super important as a bug, since we require the user to reload the
browser for their changes to take effect, but this will save time if
we ever change that.
2017-03-23 19:08:17 -07:00
Tim Abbott
99515c2d34
test_events: Add tests for default streams being None.
2017-03-23 19:04:13 -07:00
Tim Abbott
adcf8263d6
tests: Fix passing non-unicode strings to do_set_realm_property.
...
This fixes test failures on Python 3 caused by
a98bce98c6
.
2017-03-23 18:37:12 -07:00
Tim Abbott
a98bce98c6
realm: Add registry of realm property types.
...
This makes it possible for us to do some convenient validation for
developers, checking whether the correct types are passed for each
each realm property.
2017-03-23 17:55:50 -07:00
Sarah Stringer
09f66b5c6d
actions: Add do_set_realm_property function and migrate to it.
...
zerver/lib/actions: removed do_set_realm_* functions and added
do_set_realm_property, which takes in a realm object and the name and
value of an attribute to update on that realm.
zerver/tests/test_events.py: refactored realm tests with
do_set_realm_property.
Kept the do_set_realm_authentication_methods and
do_set_realm_message_editing functions because their function
signatures are different.
Addresses part of issue #3854 .
2017-03-23 17:52:45 -07:00
Umair Khan
2d4a1f93ff
testing: Bring zproject.backends coverage to 100%.
2017-03-23 17:12:58 -07:00
Tim Abbott
36988f9375
mypy: Fix Optional typing issues in tex.py.
2017-03-23 15:49:08 -07:00
Akash Kothawale
4c2bfae83e
get_stream: Throw DoesNotExist if stream is not found.
...
This makes get_stream match get_realm, get_user_profile_by_email,
etc., in interface, and is more convenient for mypy annotations
because `get_stream` now doesn't return an Optional[Stream].
2017-03-23 15:42:00 -07:00
Tim Abbott
06492738b5
dev: Expose coverage and built documentation to web.
...
This makes it much more convenient for developers to access coverage
and built developer documentation.
2017-03-23 13:10:06 -07:00
Tim Abbott
97e844e97c
test_notifications: Don't pass a user_profile to client_patch.
...
This fixes a JSON overflow error when producing URL coverage reports.
2017-03-23 13:08:49 -07:00
Tim Abbott
f3af0fe635
reactions: Fix reacting to messages on streams you're not subscribed to.
...
We use the same strategy Zulip already uses for starred messages,
namely, creating a new UserMessage row with the "historical" flag set
(which basically means Zulip can ignore this row for most purposes
that use UserMessage rows). The historical flag is ignored, however,
in determining which users' browsers to notify about new reactions,
and thus the user will get to see the reaction appear when they click
a message (and any reactions other users later add, as well!).
There's still something of a race here, in that if some users react to
a message while the user is looking at the unsubscribed stream but
before the user reacts to that message, those reactions will not be
displayed to that user (so counts will be a bit lower, or something).
This race feels small enough to ignore for now.
Fixes #3345 .
2017-03-22 20:22:13 -07:00
Tim Abbott
60326ca94c
test_events: Add reaction tests.
2017-03-22 20:22:02 -07:00
Tim Abbott
0963f2d518
reactions: Extract notify_reaction_update.
2017-03-22 20:22:02 -07:00
Tim Abbott
67a4ce99ee
tutorial: Disable tutorial for default development users.
...
You can always make a new user if you need to test the tutorial, and
this will save a bunch of developer time ignoring the tutorial popup.
2017-03-22 15:30:36 -07:00
hollywoodno
d6716838ad
bugdown: Remove trailing whitespace on fence code blocks.
...
This fixes fenced code blocks that are copy-pasted from certain
clients having trailing whitespace anoyingly often.
Fixes #3998 .
2017-03-22 14:17:34 -07:00
Tim Abbott
0fec03f8bb
test_docs: Fix normal users test text.
2017-03-22 13:14:19 -07:00
sinwar
397e9c109e
auth: Separate development login from main login page.
...
This allows us to enable EmailAuthBackend by default in development
without cluttering the development login experience.
Fixes #3652 .
2017-03-22 12:54:30 -07:00
Rishi Gupta
4c88b3f5da
logging_util: Fix timezone-naive datetime being compared to aware datetime.
...
Fixes regression in 3d07ac0
.
2017-03-22 12:51:58 -07:00
Umair Khan
3c0f341eb7
test_subs.py: Change assert_max_length to assert_length.
2017-03-22 12:07:21 -07:00
Umair Khan
804c62045f
testing: Flush API_KEYS before every test.
...
This makes our test performance for each test more consistent.
2017-03-22 12:07:06 -07:00
Umair Khan
ff8ab054da
testing: Fix query count for test_bulk_subscribe_MIT.
...
test_subs.SubscriptionAPITest.test_bulk_subscribe_MIT fails when it is
run individually.
2017-03-22 12:07:06 -07:00
Umair Khan
8431ceace2
testing: Serialize BotTest with upload tests.
2017-03-22 11:59:30 -07:00
Yago González
34a9e1ae11
markdown: Add TeX typesetting support.
...
Co-authored-by: Reid Barton <rwbarton@gmail.com>
Fixes #2056 .
2017-03-21 16:40:00 -07:00
Rishi Gupta
caef5332d5
mailchimp: Fix error in add_users_to_mailing_list.py.
...
Old behavior is a holdover from development testing.
2017-03-21 16:13:00 -07:00
Tim Abbott
993276b882
test_upload: Add tests for realm icon URL scheme.
2017-03-21 16:12:04 -07:00
Tim Abbott
8775a22663
avatar: Fix buggy avatar URL scheme with S3 backend.
...
Also adds tests for the avatar URL scheme.
2017-03-21 16:12:04 -07:00
Ayush Jain
bddcfb1c96
Add realm-level settings to control inline image and url preview.
...
This gives users more control in case they don't want previews,
especially for the "previews of linked websites" feature.
Fixes : #2640 .
2017-03-21 15:46:17 -07:00
Umair Khan
a2aeddba6b
testing: Add infrastructure for running backend tests in parallel.
...
This doesn't yet provide an option to actually run the backend tests
parallelized yet.
2017-03-21 10:59:12 -07:00
Tim Abbott
6d452e87a5
context_processors: Handle requests without user set.
...
If `render()` is called from middleware that runs before the
authentication middleware, then this code path will be called with a
request object where request.user is not yet set. Handle this by
providing a reasonable error message.
2017-03-21 10:06:39 -07:00
Tim Abbott
a474f4359d
tests: Set maxDiff to None unconditionally.
2017-03-21 07:34:16 -07:00
Tim Abbott
c2c02ea4da
middleware: Fix typo in render_to_response migration.
...
This fixes a 500 on the invalid realm page.
2017-03-21 07:30:28 -07:00
adnrs96
8ae35211b5
migration: Sync sizes for existing Attachment objects with actual files.
...
Tweaked by tabbott to add a nop reverse migration.
Fixes #3883 .
2017-03-21 00:53:22 -07:00
Tim Abbott
aa7e4fec35
messages: Require join with zerver_message if use_first_unread_anchor.
...
This fixes a 500 bug where the RN mobile app would simply fail to load
old messages if use_first_unread_anchor was not set.
2017-03-21 00:02:46 -07:00
Steven Ganz
5041d86db0
tests: Add several missing tests to test_events.
...
This fixes part of #3633 .
Extracted by tabbott from #4162 as ready to merge now.
2017-03-19 23:12:12 -07:00
Tim Abbott
ceeb95ebb1
tests: Fix missing test coverage for /json/realm.
...
In aa880b0419
, we used the raw
do_set_realm_description method rather than calling the API, which
meant that the API success path wasn't actually tested.
2017-03-19 22:49:16 -07:00
Tim Abbott
81194df65d
test_bots: Add stream is not None asserts.
2017-03-19 22:26:25 -07:00
Tim Abbott
e2eeef5118
recipient_for_emails: Fix confusing type reuse.
2017-03-19 22:26:25 -07:00
Tim Abbott
7e5d5b5cce
mypy: Clean up repetition in test_realm_aliases.
...
The assert added in this refactoring addresses a mypy issue with
strict optional since get_realm_by_email_domain might return None.
2017-03-19 22:26:25 -07:00
Tim Abbott
5b0ff2a69a
mypy: Fix some strict-optional related issues.
2017-03-19 22:26:25 -07:00
Tim Abbott
2b62c4fa38
mypy: Fix missing annotation in Tornado handlers.
...
This was accidentally removed in
9866124b78
, but is needed on the current
mypy version.
2017-03-19 22:26:25 -07:00
Tim Abbott
8fa60cf77c
py3: Remove use of typing.Deque.
...
Apparently this is only available in ultra-modern versions of Python 3?
2017-03-19 21:39:54 -07:00
Tim Abbott
9866124b78
mypy: Fix some new errors flagged by latest mypy master.
...
Mostly list -> List bugs in annotations.
2017-03-19 21:03:45 -07:00
Sarah Stringer
aa880b0419
Add organization description field to realm settings.
...
This adds an organization description field to the Realm model, as well as
an input field to the organization settings template. Added three tests.
Set the max length of the field to 100 characters.
Fixes #3962 .
2017-03-19 14:05:01 -07:00
Jacob Hurwitz
0a76a609ec
Fix bugs with handling of the empty narrow.
...
An empty narrow (ie, the home view) can be represented in code as either
`None` or `[]` but we had incorrect handling that failed to fully
properly deal with either case.
(1) In `get_stream_name_from_narrow`, we failed to deal with `None` by
trying to always iterate over `narrow`.
(2) In several other places, we failed to deal with `[]` by explicitly
checking `if narrow is None` or `if narrow is not None`. Changing these
to truthiness checks should work for both the `None` and `[]` cases.
2017-03-19 11:47:03 -07:00
Rishi Gupta
6ba11785ea
js dependencies: Change hashchange_encode to hash_util_encode in zerver.
...
This function formerly replicated the behavior of hashchange.encode, and now
replicates the behavior of hash_util.encode.
2017-03-18 20:40:34 -07:00
Rishi Gupta
19d8d16126
js dependencies: Split hash_util.js from hashchange.js.
2017-03-18 20:40:34 -07:00
Tim Abbott
767f57ef03
tests: Remove imports of deleted message_ids.
2017-03-18 20:40:34 -07:00
K.Kanakhin
3e397090e1
user-presence: Add client info to aggregated presence status.
...
Fixes zulip/zulip-android#454 .
2017-03-18 20:36:41 -07:00
Tim Abbott
4dbb17db64
test_helpers: Remove unused message_ids function.
2017-03-18 19:22:49 -07:00
Elliott Jin
1138057209
test-backend: Raise zerver/views/registration.py test coverage to 100%.
2017-03-18 18:11:59 -07:00