9303c386b8
tests: Count queries for /json/users.
...
I am trying to optimize a query in this endpoint.
I don't think I'll actually reduce the number of
queries, but I wanted to capture the query and
this was the easiest way to do it, so might as
well check in the code! :)
2020-02-09 22:04:02 -08:00
c1370547d5
events: Only send bot_type for bots and thus remove the for_api param.
2019-10-29 15:41:35 -07:00
5b3e346369
users: Send custom profile fields with the /profile endpoint.
2019-10-29 15:41:35 -07:00
1946692f9a
users: Refactor get_members_backend endpoint to use get_raw_user_data.
...
Modify the get_raw_user_data method for use by the /users API endpoint
and then modify the /users endpoint to use it.
2019-10-23 14:50:26 -07:00
bbf2474bd0
tests: setUp overrides should call super().setUp().
...
MigrationsTestCase is intentionally omitted from this, since migrations
tests are different in their nature and so whatever setUp()
ZulipTestCase may do in the future, MigrationsTestCase may not
necessarily want to replicate.
2019-10-19 17:27:01 -07:00
4166c901ef
do_update_user_custom_profile_data: Rename to ..._if_changed.
...
This adds clarity to the fact that the function no longer does
anything if the field values haven't changed.
2019-10-01 13:52:43 -07:00
d66cbd2832
do_update_user_custom_profile_data: Don't notify if value not changed.
2019-10-01 13:50:14 -07:00
e05429b6a9
custom fields: Add default external account custom fields.
2019-08-28 15:35:53 -07:00
330d065a69
zerver/tests/test_custom_profile_data: Group tests cases.
2019-08-25 20:59:13 -07:00
ed5cb6c28b
custom profile fields: Extract field validation function.
2019-08-25 20:59:08 -07:00
5ab64daecc
mypy: Remove type ignore by defining ProfileDataElement using TypedDict.
2019-08-06 23:24:56 -07:00
b37c6a8644
custom profile: Update a few error messages.
2019-08-05 20:59:47 -07:00
d7ee2aced1
models: Add `external_account` in custom profile field types.
...
Add new custom profile field type, External account.
External account field links user's social media
profile with account. e.g. GitHub, Twitter, etc.
Fixes part of #12302
2019-07-09 17:21:54 -07:00
f813fdcd5e
populate_db: Rename URL type custom profile field.
...
Rename URL type custom profile field in populate db to avoid confusion
with the "GitHub profile" custom external account profile field we'll
be adding shortly.
2019-07-09 17:21:39 -07:00
9efda71a4b
get_realm: raise DoesNotExist instead of returning None.
...
This makes the implementation of `get_realm` consistent with its
declared return type of `Realm` rather than `Optional[Realm]`.
Fixes #12263 .
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-05-06 21:58:16 -07:00
643bd18b9f
lint: Fix code that evaded our lint checks for string % non-tuple.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-04-23 15:21:37 -07:00
649235cfec
python: Remove unused imports.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-02-22 16:54:36 -08:00
3127fb4dbd
zerver/tests: Remove unused imports.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-02-02 17:43:03 -08:00
6b1d724f5c
zerver: Add bugdown rendering for text custom profile fields.
...
This is the first step of letting users use Zulip markdown in their
SHORT_TEXT and LONG_TEXT custom profile fields, so that they can
include emphasis, links, etc.
This doesn't include any frontend logic yet, however.
2018-11-29 09:47:32 -08:00
8ef0c6d99a
custom profile field: Add length validation on field name and hint.
...
Add max length validation for custom field name and hint
on create-field and update-field backend views and
frontend forms.
Fixes #10284 .
2018-08-17 08:37:27 -07:00
2a73b2b805
custom profile field: Add at-least-one-choice validation for choice field.
...
Add validation at-least-one-choice required for every choice type field
in backend.
2018-08-14 10:17:57 -07:00
8909cb1d15
custom fields: Allow list of users in user type of custom fields.
...
Allow user to add more than one user-value in user type of custom
fields.
Tweaked by tabbott to improve the models.py code and type annotations.
2018-06-16 09:37:49 -07:00
f7f039e772
custom fields: Add endpoint to delete value of custom profile data.
...
Add delete endpoint at `users/me/profile_data` to delete value of
custom profile data.
Fixes #9669
2018-06-07 08:35:04 -07:00
e82c879b85
custom fields: Add user type of custom fields.
...
Fixes #8878
2018-05-27 23:01:21 -07:00
8909836815
zerver/tests/test_custom_profile_data.py: Refactor tests.
...
Refactor custom fields creation and deletion tests to assert
if created/deleted field exist or not, instead of asserting
total count of all realm fields.
2018-05-15 12:38:18 -07:00
5416d137d3
zerver/tests: Change use of typing.Text to str.
2018-05-12 15:22:39 -07:00
594451707d
check_capped_string: Clean up corner case.
...
We were rejecting strings of length equal to the max.
While we're at it, fix the unnecessary period in the error message,
which doesn't align with similar validators.
2018-05-03 14:30:03 -07:00
f4f64243dd
custom_profile_fields: Support changing the sort order of the fields.
...
Tweaked by tabbott for variable naming and the URL.
Closes #8879 .
2018-04-30 18:17:41 -07:00
de30474ddd
test_custom_profile_data: Don't do a database query on import.
...
This is a general code cleanlyness improvement.
While we're at it, we combine together two test classes that didn't
have a particularly good reason for existing.
2018-04-30 10:57:23 -07:00
0a9fbe2ce6
zerver/tests/test_custom_profile_data.py: Refactor tests.
...
Refactor tests to include generic function for invalid
assertion and remove repetitive assertion code.
2018-04-30 10:53:23 -07:00
a97a00a4c6
custom fields: Replace field id with field name in error message.
2018-04-30 10:53:23 -07:00
0d7d94d0db
custom fields: Add support for custom URL field type.
2018-04-30 10:53:23 -07:00
4033f210af
custom fields: Add support for custom date field type.
2018-04-30 23:04:25 +05:30
94d787aa2e
zerver/test/test_custom_profile_data.py: Remove hard-coded field no's.
2018-04-30 23:04:25 +05:30
976e61d687
validators: Improve error messages for check_capped_string.
2018-04-30 10:07:06 -07:00
cf2f6b38dd
profile: Add choice field.
...
Fixes part of #8878
2018-04-26 00:35:51 -07:00
0420b89468
profile: Add hint attribute to custom profile fields.
...
This is the model for #8876 .
2018-04-19 11:32:35 -07:00
1d4b74482c
check_short_string: Change max_length to 50.
2018-04-02 09:51:09 -07:00
c30a282dd9
profile: Remove integer and float fields.
2018-04-02 09:46:21 -07:00
6ac687790c
populate_db: Remove the `test_suite` check for custom profile fields.
...
To ensure that we have some basic data for custom profile settings,
in the `populate_db` data set, remove `options['test_suite']` check
for adding intial custom profile data.
2018-03-21 16:05:31 -07:00
e2a6541133
i18n: Fix use of 'realm administrator' in translated strings.
...
These are user-facing and thus should refer to being an "organization
administrator".
2018-03-07 17:15:29 -08:00
4f5b1c0a5a
zerver/tests: Use python 3 syntax for typing in most files.
2017-11-16 21:52:01 -08:00
1e87a4b68c
zerver/tests: Remove absolute_import.
2017-09-27 10:00:39 -07:00
2f4091b38d
api: Fix caps in JSON validation error message.
2017-06-27 08:33:56 -04:00
6c3f89af1c
tests: Remove get_user_profile_by_email from numerous tests.
2017-05-24 15:19:20 -07:00
e8eaec0a18
mypy: Fix various errors caught by removing cache_with_key.
2017-05-10 14:37:20 -07:00
942db9b6c5
tests: Added ZulipTestCase.example_user() function.
...
The example_user() function is specifically designed for
AARON, hamlet, cordelia, and friends, and it allows a concise
way of using their built-in user profiles. Eventually, the
widespread use of example_user() should help us with refactorings
such as moving the tests users out of the "zulip.com" realm
and deprecating get_user_profile_by_email.
2017-05-08 11:57:38 -07:00
8f5dfffe39
testing: Fix test_update_invalid_value.
...
This test was using hardcoded field id which made it order dependent.
2017-04-18 21:46:14 -07:00
cf3b6c6ca9
profile: Support custom profile data.
...
Implements backend for #1760 .
2017-04-18 15:20:59 -07:00
Steve Howell
Hemanth V. Alluri
Mateusz Mandera
Yashashvi Dave
neiljp (Neil Pilgrim)
Rishi Gupta
Anders Kaseorg
Anders Kaseorg
Aditya Bansal
Tim Abbott
Angelika Serwa
Umair Khan
rht
Yago González
Andrew Archer
Steve Howell