fead14951c
python: Convert assignment type annotations to Python 3.6 style.
...
This commit was split by tabbott; this piece covers the vast majority
of files in Zulip, but excludes scripts/, tools/, and puppet/ to help
ensure we at least show the right error messages for Xenial systems.
We can likely further refine the remaining pieces with some testing.
Generated by com2ann, with whitespace fixes and various manual fixes
for runtime issues:
- invoiced_through: Optional[LicenseLedger] = models.ForeignKey(
+ invoiced_through: Optional["LicenseLedger"] = models.ForeignKey(
-_apns_client: Optional[APNsClient] = None
+_apns_client: Optional["APNsClient"] = None
- notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- signup_notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ signup_notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- author: Optional[UserProfile] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
+ author: Optional["UserProfile"] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
- bot_owner: Optional[UserProfile] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
+ bot_owner: Optional["UserProfile"] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
- default_sending_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
- default_events_register_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_sending_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_events_register_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
-descriptors_by_handler_id: Dict[int, ClientDescriptor] = {}
+descriptors_by_handler_id: Dict[int, "ClientDescriptor"] = {}
-worker_classes: Dict[str, Type[QueueProcessingWorker]] = {}
-queues: Dict[str, Dict[str, Type[QueueProcessingWorker]]] = {}
+worker_classes: Dict[str, Type["QueueProcessingWorker"]] = {}
+queues: Dict[str, Dict[str, Type["QueueProcessingWorker"]]] = {}
-AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional[LDAPSearch] = None
+AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional["LDAPSearch"] = None
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-22 11:02:32 -07:00
1cf63eb5bf
python: Whitespace fixes from autopep8.
...
Generated by autopep8, with the setup.cfg configuration from #14532 .
I’m not sure why pycodestyle didn’t already flag these.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-21 17:58:09 -07:00
e03176b272
help: Add doc for setting profile picture back to gravatar.
2020-04-16 20:27:52 -07:00
c734bbd95d
python: Modernize legacy Python 2 syntax with pyupgrade.
...
Generated by `pyupgrade --py3-plus --keep-percent-format` on all our
Python code except `zthumbor` and `zulip-ec2-configure-interfaces`,
followed by manual indentation fixes.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 16:43:22 -07:00
d2fa058cc1
text: Fix some typos (most of them found and fixed by codespell).
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-03-27 17:25:56 -07:00
e257253e64
emoji_codes: Replace JS module with JSON module.
...
webpack optimizes JSON modules using JSON.parse("{…}"), which is
faster than the normal JavaScript parser.
Update the backend to use emoji_codes.json too instead of the three
separate JSON files.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-12 10:09:12 -08:00
df5345705c
import: Support importing team icon from slack.
2020-02-03 14:09:05 -08:00
122e11c678
slack import: Fix handling of messages sent by user U00.
2020-01-25 22:47:49 -08:00
e052ec58db
slack import: Improve error messages around invalid tokens.
...
This updates our error handling of invalid Slack API tokens (and other
networking error handling) to mostly make sense:
* A token that doesn't start with `xoxp-` gives an extended error early.
* An AssertionError for the codebase is correctly declared as such.
* We check for token shape errors before querying the Slack API.
We could still do useful work to raise custom exception classes here.
Thanks to @stavrospat for raising this issue.
2020-01-22 14:48:32 -08:00
6945ced76f
slack import: Map Slack guest users to Zulip guests.
...
Slack's Single-User Guest and Multi-User Guest users should be
imported as Zulip guests during data import.
Fixes #13255 .
2019-11-12 12:12:59 -08:00
aad99ce951
mattermost import: Fix handling of channels with no subscribers.
...
Previously, we skipped setting the list of subscribers to the channel,
which could result in problems if any messages had been posted there
in the past (e.g. because the channel used to have members, but now
doesn't). It could be correct to skip importing dead channels
altogether, but probably simpler is to just set an empty subscriber list.
2019-11-04 18:10:37 -08:00
dc682da47a
mattermost: Handle replies to private messages.
...
Previously, our logic to handle Mattermost's "replies" feature didn't
copy the right fields for private messages, where `channel_members` is
included on the message body rather than a `channel` name.
2019-11-04 18:10:37 -08:00
1585ad7bf4
mattermost: Add support for exporting DMs and huddles.
2019-10-10 16:37:03 -07:00
e10361a832
models: Replace is_guest and is_realm_admin with UserProfile.role.
...
This new data model will be more extensible for future work on
features like a primary administrator.
2019-10-06 16:24:37 -07:00
dbe508bb91
models: Migration of Message.pub_date to date_sent, part 2.
...
Fixes #1727 .
With the server down, apply migrations 0245 and 0246. 0246 will remove
the pub_date column, so it's essential that the previous migrations
ran correctly to copy data before running this.
2019-10-05 19:01:34 -07:00
a21856c569
mattermost: Rename user_id to sender_user_id in process_raw_message_batch.
2019-09-25 20:06:47 +05:30
23d70bb685
mattermost: Rename get_recipient_id to get_recipient_id_from_receiver_name.
2019-09-25 20:06:04 +05:30
c4af0b7bc4
mattermost: Support importing messages without team name.
...
Mattermost doesn't place private messages within a particular team,
which is what this is needed for.
2019-09-18 11:57:37 -07:00
bf5f531e90
import_util: Support huddles in SubscriberHandler.
2019-09-18 11:53:13 -07:00
d434c0ee88
slack: Remove unnecessary comments.
...
Remove comments that tries to explain code that is already readable.
Also remove some todo comments that has been already taken care of.
2019-08-26 14:10:19 -07:00
99d34fd11d
slack: Rename default_channels to slack_default_channels.
2019-08-26 14:10:19 -07:00
b919514f7f
slack: Rename customprofilefield_id to custom_profile_field_id.
2019-08-26 14:10:19 -07:00
c31355f9c1
slack: Rename custom_field_id_count to custom_profile_field_value_id_count.
2019-08-26 14:10:19 -07:00
138c659c97
slack: Rename slack_custom_field_name_to_zulip_custom_field_id.
...
Rename custom_field_map to
slack_custom_field_name_to_zulip_custom_field_id.
2019-08-26 14:10:19 -07:00
9560736d86
slack: Rename slack_user_id_to_custom_profile_fields.
...
Renames slack_user_custom_field_map to
slack_user_id_to_custom_profile_fields for readability.
2019-08-26 14:10:19 -07:00
01a51c8f4e
slack: Rename added_recipient to slack_recipient_name_to_zulip_recipient_id.
2019-08-26 14:10:19 -07:00
9d51a1b527
slack: Rename added_users to slack_user_id_to_zulip_user_id.
2019-08-26 14:10:19 -07:00
3650f19692
slack: Lookup dir_name key in dict instead of in dict_keys.
...
No reason to do the lookup in O(n) when we can do
it in average O(1) time complexity.
2019-08-26 14:10:19 -07:00
1e5c49ad82
slack: Support importing shared channels.
2019-08-26 14:10:19 -07:00
e09a29f4d3
slack: Refactor get_slack_api_data to accept multiple query params.
2019-08-26 14:10:19 -07:00
69505c30a4
mattermost: Handle users who aren't on any team correctly.
...
It's not clear to me how this is intended to work in Mattermost's
system in that they don't document this behavior, but some users have
`null` as their list of teams, and presumably are not meant to be
included in any team at all.
2019-08-19 16:06:39 -07:00
e417d3a040
slack_message_conversion: Clean up type ignores.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-08-09 16:39:16 -07:00
9827801569
slack import: Improve readability of user recipient object allocation.
...
This loop management tweak makes it a bit more obvious what's
happening in this block of code.
2019-07-30 14:46:14 -07:00
ff3871fc63
slack_import: Clean up return values of channels_to_zerver_stream.
...
This commits reduces the number of values returned by
channel_to_zerver_stream function by setting the values
directly in realm dict and returning it instead.
2019-07-30 14:46:14 -07:00
6110f495df
slack_import: Support importing pms.
2019-07-30 14:46:14 -07:00
5e6d86c8c4
slack_import: Support importing multiparty IMs.
2019-07-09 15:03:28 -07:00
443439d388
slack_import: Support importing private slack channels.
2019-06-28 11:03:32 -07:00
196388cee3
slack_import: Extract processing channels into a seperate function.
2019-06-28 11:00:59 -07:00
55bf44152a
import: Handle hidden_by_limit case for files in slack import.
...
Fixes #12011
2019-05-30 12:01:09 -07:00
643bd18b9f
lint: Fix code that evaded our lint checks for string % non-tuple.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-04-23 15:21:37 -07:00
02c92e55a2
import: Add tool for importing teams from mattermost.
2019-04-05 17:53:03 -07:00
f517f72dd2
import: Make use of is_mirror_dummy in build_user_profile.
2019-04-04 13:51:52 -07:00
bd4c3b3ebb
import: Move make_user_messages to import_util.py.
2019-04-04 13:51:52 -07:00
d921fd25e4
import: Move SubscriberHandler to import_util.
2019-03-20 11:29:51 -07:00
6e3720e0b7
gitter: Fix minor comment typo in build_userprofile.
2019-03-20 10:12:18 -07:00
d526ff00f2
settings: Rename "user avatar" to "profile picture"
...
This renames references to user avatars, bot avatars, or organization
icons to profile pictures. The string in the UI are updated,
in addition to the help files, comments, and documentation. Actual
variable/function names, changelog entries, routes, and s3 buckets are
left as-is in order to avoid introducing bugs.
Fixes #11824 .
2019-03-15 13:29:56 -07:00
412d35900f
slack import: Fix handling of tombstone files.
...
Apparently, the mode attribute is not always present.
2019-03-13 14:39:20 -07:00
49680a4503
slack import: Skip processing tombstone files.
...
The tombstone files undocumented feature of Slack's export format
appears sometimes and has no real data, so we just need to skip these.
Fixes #11619 .
2019-03-13 12:43:11 -07:00
cbc62b8e07
streams: Prevent creation of multi-line stream descriptions.
...
We do not anticipate our UI for showing stream descriptions looking
reasonable for multi-line descriptions, so we should just ban creating
them.
Given the frontend changes, multi-line descriptions are only likely to
show up from importing content from other tools, in which case
replacing newlines with spaces is cleaner than the alternative.
2019-02-20 12:28:00 -08:00
e183c316dd
help: Rename help/change-your-avatar to help/set-your-avatar.
2019-02-13 17:50:39 -08:00
Anders Kaseorg
Siddharth Varshney
Stefan Weil
Vishnu KS
Tim Abbott
Tlazypanda
Rishi Gupta
Mateusz Mandera
Ben Muschol