Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
26,946 Commits 28 Branches 143 Tags 606 MiB
Commit Graph

6 Commits

Author SHA1 Message Date
Shubham Dhama dcb6254a4e eslint: Enable `no-extra-parens` rule. 
Following sub-configuration is disabled:
                "nestedBinaryExpressions": false,
 2018-06-11 07:51:24 -04:00
Yashashvi Dave 958040b1fc user_pills: Extract generic functions for typeahead and pill creation. 
This refactoring make it easier to use our user pill typeahead logic
in other parts of the app.

Two commits by Yashasvhi squashed together by Tim.
 2018-05-23 12:07:16 -07:00
Tim Abbott 7ab8a8e820 js: Fix a bunch of indentation issues found by eslint. 
This is preparation for enabling an eslint indentation configuration.
90% of these changes are just fixes for indentation errors that have
snuck into the codebase over the years; the others are more
significant reformatting to make eslint happy (that are not otherwise
actually improvements).

The one area that we do not attempt to work on here is the
"switch/case" indentation.
 2018-05-06 16:25:02 -07:00
Tarun Kumar 5c11ab857e pills: Add exportable function for creating non-editable pills. 2018-04-05 17:40:12 -07:00
Steve Howell 1aba722e63 user_pill: Add Zephyr logic. 
For Zephyr realms we have to be more lax with email validation.

This will be relevant for compose pills.
 2018-03-07 15:53:11 -08:00
Steve Howell f0d101edf5 pills: Streamline input pills (for user groups). 
The main point of this change is to streamline the core
code for input pills, and we use also modify user groups.

The main change to input_pill.js is that you now
configure a function called `create_item_from_text`, and
that can return an arbitrary object, and it just needs
a field called `display_value`.

Other changes:
    * You now call `input.create(opts)` to create the
      widget.
    * There is no longer a cache, because we can
      write smarter code in typeahead `source` functions
      that exclude ids up front.
    * There is no value/optinalKey complexity, because
      the calling code can supply arbitrary objects and
      do their own external data management on the pill
      items.
    * We eliminate `prependPill`.
    * We eliminate `data`, `keys`, and `values`, and just
      have `items`.
 2018-03-07 15:53:11 -08:00