80a2d5bc59
eslint: Enable `conditionalAssign` config of no-trailing-spaces rule.
2018-06-11 07:51:24 -04:00
c6738889a9
eslint: Add and enable `space-unary-ops` rule.
...
Info about rule at https://eslint.org/docs/rules/space-unary-ops .
2018-06-05 00:47:35 +05:30
7ab8a8e820
js: Fix a bunch of indentation issues found by eslint.
...
This is preparation for enabling an eslint indentation configuration.
90% of these changes are just fixes for indentation errors that have
snuck into the codebase over the years; the others are more
significant reformatting to make eslint happy (that are not otherwise
actually improvements).
The one area that we do not attempt to work on here is the
"switch/case" indentation.
2018-05-06 16:25:02 -07:00
e4c50ff4fd
narrow: Remove unnecessary select_first_unread option.
...
We consistently either pass a `then_select_id` into narrow.activate,
or were using the select_first_unread option. Now, we just compute
select_first_unread based on the value of then_select_id.
2018-04-22 21:33:33 -07:00
a46e21ee3e
bankruptcy: Add UI widget to mark all messages as read.
...
This is the natural analog of the similar streams UI feature.
Fixes #7585 .
2018-02-15 18:01:03 -08:00
5e968ce30d
stream_list: Use data-topic-name for topic names.
...
The name data-name was ambigious.
2017-08-16 18:03:44 -07:00
d9dcdbbbe9
stream_popover: Use data-stream-id when building topic popovers.
2017-08-16 18:03:29 -07:00
dbae28683c
stream_popover: Use data-stream-id when building popover.
2017-08-16 18:03:29 -07:00
c6d7cfb60b
stream_popover: Fetch the current stream by data-stream-id.
2017-08-16 18:03:29 -07:00
4acd7595cd
stream_sidebar: Clean up use of ambiguously named data-id.
...
We prefer to specify the type of data objects wherever possible.
2017-08-16 18:02:29 -07:00
78d9fcd23a
streams: Remove a reference to data-stream-name.
2017-08-16 18:02:29 -07:00
842bf77efb
unread: Convert mark_topic_as_read to use stream IDs.
...
This is safer in its handling of potentially renamed streams.
2017-08-15 10:40:02 -07:00
f3a41ac796
unread: Convert mark_stream_as_read to use stream IDs.
...
The logic is simpler and more robust.
2017-08-15 10:40:02 -07:00
32837804d8
Extract stream_popover.topic_ops to muting_ui.js.
2017-03-25 09:42:49 -07:00
faa9446e64
Add compose_actions.start() shim.
2017-03-18 15:52:50 -07:00
a51caceea5
refactor: Extract unread_ops.js
...
This module mostly contains the mark_* functions that
update the server with info about unread counts.
2017-03-18 10:35:52 -07:00
5613358638
stream_popover: Fix hiding topic popover.
2017-03-08 23:25:30 -08:00
1d2c3cec10
Fix: change mobile sidebar click target to call new popover function.
...
This changes the click target that opens the mobile sidebar to call the
new popover function in stream_popover rather than the old popovers
object.
2017-03-08 17:04:10 -08:00
3b59e6c3cc
subs: Rename /#subscriptions to /#streams.
...
Fixes #3653 .
2017-03-08 16:57:58 -08:00
a17deb144a
Use data-stream-id in topics popover.
2017-03-05 15:44:44 -08:00
8e2e406404
refactor: Extract stream_popover.js.
...
This module handles the popovers in the stream list--one for
stream actions and another for topic-specific actions.
The extraction was mostly straightforward, but I did move some
of the code related to the color picker to be more consistent
with how I organized the other click handlers.
2017-03-05 15:44:43 -08:00
Shubham Dhama
Tim Abbott
Vishnu Ks
Joshua Pan
Steve Howell
Brock Whittaker