7bc3fa034e
linter: Add rule to check periods in translatable.
...
Make sure that the periods are part of the translatable strings.
Tweaked by tabbott to properly scope the rules.
2017-03-09 21:57:26 -08:00
4ac5da7860
travis: Run test-tools in Travis CI backend suite.
2017-03-09 20:21:13 -08:00
c5cae34512
tools: Fix test-capitalization dependence on Django.
...
This was a totally unnecessary dependency, and actually broke
test-tools.
2017-03-09 20:21:13 -08:00
32849b80ad
Django 1.10: Url pattern doesn't use _callback_str.
...
Fixes #3941
2017-03-09 00:50:12 -08:00
83dd901ecf
Add capitalization checker tool.
...
Initial rules significantly by modified by tabbott, who also added the
hacky list of excludes that the tool can't handle correctly yet.
Fixes : #3899 .
2017-03-09 00:44:57 -08:00
84d4f62abf
lint: Exclude Acme placeholders from translations.
...
These strings represented a small waste of time for our translators.
2017-03-09 00:38:15 -08:00
8bdbcbc371
lint: Fix unnecessarily translated test file strings.
...
Our linter for translation strings shouldn't check test files, since
then we'll end up translating non-user-facing strings.
So we fix that, and actually add the opposite lint rule.
2017-03-09 00:37:44 -08:00
342a80c3de
lint: Ban use of datetime.(utc)now in Python backend.
...
This may be all we're doing for #3999 , but leaving it open just in
case.
2017-03-08 21:03:27 -08:00
3797fa657e
Change bot domains to string_id.EXTERNAL_HOST.
...
Change applies to both subdomains and non-subdomains case, though we use
just the EXTERNAL_HOST in the non-subdomains case if there is only 1 realm.
Fixes #3903 .
2017-03-08 16:26:13 -08:00
8d936601d3
test-backend: Raise zerver/views/test_upload.py test coverage to 100%.
2017-03-08 11:42:25 -08:00
6a801db1c2
missed-emails-sending: Move email sending to separate queue worker.
...
- Add new 'missedmessage_email_senders' queue for sending missed messages emails.
- Add the new worker to process 'missedmessage_email_senders' queue.
- Split aggregation missed messages and sending missed messages email
to separate queue workers.
- Adapt tests for sending missed emails to the new logic.
Fixes #2607
2017-03-07 20:08:40 -08:00
ea4b9cb609
production-helper: Fix sorting queue workers by name.
...
- Shell command `sort` depends on system locale and
symbol `_` (underscore) is located after letters
in the default locale of Travis instances. Otherwise,
python sorting uses its own symbols ordering and
underscore is located before letters. Changing the
locale for `sort` shell command with adding environment
variable doesn' t work on Travis instances. That's why
It was decided to apply the same sorting command to both
comparing lists.
2017-03-07 20:05:53 -08:00
3127ebfa3b
test-backend: Raise zerver/views/events_register.py test coverage to 100%.
2017-03-07 19:47:16 -08:00
6f0564e9f4
python: Fix remaining bare excepts in codebase.
...
Fixes #2862 .
2017-03-05 16:17:04 -08:00
b6f53d6c14
coverage: bring zerver/lib/validator.py to 100% coverage.
2017-03-05 00:53:27 -08:00
e95f139308
coverage: bring zerver/lib/response.py to 100% coverage.
2017-03-05 00:53:26 -08:00
89decf6ded
coverage: bring zerver/lib/request.py to 100% coverage.
2017-03-05 00:53:26 -08:00
e7ff3415ab
coverage: bring test_helpers.py to 100% coverage.
2017-03-05 00:53:26 -08:00
546fb9199d
coverage: bring test_classes.py to 100% coverage.
2017-03-05 00:53:26 -08:00
e3cfb256dd
coverage: Bring zerver.lib.narrow.py to 100% coverage.
2017-03-05 00:53:26 -08:00
56b1f79fe3
integrations: Fix email integration being listed unconditionally.
2017-03-05 00:53:26 -08:00
5050e42212
test-backend: Document # nocoverage comments.
2017-03-04 23:47:16 -08:00
e7389b4162
test-backend: Require 100% coverage on tests by default.
2017-03-04 23:39:34 -08:00
6c12a49d04
test_auth_backends: Remove now-unnecessary compatibility code.
...
This code was added as part of the Django 1.10 migration to make our
tests work with both Django 1.8 and 1.10. Now that we're on 1.10,
it's no longer required.
2017-03-04 23:38:46 -08:00
39704bac6c
test_bugdown: Remove unused common_bugdown_test.
2017-03-04 23:35:46 -08:00
1a8bc5f383
coverage: Bring test_decorators to 100% coverage.
2017-03-04 23:34:28 -08:00
c73c3c52f8
test_email_mirror: Fix TestCommandMTA.
...
The test didn't actually use the mock, due to an incorrect import
path.
2017-03-04 23:28:48 -08:00
6ea3a9cb1d
coverage: Bring test_templates.py to 100% coverage.
2017-03-04 23:28:48 -08:00
d8171b2efc
coverage: Bring tests.py to 100% coverage.
2017-03-04 23:17:36 -08:00
768307d921
coverage: Bring test_events to 100% coverage.
2017-03-04 23:12:32 -08:00
538570b7c1
test_subs: Bring to 100% test coverage.
2017-03-04 23:07:56 -08:00
065651b4fe
coverage: Exclude uncovered lines in test_signup.
2017-03-04 23:01:50 -08:00
ff9f827c9a
coverage: Don't require coverage in six.PY2/PY3 branches.
2017-03-04 22:51:35 -08:00
5ee33e59b8
coverage: Don't require coverage for NotImplementedErrors.
2017-03-04 22:48:21 -08:00
401ae3db97
coverage: Don't complain about if False coverage.
...
This fixes a test failure on master.
2017-03-04 22:48:14 -08:00
bc0cd7eb90
coverage: Move coverage config to tools/coveragerc.
2017-03-04 22:48:05 -08:00
63664264b8
test-backend: Disable verbose coverage display.
2017-03-04 22:48:05 -08:00
e150640ddd
lint: Add lint rule for loading external scripts.
...
This is a common mistake (I'll add documentation on why in the next
commit), and this is a great hook for sending folks to the
documentation on our frontend build process.
2017-03-04 20:42:47 -08:00
d25bfb88d3
lint: Ban importing zerver.models in database migrations.
...
This doesn't work correctly, but in a subtle way.
2017-03-04 17:32:48 -08:00
a3a03bd6a5
mypy: Added Dict, List and Set imports.
...
Fixed mypy errors associated with the upgrade.
2017-03-04 14:33:44 -08:00
2bbfdeeb7b
Fix more errors caught by mypy 0.501.
...
Another set of relatively easy to review changes.
2017-03-03 14:15:38 -08:00
28d3af0965
Fix several new errors caught by mypy 0.501.
...
Clear out a bunch of easy to review errors, so we can focus on the more
complicated ones.
2017-03-03 14:12:52 -08:00
521e8700d7
emoji: Update NotoColorEmoji emoji set.
...
Update the existing NotoColorEmoji set to include emoji additions
like gendered professions, rainbow flag, single parent families etc.
Fixes : #3861 .
2017-03-02 19:07:34 +05:30
d90f7c72a3
zephyr: Fix broken postgres regular expression logic and add tests.
...
Like many rare-case code with new tests, it turns out that the logic
for handling null characters in our Zephyr postgres query escaping
never worked, in multiple ways. First, it always changed the second
character in s, not the current one being inspected, and second, the
value it replaced it with was no the correct postgres escape of the
null byte. We fix this and add tests.
This completes the effort to get zerver/views/messages.py to 100%
test coverage.
Fixes #1006 .
2017-03-01 10:38:48 -08:00
b0f53fd1a8
check-templates: Check left and right sidebars.
2017-03-01 09:08:09 -08:00
0712926b84
templates: Rename right-sidebar.html to right_sidebar.html.
2017-03-01 09:02:15 -08:00
748ec32349
templates: Rename left-sidebar.html to left_sidebar.html.
2017-03-01 09:00:51 -08:00
7fb406b889
lint: Expand lint check for use of .text() without i18n.
...
Fixes #3705 .
2017-02-28 20:37:52 -08:00
d9ef6281fa
lint: Clean json_error/JsonableError lint exceptions.
...
We primarily need to be checking for literal strings being passed in
without i18n tags, not for code that passes a constructed value in.
2017-02-28 20:26:18 -08:00
7ed10da4ad
test-backend: Raise zerver/views/report.py test coverage to 100%.
2017-02-28 20:06:00 -08:00
Umair Khan
Tim Abbott
Rishi Gupta
Elliott Jin
K.Kanakhin
sinwar
Raghav Jajodia
Harshit Bansal