b292c30d6a
subs: Move comment about live update for stream names in navbar.
...
A comment about the difficulties relating to live updating stream
names in the navbar was incorrectly placed within the function for
live updating stream descriptions in
023187b3f1
2020-06-10 14:25:18 -07:00
f0d8f60b66
help: Add basic documentation of organization owners.
2020-06-10 14:07:46 -07:00
94d0c330e4
management: Display organization owners in show_admins.
2020-06-10 14:07:38 -07:00
22a188f12e
migration: Add migration to set all realm admins as realm owners.
...
This migration is added to set all the realm admins as realm owners
and also creates RealmAuditLog entries for modified users.
2020-06-10 14:07:38 -07:00
5cc937f670
events: Add 'is_owner' to page_params and raw_users dict of page_params.
...
This commit adds 'is_owner' field to page_params and also to the
raw_users dict of page_params.
2020-06-10 14:07:38 -07:00
6d667dbe53
realm owner: Add ability to change realm owner status of user.
...
This commit adds some basic checks while adding or removing
realm owner status of a user and adds code to change owner
status of a user using update_user_backend.
This also adds restriction on removing owner status of the
last owner of realm. This restriction was previously on
revoking admin status, but as we have added a more privileged
role of realm owner, we now have this restriction on owner
instead of admin.
We need to apply that restriction both in the role change code path
and the deactivate code path.
2020-06-10 12:49:37 -07:00
2c8c641556
realm owner: Make first user as realm owner on realm creation.
...
This commit sets the role of the user creating the realm as
realm owner after the realm is created.
Previously, the role of user creating the realm was set as admin.
But now we want it to be owner because owners have the highest
privilege level.
2020-06-10 12:44:52 -07:00
451ea753a2
settings_users: Simplify get_item function.
2020-06-10 12:14:58 -07:00
6f159ce5c5
templates: Clean up wording around topic moves.
...
This switches us to cleaner, simpler labels for moving topics; while
also avoiding claiming that we're only allowing moving topics to other
streams.
2020-06-10 12:12:17 -07:00
26083e4b10
popovers: Improve label for choosing colors.
2020-06-10 09:55:51 -07:00
7585776c76
stream_header: Fix broken header color and outflowing boundary.
...
The stream header was moved below the selection option and the
boundary selection input was overflowing, both were fixed via
this commit.
2020-06-10 09:50:49 -07:00
5837560a82
dev_settings: Use Python 2-compatible annotation.
...
This file is imported from zthumbor.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-10 02:11:55 -07:00
3de3386c21
Revert "dev_settings: Deduplicate DEPLOY_ROOT definition."
...
This reverts commit b8acd82b72
2020-06-10 02:11:00 -07:00
d3e8af4ad2
python: Replace silly uses of filter().
...
The test_management_commands use in particular was causing pickling
errors when the test failed, because Python 3 filter returns an
iterator, not a list.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 23:31:59 -07:00
5c9d56d2f7
get_safe_redirect_to: Remove incorrect allowed_hosts setting.
...
set(redirect_host) is a set of characters, so the only non-relative
redirects being allowed were to certain one-character hostnames, which
certainly isn’t what was intended.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:51:52 -07:00
3decbd1e23
lint: Remove settings exemption for possibly undefined star imports.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:29:50 -07:00
3a15e4b51d
settings: Extract most of test_settings to test_extra_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:29:50 -07:00
5546762bd9
settings: Extract computed settings to computed_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:29:50 -07:00
826ca3bfdf
settings: Move LDAP_DEACTIVATE_NON_MATCHING_USERS default to default_settings.
...
Tweaked by tabbott to fix an incorrect translation to ONLY_SSO.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:27:55 -07:00
24d320f245
dev_settings: Move prod_settings_template import to configured_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:20:42 -07:00
34b03dcf8a
settings: Move DEBUG default to default_settings.
...
This is overridden in the prod_settings_template.py generated by
build-release-tarball.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:20:42 -07:00
c45962785c
settings: Group {default,prod,dev}_settings as configured_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:20:42 -07:00
18eba18df7
settings: Move bot email defaults to default_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
8ba25960e7
settings: Move NAGIOS_BOT_HOST default to default_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
92a58e9ce0
settings: Move IS_DEV_DROPLET default to default_settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
9824405842
dev_settings: Set ZULIP_ADMINISTRATOR.
...
Fixes this error in the dev environment:
$ ./manage.py checkconfig
Error: You must set ZULIP_ADMINISTRATOR in /etc/zulip/settings.py.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
b8acd82b72
dev_settings: Deduplicate DEPLOY_ROOT definition.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
59dec63da3
settings: Remove unused slack_importer_test_settings.
...
Commit 3ebd30120c#8345 ) removed the
corresponding test.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
9cb6a75da5
docs: Fix location of default settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
a7a207d5d9
docs: Add missing code markers to settings.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 22:15:34 -07:00
9b9154be91
recent_topics: Set focus on input element on launch.
2020-06-09 22:08:31 -07:00
ec00e39e45
recent_topics: Fix misplaced thead border and adjacent css properties.
2020-06-09 22:08:31 -07:00
e5e02319b4
recent_topics: Show msg if no topics are visible.
2020-06-09 22:08:31 -07:00
ad2e7026c8
recent_topics: Add functionality to sort rows via header.
...
Add custom sorting for stream and topic headers.
2020-06-09 22:08:31 -07:00
084cbd4ff7
recent_topics: Use list_render to display topic rows.
...
This fixes the laggy behaviour when there are 2k+ rows to processes,
since list_render uses lazy render based on what rows are visible
to the user.
2020-06-09 22:08:31 -07:00
0aeadd2c86
recent_topics: Set 'unread' and 'participated' as default filters.
...
Decided after a poll on czo.
2020-06-09 22:08:31 -07:00
33ace41ffe
recent_topics: Add filter button to show muted topics.
...
We don't show muted streams/topics by defualt. Only when user
turns on muted filter.
2020-06-09 22:08:31 -07:00
89fe133d2d
recent_topics: Add button to clear search.
2020-06-09 22:08:31 -07:00
9f50825610
recent_topics: Only rerender when recent_topics is visible.
...
We update the data in the background but only update the view
when recent topics is visible to user.
Also, we always do a complete rerender on launch.
2020-06-09 22:08:31 -07:00
e8cc9da4c7
recent_topics: Don't complete_rerender on filter change.
...
We store the relevant data to hide/show a topic in the row itself,
and use jquery to hide/show it on filter change.
This also fixes search breaking the set filters.
2020-06-09 22:08:31 -07:00
272a3eed8a
recent_topics: Show unread count after topic name.
...
We remove the non-obvious unread count column and move the unread
counts to be displayed after topic.
2020-06-09 22:08:31 -07:00
e6611089fd
recent_topics: Update stored message id of locally echoed messages.
...
This fixes the bug that message was undefined since we used to store
locally echoed message id and were not updating it after new message
id for the same message was received from the server.
2020-06-09 22:08:31 -07:00
35f584e5ef
recent_topics: Remove old rendered topic row on topic edit.
...
We remove all trace of the old topic and reprocess all the new
messages in old and new topics.
process_topic_edit function was moved since it needs to be below
get_topic_row function.
2020-06-09 22:08:31 -07:00
d8a312eddb
recent_topics: Append proper prefix before stream name.
...
We reuse the existing logic for displaying and updating stream color
from the stream left sidebar.
Tests fixtures were extracted and updated for this commit.
2020-06-09 22:08:31 -07:00
515334dfb2
recent_topics: Extract test fixture into a function.
2020-06-09 22:08:31 -07:00
ee7faf13cc
recent_topics: Show checkbox icons for active filters.
2020-06-09 22:08:31 -07:00
cea3bb437f
recent_topics: Make table headers fixed.
2020-06-09 22:08:31 -07:00
4f1b7542ed
recent_topics: Toggle topic display according to filters.
2020-06-09 22:08:31 -07:00
bc7136590a
recent_topics: Add avatars of recent senders to topic.
2020-06-09 22:08:31 -07:00
bdaf4e1079
recent_topics: Add action to mark topic as read.
2020-06-09 22:08:31 -07:00
YashRE42
Tim Abbott
sahil839
Clara Dantas
Aman Agrawal
Anders Kaseorg