Anders Kaseorg
0fa5e7f629
ruff: Fix UP035 Import from `collections.abc`, `typing` instead.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-07-13 22:28:22 -07:00
Anders Kaseorg
531b34cb4c
ruff: Fix UP007 Use `X | Y` for type annotations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-07-13 22:28:22 -07:00
Anders Kaseorg
e08a24e47f
ruff: Fix UP006 Use `list` instead of `List` for type annotation.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-07-13 22:28:22 -07:00
Anders Kaseorg
45bb8d2580
models: Extract zerver.models.users.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-12-16 22:08:44 -08:00
Tim Abbott
1100d3be51
sessions: Make delete_realm_user_sessions not quadratic.
...
This is exactly the scenario that Set objects exist for.
2023-12-11 14:07:39 -08:00
Zixuan James Li
4a5043dd6e
typing: Add none-checks for miscellaneous cases.
...
Signed-off-by: Zixuan James Li <359101898@qq.com>
2022-05-31 09:43:55 -07:00
Mateusz Mandera
4e1befa209
sessions: Rename get_session_user to get_session_user_id.
...
The function returns a user id, not a user - we generally try to reflect
that in function names accurately.
2022-05-23 15:57:10 -07:00
Mateusz Mandera
66d8c2ae15
sessions: Don't filter by expire_date in delete_realm_user_sessions.
...
The other delete_... functions just do .all() - we should be consistent
one way or another.
2022-05-23 15:57:10 -07:00
Mateusz Mandera
003d086f2e
sessions: Only fetch user ids in delete_realm_user_sessions.
...
No need to fetch entire UserProfiles, especially since we're dealing
with all UserProfiles in a Realm here, which would be quite large.
2022-05-23 15:57:09 -07:00
Anders Kaseorg
a2825e5984
python: Use Python 3.8 typing.{Protocol,TypedDict}.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
PIG208
442adfaff3
sessions: Use SessionBase instead of Session.
2021-07-24 09:54:21 -07:00
Anders Kaseorg
6e4c3e41dc
python: Normalize quotes with Black.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
Anders Kaseorg
11741543da
python: Reformat with Black, except quotes.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 13:11:19 -08:00
Anders Kaseorg
8a7cfd05a1
sessions: Fix type: ignore issues.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-30 18:58:23 -07:00
Anders Kaseorg
1ed2d9b4a0
logging: Use logging.exception and exc_info for unexpected exceptions.
...
logging.exception() and logging.debug(exc_info=True),
etc. automatically include a traceback.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-14 23:27:22 -07:00
Anders Kaseorg
365fe0b3d5
python: Sort imports with isort.
...
Fixes #2665 .
Regenerated by tabbott with `lint --fix` after a rebase and change in
parameters.
Note from tabbott: In a few cases, this converts technical debt in the
form of unsorted imports into different technical debt in the form of
our largest files having very long, ugly import sequences at the
start. I expect this change will increase pressure for us to split
those files, which isn't a bad thing.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-11 16:45:32 -07:00
Anders Kaseorg
bdc365d0fe
logging: Pass format arguments to logging.
...
https://docs.python.org/3/howto/logging.html#optimization
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-02 10:18:02 -07:00
Anders Kaseorg
f8c95cda51
mypy: Add specific codes to type: ignore annotations.
...
https://mypy.readthedocs.io/en/stable/error_codes.html
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-22 10:46:33 -07:00
Mateusz Mandera
fe33966642
sessions: Implement the concept of expirable session variables.
...
This can be useful in the future for various things, and right now it'll
specifically be used in the signup mobile/desktop flows.
2020-02-12 11:09:55 -08:00
Tim Abbott
6618cec9db
logging: Switch various logging code paths to use user IDs.
...
This fixes EMAIL_ADDRESS_VISIBILITY_ADMINS support as well as being
more reliable/stable over time.
2019-11-15 17:24:01 -08:00
Anders Kaseorg
becef760bf
cleanup: Delete leading newlines.
...
Previous cleanups (mostly the removals of Python __future__ imports)
were done in a way that introduced leading newlines. Delete leading
newlines from all files, except static/assets/zulip-emoji/NOTICE,
which is a verbatim copy of the Apache 2.0 license.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-08-06 23:29:11 -07:00
Tim Abbott
5696ad5490
sessions: Suppress coverage error until we can debug.
2018-12-01 10:08:57 -08:00
Tim Abbott
18e2118fc8
Revert "sessions: Stop using the cached_db sessions engine."
...
This reverts commit 2fa77d9d54
.
Further investigation has determined that this did not fix the
password-reset problem described in the previous commit message;
meanwhile, it causes other problems. We still need to track down the
root cause of the original password-reset bug.
2018-11-30 15:54:32 -08:00
Tim Abbott
67c3593b39
sessions: Add coverage exception for now.
2018-11-14 15:28:35 -08:00
Aditya Bansal
1f9244e060
zerver/lib: Change use of typing.Text to str.
2018-05-10 14:19:49 -07:00
rht
33b1a541d7
zerver/lib: Use python 3 syntax for typing.
...
With tweaks by tabbott to fix line spacing.
2017-11-18 16:09:04 -08:00
rht
f43e54d352
zerver/lib: Remove absolute_import.
2017-09-27 10:00:39 -07:00
neiljp (Neil Pilgrim)
a6bb8f552b
mypy: Mark get_session_user() as returning Optional[int].
2017-08-09 18:04:21 -07:00
Aditya Bansal
df2b49af66
pep8: Add compliance with rule E261 to sessions.py.
2017-05-07 23:21:50 -07:00
hackerkid
b2504084ab
Replace timezone.now with timezone_now.
2017-04-16 12:28:56 -07:00
Tim Abbott
a55381b397
sessions: Fix missing typing imports.
2017-03-08 03:00:05 -08:00
Tim Abbott
ca50e10569
sessions: Move session deletion code to sessions.py.
...
This new organization feels more thematically appropriate, and of
course shrinks the amount of stuff unnecessarily in actions.py
2017-03-08 02:48:18 -08:00
Tim Abbott
fe237118b0
Rename zerver/lib/session_user.py to sessions.py.
2017-03-08 02:43:35 -08:00