Umair Khan
0d296afa54
github: Return '' when name is None.
2017-03-15 11:11:09 -07:00
Umair Khan
e44e58f6d5
logging: Skip log records originated in site packages.
...
This fixes the huge exception we get in our logs from django.template
logger. This exception is a known bug in Django, see
https://code.djangoproject.com/ticket/26886
Fixes #3974
2017-03-15 11:07:31 -07:00
Cynthia Lin
902207da71
node: Update package.json to eliminate vulnerable dependecies.
2017-03-14 18:21:00 -07:00
Brock Whittaker
c155577246
Allow users to resize the message compose box.
...
This allows for users to resize the message compose box without it
collapsing back down to jQuery autosize’s preferred height.
When you hide the compose box and then re-show it, it keeps the
previous height but reactivates the jQuery module.
Fixes : #2236 .
2017-03-14 17:40:21 -07:00
Rishi Gupta
af4718c50c
retention.py: Remove use of domain from get_expired_messages.
...
get_expired_messages seems to only be used by tests anyway.
2017-03-14 17:17:42 -07:00
Rishi Gupta
92dd767519
management commands: Change help text to say realm instead of domain.
2017-03-14 17:17:42 -07:00
Rishi Gupta
0c032adbde
create_realm.py: Remove --domain option.
...
Realm domains can now be managed via Admin Settings in the web app.
2017-03-14 17:17:42 -07:00
Rishi Gupta
4627ff1b4b
zproject: Change comments to refer to Realm.string_id instead of domain.
2017-03-14 17:17:42 -07:00
Rishi Gupta
ba228b75b1
zilencer: Use Realm.string_id for get_deployment_from_domain.
...
This is dead code. Getting rid of realm__domain since we're about to remove
that field from Realm.
2017-03-14 17:17:42 -07:00
Rishi Gupta
8fecd454aa
forms.py: Remove unused function get_registration_string(domain).
2017-03-14 17:17:42 -07:00
Rishi Gupta
ddd0b854f9
Remove references to page_params.domain.
...
Continuation of 098797c
, which removed the page_params.domain field.
2017-03-14 17:17:42 -07:00
Tim Abbott
e7b3ea8fab
coverage: Require 100% coverage in analytics.
2017-03-14 17:11:25 -07:00
Tim Abbott
85fe53f5e3
coverage: Don't require test coverage for __unicode__ methods.
...
These are usually just used for manual debugging, and so aren't super
important to make sure we have tests for always.
2017-03-14 17:07:18 -07:00
Rishi Gupta
7c6f0033ed
analytics: Add test for do_drop_all_analytics_tables.
2017-03-14 16:59:54 -07:00
Rishi Gupta
87981a2bf1
analytics: Fix direct import of models in migrations.
2017-03-14 16:59:54 -07:00
Rishi Gupta
ebebd04587
analytics: Fix ValueErrors affecting test coverage.
...
Pathways that only catch internal code errors should use AssertionError so
that they are not included when computing test coverage.
2017-03-14 16:59:54 -07:00
Rishi Gupta
b18bfe6771
analytics: Standardize format of zerver count queries.
...
count_message_type_by_user_query is in a different format (no WHERE clause)
from the rest since I'm having a hard time reasoning about how that would
interact with the LEFT JOIN, especially given that there are %(join_args)s.
2017-03-14 16:59:54 -07:00
Rishi Gupta
e33ef1c788
analytics/models: Remove extended_id and key_model.
...
They are unused / were part of a previous design.
2017-03-14 16:59:54 -07:00
Steve Howell
b648c06009
hotkeys/refactor: Extract tab key handlers.
...
This extracts process_tab_key() and process_shift_tab_key().
It also removes some dead code related to alert words tabbing.
2017-03-14 16:42:40 -07:00
Steve Howell
bdbaa5d386
hotkeys: Simplify navigation checks for page up/down.
...
We remove an unnecessary conditional that always returned true
due to checks that happen earlier in the function.
2017-03-14 16:42:40 -07:00
Steve Howell
58c057a024
node tests: Add test_motion_keys().
2017-03-14 16:42:40 -07:00
Steve Howell
2a3e74427b
Export hotkey.tab_up_down() for testing.
2017-03-14 16:42:40 -07:00
Cynthia Lin
7a804de485
user docs: Update *Send a private message*.
...
Add keyboard shortcut info to user doc. Fixes #156
2017-03-14 15:54:20 -07:00
Cynthia Lin
d764f0e0f1
user docs: Update *Send a stream message*.
...
Add keyboard shortcut info to user doc.
2017-03-14 15:54:20 -07:00
Cynthia Lin
6deee116dc
user docs: Update *Enable or disable pressing enter to send*.
...
Add keyboard shortcut info to user doc.
2017-03-14 15:54:20 -07:00
Cynthia Lin
f510ada67a
templates: Add insert new line shortcut to *Keyboard shortcuts* modal.
2017-03-14 15:54:20 -07:00
Tim Abbott
87dd0c225a
keyboard_shortcuts: Move @ near more similar keys.
2017-03-14 15:54:03 -07:00
Abhishek Bhattacharya
8a408a6cbc
popovers: Fix actions popover menu positioning.
...
The main issue is that it wasn't doing the correct comparison; the old
logic that subtracted the viewport.scrollTop() was incorrect for how
our popovers seem to work.
Partially fixes #3741 .
2017-03-14 15:37:37 -07:00
Philip Skomorokhov
e3fa42f833
edit: Hide emoji reactions when in message edit or view source mode.
...
This also entails displaying them when the editing mode ends.
Fixes #3870 .
2017-03-14 14:55:16 -07:00
adnrs96
dd52291fa5
linter: Add support for automatic checking for 4 space indents in HTML.
2017-03-14 14:50:16 -07:00
Brock Whittaker
11c7bb49d4
Restyle "invite" modal.
...
This restyles the invite modal to have the same header as the rest of
the overlays.
2017-03-14 14:47:12 -07:00
Brock Whittaker
4c4208ac86
Make all modal exit "x" sizes uniform.
...
This makes all exit “x”’s uniformly 1.5rem in size and font-weight: 600.
2017-03-14 14:47:12 -07:00
Raghav Jajodia
b0e2c4ffee
settings: refactor code to hide "Email Change" button.
...
Previously, the code to hide "Change email" button on page load when
email changes are disabled was present in settings.js using jquery to
hide the button. Now, the show/hide is handled in the account-settings handlebars.
2017-03-14 14:43:35 -07:00
Tim Abbott
1b2cbb0b85
casper: Fix incorrect wait condition for realm icons.
...
This wait condition was correct for uploading, but not for deleting.
2017-03-14 14:40:52 -07:00
Tim Abbott
1c2f82f7fd
help: Remove now-unnecessary warning about old messages.
2017-03-14 14:10:08 -07:00
Raghav Jajodia
d21f446083
help: Add user docs for "Prevent change of name" settings.
2017-03-14 14:10:08 -07:00
Raghav Jajodia
ef7e15ee00
admin: Add realm option to prevent users from changing their name.
...
A realm option to prevent users from changing their name is added.
Fixes #3950 .
2017-03-14 14:10:08 -07:00
Raghav Jajodia
dc48b87765
home.py: Fix bug associated with email_changes_disabled.
...
On reloading the page after disabling email changes does not check
the "Prevent users from changing their email address".
Adding realm_email_changes_disabled to page_params_core_fields fixes the problem.
2017-03-14 14:10:08 -07:00
Abhijeet Kaur
c921736db2
contrib bots: Better error handling response in thesaurus.
2017-03-14 13:29:19 -07:00
Abhijeet Kaur
36bbad3c14
contrib bots: john bot can reply back in the same chat.
...
No need to create an extra "VirtualHelp" stream.
2017-03-14 13:29:19 -07:00
Abhijeet Kaur
d90906c521
contrib bots: Edit code for uniformity.
...
Add one function (get_bot_botname_response()) that generates response
from the given input and replies back to the handle_message with the final
content of response to be sent. Also add code to bots(except followup) to
reply to private messages along with stream messages.
2017-03-14 13:29:19 -07:00
Abhijeet Kaur
57d026f4c9
contrib bots: Rename bots to follow a consistent pattern.
...
Files renamed with few changes to accomodate the change in
path name of files. Fix few "at-mention bot" errors in docs.
2017-03-14 13:29:19 -07:00
Abhijeet Kaur
6e28bc20c6
contrib bots: Rename bots to follow a consistent pattern.
...
Files renamed without any changes.
2017-03-14 13:29:19 -07:00
Abhijeet Kaur
1a23b218e0
contrib-bots: Update .gitignore to ignore database file.
2017-03-14 13:29:19 -07:00
wizsid11
f066e3e8d6
git integrations: Change the limit of shown commits from 10 to 20.
2017-03-14 13:24:45 -07:00
Umair Khan
cdb07c7005
Fix test_get_old_messages_with_narrow_pm_with.
...
Fixes #3940 .
2017-03-14 09:38:24 -07:00
Umair Khan
7b1742fdef
send_message: Allow message to be sent to a huddle.
2017-03-14 09:35:08 -07:00
Steve Howell
1e5ec689b7
tools/css: Trim whitespace around CSS values.
2017-03-14 09:29:56 -07:00
Steve Howell
2ffea94bd8
tools/css: Require semicolons after CSS declarations.
2017-03-14 09:29:56 -07:00
Tim Abbott
a1d7e1b5f6
css: Tweak padding around code blocks to look nicer.
...
It makes sense to a bit tighter padding around code blocks in a chat context.
2017-03-13 22:35:00 -07:00