44d6123c26
settings/scss: Nest `.user-group` inside `#user-groups`.
2019-08-16 10:46:12 -07:00
df31238fb7
settings/scss: Make `#user-groups .user-group` rules at same place.
2019-08-16 10:46:12 -07:00
66649d84cb
puppet: Reload postfix on /etc/postfix/virtual changes.
...
`/etc/postfix/virtual` is of `regexp:` type, not `hash:` type, so
running `postmap` on it has no effect; we need to reload Postfix when
it changes.
http://www.postfix.org/DATABASE_README.html#detect
In the interest of forcing a reload now, optimize the regexes by
eliding the unanchored `.*`s at the beginnings and ends.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-08-15 22:45:26 -07:00
0d52d24d64
docs: pip upgrade recommonmark and CommonMark
...
Summary:
- recommonmark: 0.4.0 -> 0.5.0
- CommonMark: 0.5.4 -> 0.9.0
- Fixed links getting their .md file extension cut off
- Supressed 262 new warnings
Details:
Appended #anchors to markdown github links as a workaround to
recommonmark 0.5.0 cutting off the ".md" part from them.
Sphinx build would fail as follows
[documentation_crawler] ERROR: Please check link:
<404 https://github.com/zulip/zulipbot/blob/master/.github/CONTRIBUTING >
<404 https://github.com/zulip/zulip/blob/master/requirements/README >
<404 https://github.com/zulip/python-zulip-api/blob/master/zulip_bots/README >
sphinx build would also log a "WARNING: None:any reference target not found"
for every link ending in .html
So a good temporary solution is to suppress all warnings with the method suggested here:
https://stackoverflow.com/questions/37359407/suppress-warnings-for-unfound-references-with-default-role-any-in-sphinx
A better solution would be to edit all links ending .html and use .md instead;
which would also solve PR #11719 .
Fixes #11395 .
2019-08-15 22:41:40 -07:00
262e5c6400
css: Use SCSS media queries nesting in drafts.scss.
2019-08-15 22:39:39 -07:00
2c4f4b0e38
css: Nest .draft-controls inside .draft-info-box.
2019-08-15 22:39:39 -07:00
ab30295a39
css: Nest .draft-info-box inside .draft-row.
2019-08-15 22:39:39 -07:00
f94f4ac48e
css: Nest .drafts-list inside .drafts-container.
2019-08-15 22:39:39 -07:00
4e7f3eba85
css: Nest .exit-sign inside .exit.
2019-08-15 22:39:39 -07:00
7ed9d10016
css: Nest .exit and .exit-sign inside .drafts-header.
2019-08-15 22:39:39 -07:00
d20204826d
css: Nest .drafts-header inside .drafts-container.
2019-08-15 22:39:39 -07:00
591ebb22bf
css: Use SCSS nesting for .draft- row, info-box and controls.
2019-08-15 22:39:39 -07:00
585b6680ae
css: Reorder drafts.scss so .draft-row are together.
2019-08-15 22:39:39 -07:00
067c9040e7
css: Use SCSS nesting for .drafts- container, header and list.
2019-08-15 22:39:39 -07:00
b940406877
css: Reorder drafts.scss so .drafts-container are in same place.
2019-08-15 22:39:39 -07:00
c6b3d0212d
models: Move some display_recipient code to display_recipient.py.
2019-08-15 17:15:32 -07:00
cb2c9b04b3
generic_bulk_cached_fetch: Only call query_function if necessary.
2019-08-15 17:14:02 -07:00
898bc52538
models: Add bulk_get_huddle_user_ids function.
2019-08-15 17:03:17 -07:00
f70a0bba82
display_recipient: Extract user_profile_to_display_recipient_dict function.
2019-08-15 16:59:28 -07:00
7a433f279a
requirements: Upgrade Django from 1.11.22 to 1.11.23.
2019-08-15 16:56:31 -07:00
693df05ca7
settings_users: Refactor and extract function for last active.
...
This just done to improves code readability and removes some code too.
2019-08-15 16:54:28 -07:00
c0c11fe226
settings_users: Refactor logic for "last active" column in users table.
...
This uses "last_active" attribute of `user` (`item`) object and makes code
much more readable.
2019-08-15 16:54:28 -07:00
a3ef8856a8
settings_users: Add last_active to active_users for "users" table.
...
This is a preliminary step for refactoring the logic for rendering
"last_active" in the users table and later we can use this for sorting the
column.
2019-08-15 16:54:28 -07:00
ba5564fec7
settings_users: Remove `if` condition for showing current user time stamp.
...
It seems `presence.presence_info[item.user_id]` works fine for the current
user as well and there is no need to hardcode extra condition for the
current user.
2019-08-15 16:54:28 -07:00
6b5e98d554
settings_panel_menu: Fix the switching behavior for hidden section panels.
...
For organization settings page there are few sections' panels which are not
visible (unless you click on 'show more') but when we use up-down arrows to
navigate between sections, sections of hidden panels also get visible which
leads to confusion.
Fixes : #13008 .
2019-08-15 16:51:19 -07:00
f7e88fb2c1
css: Add color variables to integrations.scss.
2019-08-15 16:12:15 -07:00
43d11285fa
css: Add background to integrations categories.
2019-08-15 16:12:15 -07:00
da9a092d39
css: Refactor integrations to use SCSS nesting.
...
While refactoring, I tested all the rules and removed the CSS that was
not needed or duplicated.
I removed the `$("#integration-list-link").css('display', 'block');` and
moved it to css because there is no case in which the back link is
hidden.
2019-08-15 16:12:15 -07:00
84e0327d10
integrations: Fix arrangement of left sidebar `back to list` button.
...
I rearranged the elements of the left sidebar in HTML in order to appear
in the order they are displayed and removed the absolute positioning,
because it was not needed if the elements are arranged correctly. I used
`flex` display to arrange them on column.
I removed the styling that positioned the elements absolutely.
Then I tweaked the margins in order to make the elements look good.
Fixes : #12929
2019-08-15 16:12:15 -07:00
d761bbc2ed
node_cache: Remove unused copy_modules parameter.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-08-14 14:39:04 -07:00
61be9fb4bd
puppet: Add Zulip-specific postgres configuration for 10 on Centos.
2019-08-14 14:31:16 -07:00
03fb4b5f90
puppet: Commit an upstream CentOS version of postgres 10 sample config.
2019-08-14 14:31:16 -07:00
27a0e307b6
cache: Fix typing for generic_bulk_cached_fetch.
...
The typing for generic_bulk_cached_fetch is complicated, and was
recorded incorrectly previously for the case where a cache_transformer
function is required. We fix this by adding the new CacheItemT, and
additionally add comments explaining what's going on with these types
for future reference.
Thanks to Mateusz Mandera for raising this issue.
2019-08-14 11:00:40 -07:00
2ada0a9bad
management: Fix password reset emails being sent to deactivated users.
...
Apparently, the filters written for the send_password_reset_email (and
some other management commands) didn't correctly consider the case of
deactivated users.
While some commands, like syncing LDAP data (which can include whether
a user should be deactivated) want to process all users, other
commands generally only want to interact with active users. We fix
this and add some tests.
2019-08-14 10:50:45 -07:00
cbae51db63
settings: Move API key form into its own modal.
...
The modal is rendered dynamically to avoid password managers
inserting passwords into the input field too aggressively.
Fixes #12523 .
2019-08-14 10:50:45 -07:00
75db8fecf8
refactor: Remove redundant dataType option to channel.post().
2019-08-14 10:50:45 -07:00
2e47e35edc
desktop: Update desktop app to v4.0.0.
2019-08-13 12:36:40 -07:00
001ff72861
data exports: Add upload and message limit test.
2019-08-12 19:52:46 -07:00
f623540409
data export: Add UI to trigger data export.
...
This commit serves as the frontend piece for the "public export"
webapp feature.
Fixes : #11930
2019-08-12 18:21:38 -07:00
8ac8247dbe
data export: Add limits on exporting large organizations.
...
It seems possible that attempting to export large organizations could
result in high resource consumption that justifies having a technician
manage the exports manually.
2019-08-12 18:21:09 -07:00
1d63f129bf
data export: Add summary logging of runtime.
...
This should help us investigate cases where this runs a very long
time.
2019-08-12 18:21:08 -07:00
896886b412
realm_export: Add endpoint for export deletion.
2019-08-12 17:51:46 -07:00
777dcdd272
test_realm_export: Clean up export testing.
...
* Added comments.
* Refactored `export_object` to `audit_log_entry`.
* Cleaned up white space.
* Removed uses of `getattr`.
2019-08-12 17:51:46 -07:00
7c118096e7
test_events: Remove print statement from self.client_post.
...
Leftover from prior debugging.
2019-08-12 17:51:46 -07:00
7d178bbb0f
queue_processors: Clean up the extra_data dict code.
...
We don't want to add a `deleted_timestamp` key until
the export is actually deleted.
2019-08-12 17:51:46 -07:00
6f6efa516d
exports: Refactor extra_data to export_data.
2019-08-12 17:51:46 -07:00
7a2a1f29ad
exports: Refactor event_time to export_time timestamp.
...
The time of the event was incorrectly being sent
as a datetime object.
2019-08-12 17:51:46 -07:00
e0cf3d0e76
zerver: Accept HEAD requests wherever GET requests are accepted.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-08-12 16:47:41 -07:00
ead13c11e5
run-dev: Don’t rewrite the Content-Length header.
...
A HEAD response has a Content-Length but no body; it’s not correct in
that case to let Tornado default Content-Length to 0.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-08-12 16:47:41 -07:00
d425ab5ae5
test_templates: Add a verbose error messages for rendering failures.
...
If a template fails to render in test_templates because of a missing
context variable, we should better explain the reason for the failure.
2019-08-12 16:24:08 -07:00
Pragati Agrawal
Anders Kaseorg
David Rosa
Vaibhav
Mateusz Mandera
Vishnu KS
Alexandra Ciobica
rht
Tim Abbott
Thomas Ip
Akash Nimare
Wyatt Hoodes
Hemanth V. Alluri