06d8e6dfd5
reactions: Refactor add_clean_reactions to make_clear_reaction.
...
This is a pure code refactor for readability.
Previously, we were relying on there being a side effect to
add_clean_reaction which was necessitated by the presence of an output
parameter, `message` (or more specifically `message.clean_reaction`).
Output parameters are confusing.
Hence, this commit changes to have a make_clean_reaction function that
returns a reaction.
2021-12-28 11:11:51 -08:00
0b0637de78
reactions: Remove `export` from add_clean_reaction() function.
...
This function is not called by any external files or tests.
2021-12-28 11:11:43 -08:00
1dffad98fa
reactions: Use parameter destructuring in insert_new_reaction.
...
This is a pure code refactor for readability.
2021-12-28 11:11:39 -08:00
0438ed5777
reactions: Use parameter destructuring in update_existing_reaction.
...
This is a pure code refactor for readability.
2021-12-28 11:11:37 -08:00
0991ed4526
reactions: Use parameter destructuring in view.remove_reaction.
...
This is a pure code refactor for readability.
2021-12-28 11:11:31 -08:00
aa18e797a8
test_event_queue: Generalize some helpers.
...
This will later allow us to also use these when
writing new tests for bots.
2021-12-28 10:59:04 -08:00
acdce4df47
actions: Fix misleading comment about wildcard mentions.
...
Having the `wildcard_mentions_notify` setting turned on does
not necessarily mean that the user will receive notification
for that message. There is more nuance to this, as explained
in the updated comment.
2021-12-28 10:58:54 -08:00
2393342e03
webhooks/jira: Handle anomalous payloads properly.
...
We recently ran into a payload in production that didn't contain
an event type at all. A payload where we can't figure out the event
type is quite rare. Instead of letting these payloads run amok, we
should raise a more informative exception for such unusual payloads.
If we encounter too many of these, then we can choose to conduct a
deeper investigation on a case-by-case basis.
With some changes by Tim Abbott.
2021-12-28 10:56:25 -08:00
c5c3ab66d6
remote_server: Migrate RemoteZulipServer.uuid to be UUIDField.
...
Given that these values are uuids, it's better to use UUIDField which is
meant for exactly that, rather than an arbitrary CharField.
This requires modifying some tests to use valid uuids.
2021-12-28 10:11:34 -08:00
e48120fd12
remote_server: Validate zulip_org_id submitted by registering server.
...
zulip_org_id is supposed to be a UUID, so we want to actually validate
the format, not only check the length.
2021-12-28 10:11:34 -08:00
42dd58cffe
docs: Fix a few typos in documentation.
2021-12-28 09:36:59 -08:00
d62b39450e
performance: Optimize send_subscription_add_events.
...
We avoid repeating the same calculations over and
over again for the same stream.
This helps, but the real bottleneck in this function
is that send_event usually takes at least a millisecond,
and that adds up quickly if you're doing something
like subscribing 5k users to a new stream.
2021-12-28 09:33:16 -08:00
bc69f213a0
requirements: Upgrade Python requirements.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
60eed65832
scim: Placate mypy 0.930.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
c8dd90f32b
bot_config: Placate mypy 0.930.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
575932f4e0
actions: Placate mypy 0.930.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
95cddff39b
test_scim: Placate mypy 0.930.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
b73a6b7b06
test_stripe: What even is how to code I don’t know help.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
f45b245f74
test_urls: Fix get_callback_string logic.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
48190cf744
test_timezone: Fix ambiguous_abbrevs type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
c4c28e06d9
test_openapi: Replace convert_regex_to_url_pattern.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
e3a8f992d5
test_openapi: Fix __wrapped__ accesses.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
d40f3d54f1
test_console_output: Implement the entire TextIO contract.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
702ce071f4
python: Accept Optional[FrameType] in signal handlers.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-28 09:31:55 -08:00
7a9074ecfd
puppet: Use shorter local variable for supervisor conf.d dir.
2021-12-28 09:24:01 -08:00
670fad0cc4
puppet: Drop now-unnecessary supervisor file removals.
2021-12-28 09:24:01 -08:00
d7f5d041b9
typo: Rename default_hander to default_handler.
2021-12-28 09:19:57 -08:00
c1134a8bda
docs: Fix "should should" typo.
2021-12-28 09:19:04 -08:00
2ff3b51e03
test-documentation: Suppress Unicode Private Use Area validator warning.
...
sphinx_rtd_theme references the Font Awesome fa-link icon directly
with U+F0C1.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 16:55:31 -08:00
591bd3f4a1
webhooks: Rename Yo App to Yo.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 14:05:17 -08:00
1d3520db12
webhooks: Remove space from UptimeRobot.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 14:05:17 -08:00
68c99511a2
webhooks: Fix TeamCity capitalization.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 14:05:17 -08:00
65868b09eb
webhooks: Add missing space in Review Board.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 14:05:17 -08:00
c02c053ec3
webhooks: Fix Mailchimp capitalization.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 14:05:17 -08:00
dc72f79a83
webhooks: Fix Canarytokens pluralization.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 14:05:17 -08:00
cd8a01587b
webhooks: Fix Jotform capitalization.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 14:05:17 -08:00
3ca2f8ca1e
webhooks: Fix Clubhouse capitalization.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-22 14:05:17 -08:00
b1436aed9c
production: Create stream in an atomic transaction.
...
To avoid the window between stream creation and creation of the
Recipient object, we create the stream in an atomic transaction.
Fixes #20127
2021-12-21 15:45:45 -08:00
dc18aadeb2
test_classes: Type kwargs for client_get and friends.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:03:52 -08:00
27977eddeb
export: Use tar -C to switch directories.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:01:53 -08:00
6855df0abb
export_single_user: Fix usage with relative --output directory.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:01:53 -08:00
0daf32310e
export_single_user: Refuse to overwrite a nonempty directory.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:01:53 -08:00
0b454dda12
install: Try apt-get update if the Ubuntu universe check fails.
...
On a system where ‘apt-get update’ has never been run, ‘apt-cache
policy’ may show no repositories at all. Try to correct this with
‘apt-get update’ before giving up.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-16 17:56:23 -08:00
3138f7a73c
mypy: Fix content types.
...
This got by mypy due to Message being an Any type.
2021-12-16 20:35:56 -05:00
517ddbc9e6
setup-advanced: Remove misleading python3 symlink suggestion.
...
One should never have to manually symlink things in /usr/bin,
especially with -f. That should be managed by the system package
manager. Indeed, on CentOS 7 and 8, one can simply install the
python3 package and get a working /usr/bin/python3.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-16 17:30:04 -08:00
0b0faa46b4
mypy: Use object type for checker return values.
2021-12-16 19:52:35 -05:00
e152f255f5
test_upload: Remove GIF file extension test.
...
This change should have been in the previous commit.
2021-12-16 16:16:34 -08:00
22b5e105e6
upload: Remove incorrect animated GIF asserts.
...
GIF files can be `.GIF`, and also we determine the file format by
inspecting the image data, so there's no reason to have this
assertion.
(The code for serving still images does not rely on the file being a
GIF.)
2021-12-16 16:13:00 -08:00
7f8ea5b9f2
stream edit: Find stuff within parent_container.
...
This will facilitate code reuse.
2021-12-16 15:28:11 -08:00
2194a51b97
refactor: Extract people.get_users_from_ids.
2021-12-16 15:28:11 -08:00
YashRE42
Abhijeet Prasad Bodas
Eeshan Garg
Mateusz Mandera
BIKI DAS
Steve Howell
Anders Kaseorg
Alex Vandiver
Shlok Patel
Tim Abbott