Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
19,360 Commits 28 Branches 143 Tags 624 MiB
Commit Graph

19360 Commits

Author SHA1 Message Date
neiljp (Neil Pilgrim) 0958298d88 mypy: Add missing type parameter in test_upload.py:create_user. 2017-07-07 10:56:33 -07:00
neiljp (Neil Pilgrim) 6cb3a2ab1a mypy: Move type annotation in jira/view.py before general comments. 2017-07-07 10:56:33 -07:00
neiljp (Neil Pilgrim) db0b985e82 mypy: Use specific kwargs types. 2017-07-07 10:56:33 -07:00
Tim Abbott d6e0960ca2 push_notifications: Fix mypy annotation logic around push tokens. 
I'm not 100% confident this is long-term correct, but at least it's
consistent.
 2017-07-07 10:54:37 -07:00
Tim Abbott 919c610abf capitalization: Add APNS to list of valid acronyms. 2017-07-07 10:43:02 -07:00
Vishnu Ks c5f75a8f3d test_classes: Remove client_put_multipart function. 
We are no longer using this method anywhere. Removing this
is essential for making the backend coverage tests to pass.
 2017-07-07 10:31:43 -07:00
Vishnu Ks 9067890120 urls: Use POST for zerver.views.user_settings.set_avatar_backend. 
The set_avatar_backend is changed from PUT to POST becuase this
is not idempotent.
 2017-07-07 10:31:43 -07:00
Vishnu Ks df5df76961 urls: Use POST for zerver.views.realm_emoji.upload_emoji. 
The upload_emoji endpoint is changed from PUT to POST because
this endpoint is not idempotent.
 2017-07-07 10:31:43 -07:00
Vishnu Ks cf2dec539f urls: Use POST for zerver.views.realm_icon.upload_icon. 
This upload_icon endpoint is changed from PUT to POST becuase
this endpoint is not idempotent.
 2017-07-07 10:31:43 -07:00
Tim Abbott 0606ba88df push_notifications: Verify that token types are valid. 
We only have two types of push notification tokens, so we should
validate that in the bouncer code path.
 2017-07-07 10:28:36 -07:00
Tim Abbott 40425044c4 push_notifications: Validate APNS token format in bouncer. 
This prevents a buggy old Zulip server from forwarding invalid-format
push notification tokens to the push notification bouncer service.

As part of this change, we switch the token from Text to str to match
the rest of the code path.
 2017-07-07 10:28:36 -07:00
Tim Abbott eaa33cce73 push_notifications: Validate format of APNS tokens. 
This fixes a bug where we would previously not validate the format of
APNS tokens before writing them to the database, which could lead to
exceptions in the push notifications system if a buggy mobile app
submitted invalid format tokens.
 2017-07-07 10:28:36 -07:00
Aditya Bansal e99067cfc3 compose.js: Add node test coverage for abort_xhr() function. 2017-07-07 12:01:41 -04:00
Aditya Bansal d9009f0c84 node tests: Add test_trigger_submit_compose_form(). 
(Steve Howell also contributed to this.)
 2017-07-07 12:01:26 -04:00
Aditya Bansal ada54d4574 compose.js: Add node test coverage for update_fade(). 
(Steve Howell made small changes.)
 2017-07-07 11:57:43 -04:00
Aditya Bansal cf2a9b74d5 compose.js: Add node test coverage to initialze() function. 
(Steve Howell contributed to this as well.)
 2017-07-07 11:19:02 -04:00
Aditya Bansal a6082a2b95 compose.js: Add coverage for transmit_message() function. 2017-07-07 08:29:33 -04:00
Aditya Bansal c7ec7f98d9 compose.js: Use on() instead of deprecated bind(). 2017-07-07 07:50:02 -04:00
Aditya Bansal f7e37d37b3 compose.js: Add coverage for finish() function. 2017-07-07 07:50:02 -04:00
Aditya Bansal c17efffa6a compose.js: Add coverage for enter_with_preview_open() function. 2017-07-07 07:50:02 -04:00
Rishi Gupta 07a3bb4d35 confirmation: Remove get_link_validity_in_days. 
This commit removes the ability to configure different validity durations
for different types of confirmation links. I don't think the extra
configurability was worth the extra complexity, either for the user trying
to understand the settings, or for the developer trying to understand the
code.

The commit replaces all confirmation validity duration settings with a
single setting, settings.EMAIL_CONFIRMATION_DAYS.

The only setting it removes is settings.EMAIL_CHANGE_CONFIRMATION_DAYS,
which was introduced in 5bf83f9 and never advertised in prod_settings.py.
 2017-07-07 07:46:31 -04:00
Rishi Gupta 8ba0fafa3f confirmation/views: Remove unused variables from template context. 2017-07-07 07:46:31 -04:00
Rishi Gupta c1a768f5be confirmation/models: Collect realm creation code into a single section. 2017-07-07 07:46:31 -04:00
Aditya Bansal a55cb919ff install-node: Fix errors in case node or npm is not installed. 2017-07-06 22:06:01 -07:00
Rishi Gupta e84e6aa818 create_realm: Make placeholder text more generic. 
Fixes #2058.
 2017-07-06 23:13:29 -04:00
Tim Abbott d7556eef17 install-node: Remove dependency on realpath. 2017-07-06 18:09:39 -07:00
sinwar c52dbd57f5 provision: Avoid spending 2s reinstalling node/npm. 
Tweaked by tabbott to just check the versions.

Fixes #5184.
 2017-07-06 17:57:22 -07:00
sinwar 9cab965601 install-node: hardcode the path for npm. 
This replaces nvm in npm-wrapper by harcoding the path the way we do
with node.  The main benefit is that this saves a few hundred
milliseconds every time we invoke npm.
 2017-07-06 17:44:28 -07:00
Tim Abbott 774216713b provision: Document more clearly the is_production_travis block. 2017-07-06 17:39:49 -07:00
sinwar 49db0855d2 provision: Avoid spending ~3s on RabbitMQ in no-op case. 
Tweaked by tabbott to reorganize the logic more clearly.

Fixes #5180.
 2017-07-06 17:38:39 -07:00
Tim Abbott 73b05cdbb2 actions: Fix logging issue with unicode in check_message errors. 
This doesn't fix the root problem, but it means we'll get a more
correct traceback when future problems happen.
 2017-07-06 16:22:13 -07:00
James Rowan dc9a41c543 emails: Add preheader content to missed message emails. 2017-07-06 15:46:03 -07:00
Rishi Gupta c827c7840d lint: Re-indent digest.html and missed_message.html. 2017-07-06 15:46:03 -07:00
James Rowan 0d76da27b4 emails: Add base template for missed message and digest emails. 
Also removes the files from lint, so that the new indentation doesn't
obscure the change. The files are reindented in the next commit.
 2017-07-06 15:46:03 -07:00
Rishi Gupta e04bf3273c emails: Rename email_base.html to email_base_default.html. 
About to add another template for digest and missed message emails. Another
natural name would be email_base_transactional, but the followup_day{1,2}
emails aren't really transactional.
 2017-07-06 15:46:03 -07:00
Jack Zhang 16385db3d7 landing-page.js: Implement fuzzysearch and category filtering. 
On /integrations.

For scalability and people who type fast, update_integrations is
debounced; the function will postpone its execution until after
50 milliseconds after it was last invoked.
 2017-07-06 15:28:50 -07:00
Jack Zhang 3f9bfd2ae2 portico: Create search/catalog visuals in /integrations. 
Responsive designs for the search bar, categories sidebar,
categories dropdown, and integration tiles.
 2017-07-06 15:28:50 -07:00
Jack Zhang 9d242ad7df Match size of headings on /apps with /integrations for consistency. 2017-07-06 15:28:50 -07:00
Jack Zhang 37a80d5cc4 portico: Redesign and rewrite /integrations text headings. 2017-07-06 15:28:50 -07:00
Tim Abbott afa8c8259c integrations: Eliminate analytics category. 2017-07-06 15:28:50 -07:00
Tim Abbott 194f03cb77 integrations: Update the categorization. 2017-07-06 15:23:39 -07:00
Tim Abbott b32dfd99fd integrations: Fix configuration for phabricator. 2017-07-06 15:16:14 -07:00
Aditya Bansal 55f05a5f53 compose.js: Add coverage for send_message() function. 2017-07-06 17:44:27 -04:00
Aditya Bansal 2b14714e3b compose.js: Export send_message(). 
We do this in order to have the definition of send_message()
accessible to the outside world. This will help in testing
this function.
 2017-07-06 17:44:27 -04:00
cursiv 2b7938b8ed nginx: Add missing HTTP request methods to header. 
This will make life easier if trying to write a Zulip client inside a
browser using the API.
 2017-07-06 14:38:07 -07:00
Tim Abbott 094c8fd812 docs: Update link to Zulip API bindings code. 2017-07-06 13:08:25 -07:00
Tim Abbott e85aafdb8b integrations: Add initial categories to our integrations page. 2017-07-06 13:04:43 -07:00
Jack Zhang cb3e930159 integrations: Extend integrations classes with categories. 
For now, all integrations are temporarily under the category
'analytics'. Real categorizations should be added prior to
deployment.
 2017-07-06 13:04:43 -07:00
Tim Abbott 32bc794a17 docs: Update link to contrib_bots README.md. 2017-07-06 12:37:02 -07:00
Eeshan Garg f9ba3cb60c api: Remove everything under api/. 
We now have a separate repo for our API bindings. So everything
under api/ can be removed.
 2017-07-06 12:24:38 -07:00