Vishnu KS
d3834f8b9a
emails: Simplify requested by line in sponsorship email.
2020-07-24 17:39:46 -07:00
Vishnu KS
6b9c22b211
support: Add a header for scrub realm section.
2020-07-24 17:37:41 -07:00
Vishnu KS
1a1396d07e
support: Show customer plan details in support page.
2020-07-24 17:37:41 -07:00
Vishnu KS
f6cbb9177a
models: Add plan_name attribute to CustomerPlan.
2020-07-24 17:37:41 -07:00
Alex Vandiver
38d01cd4db
puppet: Generalize install-wal-g to be arbitrary tarballs.
2020-07-24 17:24:57 -07:00
Anders Kaseorg
b900e38dc6
topic_list: Convert widget to an ES6 class TopicListWidget.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:58:22 -07:00
Anders Kaseorg
4517c48de2
todo_widget: Convert task_data_holder to an ES6 class TaskData.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:58:22 -07:00
Anders Kaseorg
c5e397d469
tictactoe_widget: Convert tictactoe_data_holder to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:58:22 -07:00
Anders Kaseorg
cd913b7ebc
sent_messages: Convert message_state to an ES6 class MessageState.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:56:28 -07:00
Anders Kaseorg
daf5a78e98
search_suggestion: Convert make_attacher to an ES6 class Attacher.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:56:28 -07:00
Anders Kaseorg
f96bd3839c
user_search: Convert user_search to an ES6 class UserSearch.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
41778d81d2
unread: Convert unread_topic_counter to an ES6 class UnreadTopicCounter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
e5ff78e893
unread: Convert unread_pm_counter to an ES6 class UnreadPMCounter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
44053eba3f
unread: Convert make_bucketer to an ES6 class Bucketer.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
557e88df77
pm_conversations: Convert recent to an ES6 class RecentPrivateMessages.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
2bf6731f5a
stream_topic_history: Convert per_stream_history to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
e47fd521e3
stream_list: Convert build_stream_sidebar_row to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
2aae92b6e3
stream_list: Convert stream_sidebar to an ES6 class StreamSidebar.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
0ad8da139e
stream_data: Convert BinaryDict to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
30e4b51731
stream_create: Convert stream_name_error to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
3319848768
stream_create: Convert stream_subscription_error to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:50:23 -07:00
Anders Kaseorg
ba4ef5bf90
blueslip: Convert Logger to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:40:42 -07:00
Anders Kaseorg
58c84940f4
blueslip: Convert BlueslipError to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:40:42 -07:00
Anders Kaseorg
abe52e2191
filter: Convert Filter to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:40:42 -07:00
Anders Kaseorg
aee95ecf7e
util: Convert CachedValue to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:40:42 -07:00
Anders Kaseorg
4ad00c1aea
lightbox_canvas: Remove old-style window.onload handler.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:32:53 -07:00
Anders Kaseorg
fc21417d67
lightbox_canvas: Convert LightboxCanvas to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:32:53 -07:00
Anders Kaseorg
d5a0ee612f
lightbox_canvas: Make parameter type error fatal.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:32:53 -07:00
Anders Kaseorg
c4024e30c2
debug: Convert IterationProfiler to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 16:32:53 -07:00
Tim Abbott
ec9c272165
help: Document process for changing organization URL.
2020-07-24 16:12:56 -07:00
Gittenburg
2922e2cbb1
compose: Use aria-label instead of aria-hidden.
...
aria-hidden hides something from the accessiblity tree,
it shouldn't be used for interactive elements.
2020-07-24 15:31:26 -07:00
Gittenburg
8f99820120
composebox_typeahead: Remove deprecated workaround.
...
The Chromium bug[1] was fixed in 2015.
[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=32865
2020-07-24 15:31:26 -07:00
Steve Howell
21dfe76295
tests: Remove dead print-delay code.
2020-07-24 15:30:17 -07:00
Anders Kaseorg
5f0bd44d58
notifications: Fix incorrectly converted focus method call.
...
Commit a9ca5f603b
(#15863 ) incorrectly
converted this; window is quite obviously a DOM element, not a jQuery
element.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 14:48:47 -07:00
Tim Abbott
63991a0a3c
test_message_dict: Remove clock time assertion.
...
Clock time checks lead to tests that nondeterministically fail when
the CI container is super slow, and there's no good reason this test
in particular needs to do that sort of test in addition to our
standard database query count check (which is already does).
2020-07-24 13:29:26 -07:00
Steve Howell
ce77a733e1
outgoing webhook tests: Make setup explicit.
...
Now when you are reading a single test, you can
explicitly see that the event and service handler
are tied to your bot, which is our test bot
for outgoing webhooks.
2020-07-24 13:13:34 -07:00
Steve Howell
fb2a69ec78
outgoing webhook tests: Remove dead code.
...
The first assignment is redundant, and the
second assignment is ignored.
2020-07-24 13:13:34 -07:00
Steve Howell
36027d495a
outgoing webhook tests: Avoid mock decorator.
...
Decorating an entire test with a mock makes it
hard to ascertain where the actual mock behavior
is expected to happen, plus it clutters up
the parameter list.
In fact, we remove a dubious re-assertion here that
a mock was called. The assertion that a mock was
called was true, but it was misleading to think
the code right before it had invoked the mock.
2020-07-24 13:13:34 -07:00
Steve Howell
063e27ab52
mypy: Move accidental mock annotation for self.
...
Curiously, the obviously broken annotation for
self obscured the lack of assert here, so I
fixed that too.
2020-07-24 13:13:34 -07:00
Steve Howell
924292ba65
outgoing webhook tests: Move code out of with blocks.
2020-07-24 13:13:34 -07:00
majordwarf
ad23c6e808
emoji: Switch to `user_profile.realm` for cross-realm reactions.
...
A temporary fix to enable cross-realm emoji reactions till `Message.realm`
is denormalized.
Fixes #15866 .
2020-07-24 13:11:27 -07:00
Tim Abbott
bcab06509a
analytics: Remove unused analytics management commands.
...
Unlike stream_stats, I'm not aware of any of these having been used in
the last few years, and it's basically just really bad subsets of the
data in /activity, which also doesn't require shell access to use.
These haven't had real work or usage, AFAIK, since 2013.
2020-07-24 13:10:43 -07:00
Vishnu KS
49d06b9d69
activity: Always include realms on standard plan.
2020-07-24 13:09:43 -07:00
Anders Kaseorg
f0c4cc9e46
js: Fix new import/order errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 13:04:07 -07:00
Steve Howell
f5bc454b3a
emoji: Remove dependence on page_params.
...
This sets us up to make emoji a leaf module.
2020-07-24 12:57:52 -07:00
Steve Howell
5280b87f19
emoji refactor: Let emoji.js own the data.
...
We now only use page_params.realm_emoji at
intialization time, and then settings_emoji
gets the data from emoji.js.
2020-07-24 12:57:52 -07:00
Steve Howell
d11c6686a1
minor: Remove parameter to populate_emoji.
...
This is an easy prep step to help out phase
out page_params.realm_emoji.
All callers pass in what's effectively
page_params.realm_emoji. (The dispatch
code does it indirectly.)
2020-07-24 12:57:52 -07:00
Steve Howell
4f195de78d
node tests: Split out settings_emoji.
...
This keeps the emoji tests free of jQuery
concerns.
2020-07-24 12:57:52 -07:00
Steve Howell
cc31403112
mobile sharing: Move fenced_code.js to shared/js.
...
We also take fenced_code out of the global namespace,
since it only requires katex and underscore.
And we fix the exports to be ES6 style.
2020-07-24 12:57:52 -07:00
Steve Howell
c50dbf8297
node tests: Extract markdown_katex.
...
I want to isolate this test to its own module,
because it is gonna require some rewireproxy
magic in an upcoming commit.
2020-07-24 12:57:52 -07:00