When rendering message list directly from cached data, we sometimes
ask server to verify the current data.
If the data doesn't match, we include events at the time cached
data was restored to help with debugging or to determine if there
was race in updating the data.
`Filter.public_terms` will return the same result even if the
narrow is combined feed. Since we are no longer passing
empty narrow parameters for combined feed, this condition is
not required.
When we will no longer clear cached data on moving messages in
later commits, we have to clear cached data for the new filter when
changing narrow to avoid the message list from being populated
from it since the cached msg data is not updated as per the moved
topic and needs to be updated.
We extend the existing logic that updates message events for
rendered message lists to apply for cached message list data
objects as well.
Manually tested for common message property narrows to test
update of the message property.
Earlier in navbar navigation, keyboard events only worked with `gear-
menu`, `personal-menu` and `help-menu`.
This commit introduces the ability to navigate to login in spectator
mode by adding `navbar-item` class and trigger focus to it.
Fixes: zulip#28037.
Earlier in navbar navigation, keyboard events only worked with `gear-
menu`, `personal-menu` and `help-menu`. Now that userlist-toggle is
introduced in navbar, we should make it navigable.
This commit introduces the ability to navigate from `help-menu` to
userlist button by adding `navbar-item` class and trigger focus to it.
Fixes: zulip#29465.
This commit introduces `navbar-item` class for each navbar menus and
`active-navbar-menu` class to indicate active navbar menu. Also
introduces new function `get_target_navbar_menu` to return target
navbar menu from keyboard event. `change_active_navbar_menu` uses target
menu to switch between navbar items.
This commit extracts menu switching logic from `handle_keyboard_events`
to separate `change_active_navbar_menu` to toggle between the current
active navbar menu and the adjacent navbar menu.
Previously, when resizing the window, the filters/buttons and the
header did not fit on the same row, the filters/buttons were pushed
onto the next row but not put directly below the heading. This
changes the settings_panel_list_header and
add_default_streams_button_container into flex containers and
properly aligns the items below the heading when changing window
size.
Fixes: #30353
Dropdown widget in compose box and in message move modal should
not show archived streams in dropdown as we do not allow sending
messages or moving messages to archived streams.
We need a more focused audit of code for fixing other things
where archived streams are shown.
Apparently `.data("category")` would be come back as a single-element
array for some French translations, rather than a string.
We fix this by using `.attr("data-category")` across this file, which
is our preferred coding pattern anyway.
This commit removes the `button-secondary`, `button-group` and
`bootstrap-btn-group` classes which don't have any corresponding styles
attached to them or are no longer in use in the codebase.
Since pressing `escape` key closes flatpickr and settings overlay
at the same time, we need to wait for the settings to be not
visible.
If we don't wait for the settings overlay to close, the next test
could think the settings overlay is already open and continue with
its tests which can easily become flaky.
This commit removes the final vestiges of `bootstrap-btn.css` from
portico, allowing us to move `bootstrap-btn.css` from `common.ts` bundle
to just `app.ts` bundle.
This commit includes the following changes:
- While inviting users for guest roles, we display an
empty channel list rather than the default channel list
and the default channels checkbox is unselected.
- While inviting users for non-guest roles we continue
to select the default channels checkbox.
- When switching between guest and non-guest roles, the
previous state of included channels for the guest role
is restored while inviting a user as a guest.
Fixes: #31988.
Co-authored-by: Aditya <113302312+userAdityaa@users.noreply.github.com>
Karl Stolley
Aman Agrawal
Pratik Chanda
Nicklas Steen
Sahil Batra
evykassirer
Anders Kaseorg
Tim Abbott
Sayam Samal
Saubhagya Patel
Vector73