5f25974737
Fix Javascript whitespace issues with {.
2015-11-10 10:01:34 -08:00
9162ef3e0f
Fix wrong logic in handling local-only message edit saves
...
(imported from commit a9074fbfb75884c3280807ddeba576c0fbe313b7)
2014-03-14 20:48:57 -04:00
f760567b96
Fix topic edits that are initiated from the FRB.
...
Grab the id of the selected row, whether it's a message, recipient bar, or FRB
(imported from commit 93b9c282d4220ba9bb271733ded4d90d5c051c75)
2014-03-14 20:48:55 -04:00
3889edd824
Move xhr_error_message() into channel.js
...
(imported from commit c68c2d475b5673a3dd5f68c75624dfcfe56728ca)
2014-03-14 20:48:53 -04:00
b51ea69db0
Handle topic edits and rerender view if topics have changed
...
(imported from commit b59f6b532138d660e0acfb949b2eb223b5c5ed0e)
2014-02-27 20:25:33 -05:00
15f5884247
Focus textbox when editing PMs.
...
(imported from commit 152cb829779f808bf6ec65daa2cdc35da66e7e25)
2014-02-27 20:25:29 -05:00
1d601134ed
Don't error out if we get an edit for a message that's out of view
...
(imported from commit 042cadc8657d048d0fd3a410af5adbbaeac7d92d)
2014-02-27 20:25:27 -05:00
c63f881518
Fix inverted boolean check for local messages in topic propagation
...
(imported from commit 2daf7c0c8729a785c3a1105803cbaed31f32128e)
2014-02-12 10:08:19 -05:00
883122b129
Allow editing of locally echoed messages that failed to be sent
...
(imported from commit eff8d55af7a1ff123ed2a2e45e58ff74de96beac)
2014-01-23 16:28:55 -05:00
7f174213ed
Add an idempotent flag to the channel module.
...
(imported from commit d5b867d2a8f176cae76c8b68435c4fab318d998b)
2014-01-10 21:39:00 -05:00
795930c803
Add channel module wrapping our various JSON requests to the server.
...
(imported from commit 6489938678551ad8594822363ae6d1c9ae295496)
2013-12-19 16:52:47 -05:00
11aec0104e
fix bug where the composebox may obscure message editing
...
(imported from commit 905870706b8919a852f58cfc639483acab6fc28a)
2013-12-13 17:19:50 -05:00
57b6ba4250
Revert "Respect enter-to-send in edit box"
...
I love press-enter-to-send but find this behavior confusing when
I'm in an edit box -- if we're going to respect it, we should
do so obviously (with a checkbox visible).
This reverts commit 6e3fc6495b7012aa12728a78b8bdd95701bb21e1.
(imported from commit d1ae16110f5504e879e315037c85c211ba3bca9a)
2013-11-28 13:51:45 -08:00
ce29c4dd34
Prefill the existing topic when editing a message topic.
...
This is a behavior that basically only administrators can trigger
today, with the exception of the fact that anyone can edit a no-topic
message.
(imported from commit d50eded79ddf3438d87e3dc6a8641fbfb034d50c)
2013-11-21 10:38:36 -05:00
e9bd56b5a0
Make topic edits propagate by default from message header form
...
(imported from commit 6adcce6ebf90b35e84316e9f079de4010a635f8b)
2013-11-05 12:46:59 -05:00
c5183427f3
Respect enter-to-send in edit box
...
(imported from commit 6e3fc6495b7012aa12728a78b8bdd95701bb21e1)
2013-09-27 13:52:14 -04:00
87858a6050
Don't autocomplete mentions while message editing
...
(imported from commit c4b402d5c0e50a7dd85f658f660633f3a3df5d54)
2013-09-27 13:32:02 -04:00
4ea15758cd
Enable compose-box typeaheads in the edit message box
...
(imported from commit 8cf1ec74854889061e822f091c16cb817f00c56b)
2013-09-27 13:32:02 -04:00
c588c7938c
Allow message topic changing to propagate backwards
...
(imported from commit 470178ef5f7aaf09d4528c88ae6e33f17538fcaf)
2013-09-18 13:27:58 -04:00
e780502372
propagate_topic_edits feature flag: staging and CUSTOMER7
...
(imported from commit aca356a7c7f98066b13a51ede55c4925b95a476b)
2013-09-04 14:51:46 -04:00
19a835e7d5
Add a checkbox that propagates topic edits to subsequent messages.
...
Trac #1348
(imported from commit 28e2a8cb3ecda5ec50d17501f4ccbd8644212065)
2013-09-04 14:51:46 -04:00
d529013b9a
Fix browser error in editing PMs.
...
PMs do not have a "topic" field.
(imported from commit 023d283ad94147e8bb9a2c7f6959c0a636d825cd)
2013-08-20 12:00:11 -04:00
395aaae994
Allow anyone to edit a "no topic" message
...
This change would allow anyone in the realm to set a topic for a "no topic"
message. As soon as the message topic is set, only the sender can change it again.
(imported from commit 0a91a93b8fd14549965cedc79f45ffd869d82307)
2013-08-19 16:29:30 -04:00
0f6c7ca7be
Use msg_list.get_row(id) instead of rows.get(id, msg_list.table_name)
...
(imported from commit 953cd24e605269d2bbdc42b878506f0ab01501e8)
2013-08-14 17:08:32 -04:00
386df6e58b
Eliminate unnecessary calls to "function".
...
(imported from commit 8f6a90dde723c7f9e8a7929ce44e0f1fce869e81)
2013-08-05 16:59:49 -04:00
f38ad493b0
Revert "Eliminate unnecessary calls to "function"."
...
This reverts commit 30afb6eb4b037991ed0569db63e71dcce53e4554.
(imported from commit 3eebe2181870f933171d6140467b3d7beb402106)
2013-08-05 11:02:55 -04:00
88245c36b4
Eliminate unnecessary calls to "function".
...
(imported from commit 30afb6eb4b037991ed0569db63e71dcce53e4554)
2013-08-05 10:36:56 -04:00
afb5105ee4
Make Ctrl/cmd-enter save message editing.
...
Partially addresses Trac #1541 .
(imported from commit 184a7b5cfd9f82da0e2b148ec891d69f7e50d6a3)
2013-08-02 18:37:56 -04:00
8703134a23
Replace $.each with _.each
...
In a few cases the $.each was doing something imperatively that was
terser and easier to understand by using a different Underscore method,
so a few of these I rewrote.
Some code was using the fact that jQuery sets `this` in the callback to
be the item; I rewrote those to use an explicit parameter.
Some code was using $(some selector).each(callback). I converted these
to _.each($(some selector), callback).
One function, ui.process_condensing, was written to be a jQuery $.each
callback despite being in a totally different module from code using it.
I noticed this and updated the function's args.
(imported from commit bf5922a35f257c168cc09ec1d077415d6ef19a03)
2013-07-30 12:12:58 -04:00
bc4d7c687d
Rename our custom JS events to use Zulip, not Zephyr.
...
(imported from commit 61ac456d394a6dbc14f3e9183a53313990db5059)
2013-07-29 12:11:26 -04:00
3bba0cc927
Move zephyr/static to just static.
...
It's not really a part of the server (aka the rest of zephyr/).
(imported from commit 27f6b6b064938ad927075a68d873e4b68710d279)
2013-07-29 12:11:26 -04:00
Tim Abbott
Leo Franchi
Steve Howell
Tim Abbott
acrefoot
Waseem Daher
Kevin Mehall
acrefoot
Jeff Arnold
Scott Feeney
Tim Abbott