75635844db
lightbox: Set URL in payload instead of computing from video IDs.
...
Lightbox previews for youtube playlists use the "current" video in the playlist
for the preview. The open link for such previews is incorrectly set to the first
video alone, and not the playlist. This commit fixes the bug by linking to the
original URL for lightbox preview is being shown, instead of computing the URL.
2019-05-29 23:01:54 -07:00
11cbe2bf6a
lightbox: Fix a "Pan & Zoom" causing an error with thumbnailed images.
...
Images on the new thumbnailing system generate an error when
"Pan & Zoom" is enabled:
Browser Error: Lightbox for unknown message undefined
39648: http://localhost:9991/webpack/app.js
| Object.blueslip_error [as error]
50743: http://localhost:9991/webpack/app.js
| Object../static/js/lightbox.js.exports.open
50897: http://localhost:9991/webpack/app.js
| HTMLDivElement.
39474: http://localhost:9991/webpack/app.js
| HTMLDivElement.blueslip_wrapper
16299: http://localhost:9991/webpack/app.js
| HTMLDivElement.dispatch
16107: http://localhost:9991/webpack/app.js
| HTMLDivElement.elemData.handle
To fix this, instead of using the `src` attribute as the key for
`asset_map`, which can be either the original or thumbnailed version
depending on the situation, always use the original version.
Also, create `frontend_tests/node_tests/lightbox.js` to test this
functionality.
Fix #9955 .
2018-07-18 10:19:56 -07:00
Puneeth Chaganti
Aditya Bansal
Marco Burstein