zulip

Commit Graph

Author	SHA1	Message	Date
aryanshridhar	418c40b2ea	settings_users: Refactor user_deactivation modal to confirm_dialog module. The "email" span in the old modal was not used for styling, just to support updating the field visually.	2021-06-08 17:57:27 -07:00
Nikhil Maske	50cd868749	confirm modal: Use Confirm and Cancel label options. Long labels like "Deactivate xyz" or "Delete xyz" can be confusing for translators and it can also create bad strings that can end with like 4 long words in German. It is better to have the simple options like "Confirm" and "Cancel". This commit fixes this issue by changing the text to "Confirm" in their respective template files. Fixes #17926.	2021-04-07 18:27:22 -07:00
Riken Shah	f6998d6fee	puppeteer_tests: Remove sequential numbers from test files. The only downside of this is that it makes it harder to control the order of these tests; which isn't that important. And the structure of naming each with its test order fundamentally requires renaming files when adding/deleting tests, so if we want to control the default test order, we'd be better off doing that by just hardcoding a list in the test runner code.	2021-04-01 07:46:13 -07:00

Author

SHA1

Message

Date

aryanshridhar

418c40b2ea

settings_users: Refactor user_deactivation modal to confirm_dialog module.

The "email" span in the old modal was not used for styling, just to
support updating the field visually.

2021-06-08 17:57:27 -07:00

Nikhil Maske

50cd868749

confirm modal: Use Confirm and Cancel label options.

Long labels like "Deactivate xyz" or "Delete xyz" can
be confusing for translators and it can also create bad
strings that can end with like 4 long words in German.
It is better to have the simple options like "Confirm"
and "Cancel". This commit fixes this issue by changing
the text to "Confirm" in their respective template files.

Fixes #17926.

2021-04-07 18:27:22 -07:00

Riken Shah

f6998d6fee

puppeteer_tests: Remove sequential numbers from test files.

The only downside of this is that it makes it harder to control the
order of these tests; which isn't that important.  And the structure
of naming each with its test order fundamentally requires renaming
files when adding/deleting tests, so if we want to control the default
test order, we'd be better off doing that by just hardcoding a list in
the test runner code.

2021-04-01 07:46:13 -07:00

3 Commits