zulip

Commit Graph

Author	SHA1	Message	Date
Steve Howell	a8f5836ee6	tests: Make soft-reactivation tests readable. The `expected` flag was incredibly confusing, as you couldn't tell from the calling code what you were actually expecting to happen. I avoid the context manager idiom in order to force the callers to create simple helper functions, and I de-duplicate some code in some places. I also force the caller to explicitly soft-deactivate the user with one simple line of code, so that the person reading the test doesn't have to research the side effects of the helper. (And I make it very easy for new authors to follow the practice going forward.) This is also somewhat of a prep commit to avoid the obfuscated use of refresh_from_db.	2023-09-18 16:55:06 -07:00
Anders Kaseorg	81bd63cb46	ruff: Fix PIE808 Unnecessary `start` argument in `range`. Signed-off-by: Anders Kaseorg <anders@zulip.com>	2023-09-01 14:57:01 -07:00
Prakhar Pratyush	c4e4737cc6	notification_trigger: Rename `private_message` to `direct_message`. This commit renames the 'PRIVATE_MESSAGE' attribute of the 'NotificationTriggers' class to 'DIRECT_MESSAGE'. Custom migration to update the existing value in the database. It includes 'TODO/compatibility' code to support the old notification trigger value 'private_message' in the push notification queue during the Zulip server upgrades. Earlier 'private_message' was one of the possible values for the 'trigger' property of the '[`POST /zulip-outgoing-webhook`]' response; Update the docs to reflect the change in the above-mentioned trigger value.	2023-08-10 17:41:49 -07:00
Alex Vandiver	def6bf17eb	tests: Split out missed_message email tests.	2023-08-09 15:49:49 -07:00

4 Commits