06492738b5
dev: Expose coverage and built documentation to web.
...
This makes it much more convenient for developers to access coverage
and built developer documentation.
2017-03-23 13:10:06 -07:00
97e844e97c
test_notifications: Don't pass a user_profile to client_patch.
...
This fixes a JSON overflow error when producing URL coverage reports.
2017-03-23 13:08:49 -07:00
49f5be1dba
hotkey: Extend tests for message_view_only_keys.
2017-03-23 11:38:37 -07:00
f40b43a491
hotkeys: Add hotkey `G` an alias for End.
...
Fixes #4195 .
2017-03-23 11:38:36 -07:00
5d030e9173
casper: Add test for the reload hashchange logic.
2017-03-22 23:06:08 -07:00
04db0b5df0
reload: Fix passing data to next browser session.
...
Apparently, Django's CSRF protection mechanism changed at some point,
and now we get a different CSRF token every time the webapp is loaded.
This, in turn, caused our reload logic to avoid losing state to be
completely ineffective, since the CSRF check in reload.initialize
always failed.
We fix this in a secure fashion by passing the reload instructions
from the browser to its reloaded self via localstorage, keyed by a
randomly generated token. The token randomization is primarily
relevant for handling several Zulip tabs in the same browser, but also
servers to make it very difficult for an attacker to ever trigger this
code path by redirecting a browser to `/#reload` URLs.
Fixes #3411 .
Fixes #3687 .
2017-03-22 22:46:54 -07:00
64acf84ab1
reload: Save narrow when event queues expire.
...
Along with the issues with our reload data passing system that are
fixed in the next commit, this is responsible for #3411 .
2017-03-22 22:28:35 -07:00
ee4b948873
bankruptcy: Fix narrow being lost on declaring bankruptcy.
...
This was actually being done in 2 ways: via not saving the narrow in
the reload and second through calling `change_tab_to('#home')`. The
code is so ancient that it seems unlikely that this behavior was still
intentional.
Fixes part of #3687 (the remainder is fixed in a few commits).
2017-03-22 22:28:18 -07:00
37ac0e6e6d
server_events: Remove obsolete 'tool old' handler.
...
This error predates the transition to an event queue system and hasn't
been possible for years.
2017-03-22 21:16:39 -07:00
61e6ed8c31
bankruptcy: Fix clicking outside bankruptcy modal.
...
Previously, this would leave the unread UI disabled forever, showing 0
unread counts for anything, which was a super confusing failure mode.
2017-03-22 20:50:44 -07:00
977e7b0fdc
unread: Move bankruptcy code out of click_handlers.js.
2017-03-22 20:49:05 -07:00
f3af0fe635
reactions: Fix reacting to messages on streams you're not subscribed to.
...
We use the same strategy Zulip already uses for starred messages,
namely, creating a new UserMessage row with the "historical" flag set
(which basically means Zulip can ignore this row for most purposes
that use UserMessage rows). The historical flag is ignored, however,
in determining which users' browsers to notify about new reactions,
and thus the user will get to see the reaction appear when they click
a message (and any reactions other users later add, as well!).
There's still something of a race here, in that if some users react to
a message while the user is looking at the unsubscribed stream but
before the user reacts to that message, those reactions will not be
displayed to that user (so counts will be a bit lower, or something).
This race feels small enough to ignore for now.
Fixes #3345 .
2017-03-22 20:22:13 -07:00
60326ca94c
test_events: Add reaction tests.
2017-03-22 20:22:02 -07:00
0963f2d518
reactions: Extract notify_reaction_update.
2017-03-22 20:22:02 -07:00
ce2c3fbb06
requirements: Install api bindings in production.
2017-03-22 19:33:51 -07:00
1f89058023
Fix broken size for message actions popover.
...
This fixes a regression introduced in
23a5f56023
2017-03-22 16:44:23 -07:00
ccb38a1e9c
compose: Fix missing opts argument to show_box.
...
This fixes a regression in the recent compose.get_focus_area
refactoring that I did.
2017-03-22 16:32:53 -07:00
97bd9d5186
Fix positioning of message-info-popover.
2017-03-22 16:04:38 -07:00
ed72ee476f
Make user_popover use user_info_popover template.
2017-03-22 16:04:38 -07:00
b2fc8d6fa2
Rename message_info_popover* templates to user_info_popover*.
2017-03-22 16:04:38 -07:00
23a5f56023
Add sender avatar in message popover.
2017-03-22 16:04:38 -07:00
3ac8f52a73
Remove title of message info popup.
2017-03-22 16:04:38 -07:00
32bc5893d0
Remove arrow from message info popover by providing template.
...
Provide custom template (user_info_popover.handlebars) to message info popover.
2017-03-22 16:04:38 -07:00
2a5e600623
glossary: Add a few comment useful terms.
2017-03-22 15:49:20 -07:00
b96d18eb6f
documentation: explain the term "bankruptcy".
2017-03-22 15:49:19 -07:00
67a4ce99ee
tutorial: Disable tutorial for default development users.
...
You can always make a new user if you need to test the tutorial, and
this will save a bunch of developer time ignoring the tutorial popup.
2017-03-22 15:30:36 -07:00
2a5269baa9
docs: Document the frontend hashchange system.
2017-03-22 15:21:36 -07:00
d6716838ad
bugdown: Remove trailing whitespace on fence code blocks.
...
This fixes fenced code blocks that are copy-pasted from certain
clients having trailing whitespace anoyingly often.
Fixes #3998 .
2017-03-22 14:17:34 -07:00
5ed482cf2c
compose: Apply consistent styling for compose buttons.
...
This applies the consistent :hover effect for all compose buttons.
Fixes : #4239 .
2017-03-22 13:15:44 -07:00
d39b2e116b
settings: Disable password strength checking in development.
2017-03-22 13:14:20 -07:00
0fec03f8bb
test_docs: Fix normal users test text.
2017-03-22 13:14:19 -07:00
3d3f9bc58e
devlogin: Link to the normal login page.
2017-03-22 13:03:45 -07:00
397e9c109e
auth: Separate development login from main login page.
...
This allows us to enable EmailAuthBackend by default in development
without cluttering the development login experience.
Fixes #3652 .
2017-03-22 12:54:30 -07:00
4c88b3f5da
logging_util: Fix timezone-naive datetime being compared to aware datetime.
...
Fixes regression in 3d07ac0
2017-03-22 12:51:58 -07:00
dbcd19bcfa
streams: Add hotkey for content-editable enter.
...
When you enter, it should click the checkmark, which would save the
current input of the input section.
2017-03-22 12:21:21 -07:00
d21fe68e9e
streams: Fix content-editable cursor shifting to beginning.
2017-03-22 12:21:08 -07:00
956106ae92
streams: Fix closing of content-editable area on escape key press.
...
Pressing Escape key while editing stream description now closes
the editing.
Fixes #4202 .
2017-03-22 12:19:59 -07:00
9a339a7053
streams: Prevent cursor jump to the end of editing stream-descr.
...
This prevents the cursor to jump at the end of the content-editable
area when the user types in the middle.
Fixes #4202 .
2017-03-22 12:19:59 -07:00
0fc946aef4
testing: Add reverse option to test runner.
2017-03-22 12:07:21 -07:00
3c0f341eb7
test_subs.py: Change assert_max_length to assert_length.
2017-03-22 12:07:21 -07:00
804c62045f
testing: Flush API_KEYS before every test.
...
This makes our test performance for each test more consistent.
2017-03-22 12:07:06 -07:00
ff8ab054da
testing: Fix query count for test_bulk_subscribe_MIT.
...
test_subs.SubscriptionAPITest.test_bulk_subscribe_MIT fails when it is
run individually.
2017-03-22 12:07:06 -07:00
8431ceace2
testing: Serialize BotTest with upload tests.
2017-03-22 11:59:30 -07:00
2f243d8808
testing: Control parallelism through cmd args.
2017-03-22 11:59:30 -07:00
9707c74f33
message_edit: Added copy to clipboard button.
...
A copy-to-clipboard button is added over message-edit textarea.
Closes #3239 .
2017-03-22 11:00:18 -07:00
2991c19fea
Extract typing indicator inbound timing logic.
...
We now track our inbound timing events using code in
typing_data.js.
This code may be a little more robust with variations on how
recipients are represented in events, although there are no known
bugs here.
2017-03-22 08:20:21 -07:00
4fb8339954
Extract typing_events.js.
2017-03-22 07:29:42 -07:00
cde1861655
typing indicators: Validate PM emails.
2017-03-22 07:01:20 -07:00
1ec392a18e
Extract compose.get_invalid_recipient_emails().
2017-03-22 07:01:20 -07:00
84b31a5532
typing indicators: Limit to PM conversations.
...
We now only send outbound typing indicators if we are
composing a private message.
2017-03-22 07:01:20 -07:00
Tim Abbott
Joshua Pan
hackerkid
Moritz Neeb
hollywoodno
Brock Whittaker
sinwar
Rishi Gupta
Raghav Jajodia
Umair Khan
Steve Howell