aad3bff193
Harden style rule for % comprehensions and fix existing errors.
2016-02-02 23:08:19 -08:00
700055c194
Apply modernize transform libmodernize.fixes.fix_file.
...
This replaces use of file() with open() which is python 3 compatible,
and also adds it to our python 3 support test suite.
2016-01-26 21:09:42 -08:00
df4d1b3c14
Add linting code for detecting shebang bashisms.
...
This will prevent regressions in OpenBSD compatibility, since OpenBSD
doesn't support passing arguments in the #! line.
2016-01-21 22:33:55 -08:00
0fe819eb57
lint: Tighten lint rules around whitespace around '%' comprehensions.
2015-12-05 15:29:42 -08:00
69b6b60017
lint: Clean up whitespace_rules.
...
Several of these rules only apply to one of Python and Javascript, and
this simplifies the logic and should make our linter code more readable.
In the process, we add support for per-rule/file pair exclusions to
handle the tab exception for codehilite.py.
2015-12-05 15:29:42 -08:00
a712954c59
lint: Rewrite custom checks to use a more consistent framework.
2015-12-05 15:29:42 -08:00
8a18e78a65
Add lint rules checking for our % comprehension style.
2015-12-05 15:29:42 -08:00
b81ecc4064
Add whitespace lint rules checking for missing spaces before {.
2015-11-10 10:06:47 -08:00
f1074aa491
Move frontend tests out of zerver/tests/.
...
This fixes an unfortunate bug where the backend tests in
zerver/tests.py were not being run automatically, and also makes these
a bit easier to find.
2015-10-28 10:11:47 -07:00
d5435fad1d
Consistently use /usr/bin/env python2.7 in shebangs and commands.
2015-10-21 22:58:21 +00:00
232de3015a
Add lint checks for tab-based whitespace.
...
We exclude the one file we have with issues that comes from a
third-party vendor.
(imported from commit 47e097b39440aea8e4d7468892176ffce4818b5f)
2015-09-19 23:23:02 -07:00
c25d9679a5
Utility for unescaping HTML entities leftover from MediaWiki->rST conversion
...
(imported from commit 2f2507f299c3d09c67bfd26d6c11fab47431d935)
2015-08-18 17:31:33 -07:00
1136d399ca
Add a check for blueslip.warning to perform_extra_js_checks
...
(imported from commit 92872542c4a97c31d7864137b759abb8bf26a551)
2014-02-05 10:43:55 -05:00
de522029d5
Switch to DiscoverRunner from DjangoTestSuiteRunner
...
(imported from commit 77dd694b20509bfdc7327186e0524d686f0415f7)
2014-01-29 11:34:31 -05:00
582f7eb24d
Extract test_hooks.py.
...
These classes are in test_hooks.py now. They still run as part of
the regular suite, so this is just to make it easier to navigate the
files.
JiraHookTests
BeanstalkHookTests
GithubV1HookTests
GithubV2HookTests
PivotalV3HookTests
PivotalV5HookTests
NewRelicHookTests
StashHookTests
FreshdeskHookTests
ZenDeskHookTests
(imported from commit 26a9572dd5170f9516e739d587a119bd1f87959a)
2014-01-29 10:56:00 -05:00
a8825e1c5d
Fix linting for zerver/lib/tornado_ioloop_logging.py with older pyflakes.
...
(imported from commit 998d95df05acdc610336bf6da48fafd8c129e52e)
2014-01-14 11:43:06 -05:00
ea49e9d1b0
Rename check-handlebar-templates to check-templates.
...
(It's been checking Django templates too.)
(imported from commit e1a92210d07dfd68666a8c93642c4eb8d5ff081f)
2013-12-17 12:44:59 -05:00
1fb9c09f02
Don't import bugdown in models.py headings.
...
This allows us to avoid a circular import when importing models.py
from inside bugdown for the realm-filters-from-database branch.
(imported from commit 7de85b54243132ade6818b080abdc8c5e8ad84f5)
2013-12-11 14:39:09 -05:00
5ada0ab93e
Exclude git_p4 from the linter, not our code.
...
(imported from commit 221a7947f1679dde888198f6d1da2d5bdf8f6ba4)
2013-12-06 11:54:38 -05:00
3e51ac2f3d
Add -m to lint-all to check modified files.
...
This uses git ls-files -m, which will show modified and added files,
but it doesn't seem to show staged files, so buyer beware.
(imported from commit 6ecc1d5ee628deae17197addf5586f1f6bcd4b9c)
2013-12-02 16:14:06 -05:00
72e2fbd725
Allow specific files to be checked by lint-all.
...
(imported from commit a17800e3ab079e95033243bc82446737dc456b68)
2013-12-02 16:14:06 -05:00
95320b7369
DRY up forking code in lint-all.
...
(imported from commit f4c52596c9e9cf0a1be5d4bea26f9793c67f93d5)
2013-12-02 16:14:06 -05:00
6c57a9ec26
Hide 'redefinition of unused' pyflakes errors
...
(imported from commit d5c0129c40121f8bca8f2ebedde8fcbf03d718f2)
2013-11-13 13:44:14 -05:00
442ae115a2
Remove legacy check_output implementation for pre-2.7 Pythons.
...
We still need it in integrations, because those don't require Python
2.7, but we don't need it in any of our code that runs on internal
servers.
(imported from commit 3c340567f1a372dcb4206c6af9a6e5e18005b1b8)
2013-11-10 09:28:55 -05:00
7fd9c607ea
Exclude api/setup.py from the linter's wrath.
...
(imported from commit 2e9718b6be472523b2684b6fcae4545f0a7fba49)
2013-10-31 17:26:52 -04:00
fffd4f3c59
Move zulip_tools library to root of repository.
...
(imported from commit 2fada9d2acbcf81f8e2b3de8caadbf335141dfaa)
2013-10-28 10:54:48 -04:00
080f5922e1
lint-all: Fix gotcha regexps to not misparse certain quoting cases.
...
(imported from commit fed305fce9cf6f88e05f4d7310e25928ae6add4b)
2013-10-21 14:37:36 -04:00
5c4fb277c1
Add tools/check-handlebar-templates.
...
(imported from commit e9f634be4d3699eb2d4fc12f6311b42ead710427)
2013-10-09 17:16:52 -04:00
fff4244b54
Move various settings into local_settings.py.
...
(imported from commit 03c4a61383f3f8cf8207050d68d5ce870e12fcca)
2013-09-25 15:40:21 -04:00
7228ce956b
Wait for puppet checks to finish in lint-all
...
(imported from commit 760c49622e5f33e12551f24128e1df54a9ae8848)
2013-09-19 10:46:29 -04:00
203a71dcd0
Fail hard on pyflakes errors.
...
Also, run pyflakes in the background like the other processes.
(imported from commit b168a5f7dd6dd5ec4b75e3148aea82b3e1040f87)
2013-09-19 10:46:28 -04:00
2b8fd43edd
check-all: Run 'puppet parser validate' to validate puppet changes.
...
(imported from commit f1ab619b6e0b993f3b9b6fe081f085d2dd2072b0)
2013-08-09 13:53:17 -04:00
29fd84fdbd
Rename check-all to lint-all.
...
(imported from commit 844b2c69748f6d9df8ff1189c006ccf405f787c3)
2013-08-09 13:06:02 -04:00
Tim Abbott
Vladislav Manchev
Steven Oud
Tim Abbott
Yoyo Zhou
Jason Michalski
Steve Howell
Luke Faraone