3dfaca0773
personal_menu_popover: Flatten nested lists for better accessibility.
...
This refactors popover list structure to use a flattened `ul > li`
structure along with aria-related additions, enabling screen reader
accessibility and announcing menu length and position (`# of n`).
Added ARIA roles:
- `role="menu"` to the parent `<ul>` element, indicating it is a widget
offering a list of choices.
- `role="menuitem"`, `role="menuitemcheckbox"`,
or`role="menuitemradio"` to child elements based on their function.
- `role="group"` to the theme switcher, identifying it as a container
for related menu items.
- `role="none"` to `<li>` elements, removing the implied `listitem`
role that conflicts with the parent menu structure.
2024-05-31 15:28:01 -07:00
ed9d2a7af6
gear_menu_popover: Flatten nested lists for better accessibility.
...
This refactors popover list structure to use a flattened `ul > li`
structure along with aria-related additions, enabling screen reader
accessibility and announcing menu length and position (`# of n`).
Added ARIA roles:
- `role="menu"` to the parent `<ul>` element, indicating it is a widget
offering a list of choices.
- `role="menuitem"`, `role="menuitemcheckbox"`,
or`role="menuitemradio"` to child elements based on their function.
- `role="none"` to `<li>` elements, removing the implied `listitem`
role that conflicts with the parent menu structure.
2024-05-31 15:28:01 -07:00
3c1d248abe
message_actions_popover: Flatten nested lists for better accessibility.
...
This refactors popover list structure to use a flattened `ul > li`
structure along with aria-related additions, enabling screen reader
accessibility and announcing menu length and position (`# of n`).
Added ARIA roles:
- `role="menu"` to the parent `<ul>` element, indicating it is a widget
offering a list of choices.
- `role="menuitem"`, `role="menuitemcheckbox"`,
or`role="menuitemradio"` to child elements based on their function.
- `role="none"` to `<li>` elements, removing the implied `listitem`
role that conflicts with the parent menu structure.
Also removes the unused `should_display_reminder_option` code, which
should have been removed in f40855bad2
2024-05-31 15:27:30 -07:00
a177d8fa49
settings_streams: Convert module to TypeScript.
2024-05-31 15:19:43 -07:00
40953f7ada
dialog_widget: Fix 'onclick' event type.
2024-05-31 15:19:43 -07:00
a2a735273b
left_sidebar: Maintain em-equivalent 16px separator row height.
2024-05-31 15:18:06 -07:00
b4b5d03a8e
left_sidebar: Set topic rows to normalized em-based line-height.
2024-05-31 15:18:06 -07:00
9a2cc09ec2
left_sidebar: Set channel rows to em-based line-height.
2024-05-31 15:18:06 -07:00
3f9897cfee
left_sidebar: Set DM rows to em-based line-height.
2024-05-31 15:18:06 -07:00
d8a73c8637
left_sidebar: Set navigation area rows to em-based line-height.
2024-05-31 15:18:06 -07:00
ef68132a5a
left_sidebar: Declare header row-heights as prominent rows.
2024-05-31 15:18:06 -07:00
4405136ffb
info_density: Declare em-based line-height vars for sidebar rows.
2024-05-31 15:18:06 -07:00
3d04f7dbda
info_density: Set a minimum line-height on body.
2024-05-31 15:18:06 -07:00
fd55da4ed8
requirements: Upgrade Python requirements.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-31 14:32:33 -07:00
e53e3af0f6
codespell: Fix spelling mistakes caught by codespell.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-31 14:32:33 -07:00
8aea76448f
copy_and_paste: Fix our logic being confused about selected messages.
...
If the selection stays inside a message header and there
are messages before the message header, our logic thinks `end_id`
is message before the header while `start_id` and `end_id` should
be that same.
It is best to just let browser handle the copy paste in this case.
2024-05-31 12:42:51 -07:00
6a811cb306
process_exporter: Use -recheck-with-time-limit to catch process renames.
2024-05-30 22:24:53 -07:00
2e6504cab7
puppet: Upgrade dependencies.
2024-05-30 22:24:53 -07:00
804c3706ff
tsconfig: Enable noUncheckedIndexedAccess.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 16:29:23 -07:00
4e91572c96
hello: Add safety assertions.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 16:19:15 -07:00
94f0f9340c
e2e-tests: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 16:19:14 -07:00
ed5f1455f2
e2e-tests: Consistently move fullname lookups to callers.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 16:19:00 -07:00
067a342b4e
upload_widget: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
6c0c19addb
upload: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
e134ad1363
unread_ops: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
07c220f08b
typing_events: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
83eb0a326a
typeahead_helper: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
d0a03be8e0
topic_list: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
c70799ca25
stream_list: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
e6358f5edc
settings_profile_fields: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
d49ad41a68
settings_emoji: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
11ab831e41
settings_components: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
fcf2e607c2
rendered_markdown: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
8417b54035
recent_view_ui: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
38b5fc32f7
playground_links_popover: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
c2c17dcd14
people: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
df849b294a
narrow_state: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
ab3110817f
narrow_banner: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
b953584d45
messages_overlay_ui: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
eddf79fca2
message_viewport: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
ad763ee7a7
message_list_data: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
d8a7d65647
markdown: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
74bfa62d78
left_sidebar_navigation_area: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
f15c2c5dfd
inbox_ui: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
6a429603ad
i18n: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
eedde08f24
hash_util: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:49 -07:00
fc17821119
hash_parser: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:48 -07:00
da7d8b902b
filter: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:48 -07:00
beef5d259b
dropdown_widget: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:48 -07:00
7303851fd5
drafts: Fix TypeScript noUncheckedIndexedAccess errors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-30 15:54:48 -07:00
Sayam Samal
Varun Singh
Karl Stolley
Anders Kaseorg
Aman Agrawal
Alex Vandiver