zulip

Author SHA1 Message Date

Author	SHA1	Message	Date
Tim Abbott	e729814cfd	recent_senders: Fix exception in certain typeahead flows. It appears that a regression introduced in `3f60074c33` caused undefined to be passed as the subject to the recent_senders library much more often; this fixing that, and makes the library handle such cases reasonably without an exception regardless. This was causing a huge number of "Tried to call a Dict method with an undefined key." exceptions.	2017-07-28 11:04:11 -07:00
Joshua Pan	9f9cb618c9	node tests: Get recent_sender.js to 100% node coverage.	2017-06-07 03:23:57 -06:00
Akhil	f04da3d52e	typeahead: Add recent_senders module. In recent_senders module, added a data structure to hold timestamps of users' latest message in a topic. Also added a function to compare 2 users based on above timestamp. Added a function to process messages for the data structure and a call in add_message_metadata. Also added node tests for insertion of data into recent_senders.senders.	2017-06-01 08:05:37 +00:00

Tim Abbott

e729814cfd

recent_senders: Fix exception in certain typeahead flows.

It appears that a regression introduced in
3f60074c33 caused undefined to be passed
as the subject to the recent_senders library much more often; this
fixing that, and makes the library handle such cases reasonably
without an exception regardless.

This was causing a huge number of "Tried to call a Dict method with an
undefined key." exceptions.

2017-07-28 11:04:11 -07:00

Joshua Pan 9f9cb618c9 node tests: Get recent_sender.js to 100% node coverage. 2017-06-07 03:23:57 -06:00

Akhil

f04da3d52e

typeahead: Add recent_senders module.

In recent_senders module, added a data structure to hold timestamps of
users' latest message in a topic. Also added a function to compare 2
users based on above timestamp. Added a function to process messages for
the data structure and a call in add_message_metadata. Also added node
tests for insertion of data into recent_senders.senders.

2017-06-01 08:05:37 +00:00

3 Commits