7581e0e1c5
settings: Remove remaining references to REALMS_HAVE_SUBDOMAINS.
2017-10-02 16:43:54 -07:00
edc10e8f51
test_decorators: de-inline REALMS_HAVE_SUBDOMAINS with statements.
...
This will significantly shrink the diff when we toggle
REALMS_HAVE_SUBDOMAINS soon.
2017-10-02 13:49:53 -07:00
5a27a4cf1c
decorator: Improve wrong-subdomain logging output.
...
Often, it's helpful to see both values in errors.
2017-10-02 13:31:20 -07:00
6327f30c76
test_decorators: Remove test_login_deactivated_realm.
...
This test was a duplicate of test_login_deactivated in LoginTest.
2017-10-02 11:42:15 -07:00
5475c5cedb
tests: Replace test_user_agent_parsing with a normal test.
...
Previously, this was its own separate test script; now it's a normal
part of the test suite.
Tweaked by tabbott to use a proper test method.
Fixes #6327 .
2017-09-16 03:56:18 -07:00
4a22316d90
test_decorator: Add explicit subdomains in tests.
2017-08-28 22:51:57 -07:00
4229faf36e
tests: Remove old six.PY2 code paths.
2017-08-25 11:05:16 -07:00
7d08ff69f0
tests: Remove most references to get_api_key.
...
This test helper doesn't really have value.
2017-08-24 23:30:46 -07:00
5206dad373
decorator: Fix is_browser_view handling of e.g. mobile apps.
...
We may end up with some endpoints that could be the browser or the
mobile apps, and we want the right default to happen here.
2017-08-24 16:26:57 -07:00
7ffc107061
decorator: Rename is_json_view to is_browser_view.
...
This improves clarity, now that we're planning to start logging in the
login/registration pages, which aren't browser views.
2017-08-24 16:25:08 -07:00
58edf75962
api: Allow incoming webhook bots to use the send_message API.
2017-08-22 10:06:34 -07:00
5a63ea0170
decorator: Extract validate_account_and_subdomain and deduplicate.
...
This fixes the significant duplication of code between the
authenticate_log_and_execute_json code path and the `validate_api_key`
code path.
These's till a bit of duplication, in the form of `process_client` and
`request._email` interactions, but it is very minor at this point.
2017-08-15 10:54:23 -07:00
3c37795675
decorator: Add localhost/Tornado hack to access_user_by_api_key.
...
This should make it possible to share that code with other code paths.
2017-08-15 10:54:23 -07:00
fc0144f6e4
test_decorators: Annotate fake Request as HttpRequest.
2017-08-05 17:53:18 -07:00
1e5aee054b
settings: Migrate main settings-change code to API.
...
This was one of the few major remaining endpoints that were still on
the old-style legacy API.
2017-07-31 13:08:06 -07:00
9bf02fb913
custom_profile: Prevent bot users from accessing endpoint.
2017-07-31 13:08:06 -07:00
93261e14b7
hotspots: Prevent bot users from accessing endpoint.
2017-07-31 13:08:06 -07:00
6a3c8ca2c5
push_notifications: Add human users only decorator.
...
This is part of #4517 .
2017-07-31 13:08:06 -07:00
6fe3748826
decorator: Remove redundant tests for api_key_only_webhook_view.
...
We do not need to test the exception message being logged in every
test case where an exception is raised by a webhook function.
Testing it once should be enough; this makes the tests less
verbose.
2017-07-20 10:30:03 -07:00
a24ea56c53
decorator: Handle invalid JSON in api_key_only_webhook_view.
...
Exception logging within api_key_only_webhook_view fails when
ValueError is raised if the request.body passed to ujson.loads
isn't valid JSON. In this case, we now just convert the payload
to a string and log that. This allows us to inspect JSON payloads
that aren't being decoded properly.
2017-07-19 10:42:35 -07:00
638b32542d
auth: Don't show deactivation notice to mirror dummies.
2017-07-05 23:50:53 -07:00
2f4091b38d
api: Fix caps in JSON validation error message.
2017-06-27 08:33:56 -04:00
4f223c19d8
sign-in: Show proper error for deactivated user.
...
Show a clear error message when a user tries to sign in with
a deactivated account.
Fixes #4757
2017-06-20 11:38:58 -04:00
42af09663d
validators: Add check_url validator.
...
This just uses Django's existing validator, and reformats its
interface to work with has_request_variables.
2017-06-15 15:03:26 -07:00
bb98e35aa0
Replace othello@zulip.com with example_email('othello').
2017-05-24 19:37:36 -07:00
c4db3b7d1c
Replace cordelia@zulip.com with example_email('cordelia').
2017-05-24 19:37:36 -07:00
5230eaef1c
Replace hamlet@zulip.com with example_email('hamlet').
2017-05-24 19:37:36 -07:00
6aaca44e17
tests: Fix str/Text mypy issues in various tests.
2017-05-24 15:19:38 -07:00
6c3f89af1c
tests: Remove get_user_profile_by_email from numerous tests.
2017-05-24 15:19:20 -07:00
6bc8424c71
Use self.example_user() in more places.
...
This fixes most cases where we were assigning a user to
the var email and then calling get_user_profile_by_email with
that var.
(This was fixed mostly with a script.)
2017-05-08 11:57:38 -07:00
7f5f4a511a
pep8: Add compliance with rule E261 to test_decorators.py.
2017-05-07 23:21:50 -07:00
e87e246fcb
zerver/decorator: Set request.client in api_key_only_webhook_view.
...
Previously, api_key_only_webhook_view passed 3 positional arguments
(request, user_profile, and client) into a function. However, most
of our other auth decorators only pass 2 positional arguments. For
the sake of consistency, we now make api_key_only_webhook_view set
request.client and pass only request and user_profile as positional
arguments.
2017-05-01 23:44:07 -07:00
73a1dd63d5
analytics: Refactor legacy 'zulip_internal' decorator.
...
Rename 'zulip_internal' decorator to 'require_server_admin', add
documentation for 'server_admin', explaining how to give permission
for ./activity page.
Fixes : #1463 .
2017-04-22 11:42:02 -07:00
cbc731963f
decorator: Add support for Django internal_notify_view.
2017-04-18 09:59:07 -07:00
0c8575e2dc
user_settings: Disable bot access to several endpoints.
...
These settings have no effect on bots, so this change is mostly about
just avoiding confusion.
2017-04-16 13:14:59 -07:00
e14c940ecc
decorator: Add human_users_only decorator.
...
Applies it to presence.update_active_status_backend as an example of usage.
2017-04-16 12:51:23 -07:00
118f2db22d
validators: Add a test_dict_only validator that bans other arguments.
...
This is primarily intended to be useful in EventsRegisterTest.
2017-03-26 13:10:54 -07:00
d1760a1bb9
validators: Add check_float validator.
2017-03-23 21:23:41 -07:00
ac20872f9d
request: Fix unnecessary translation tag for assertion.
2017-03-09 00:38:14 -08:00
8bdbcbc371
lint: Fix unnecessarily translated test file strings.
...
Our linter for translation strings shouldn't check test files, since
then we'll end up translating non-user-facing strings.
So we fix that, and actually add the opposite lint rule.
2017-03-09 00:37:44 -08:00
b6f53d6c14
coverage: bring zerver/lib/validator.py to 100% coverage.
2017-03-05 00:53:27 -08:00
2f8bb1b1cd
coverage: Add test for REST requests to /json API unauthed.
2017-03-05 00:53:27 -08:00
c8e38aaa55
coverage: Add coverage for OPTIONS HTTP method.
2017-03-05 00:53:26 -08:00
e95f139308
coverage: bring zerver/lib/response.py to 100% coverage.
2017-03-05 00:53:26 -08:00
89decf6ded
coverage: bring zerver/lib/request.py to 100% coverage.
2017-03-05 00:53:26 -08:00
1a8bc5f383
coverage: Bring test_decorators to 100% coverage.
2017-03-04 23:34:28 -08:00
a3a03bd6a5
mypy: Added Dict, List and Set imports.
...
Fixed mypy errors associated with the upgrade.
2017-03-04 14:33:44 -08:00
28d3af0965
Fix several new errors caught by mypy 0.501.
...
Clear out a bunch of easy to review errors, so we can focus on the more
complicated ones.
2017-03-03 14:12:52 -08:00
32bfebeb7a
mypy: Fix inconsistencies in use of *args/**kwargs.
2017-02-18 18:39:44 -08:00
5f2e320fee
Fix test_valid_api_key_if_user_is_on_wrong_subdomain.
...
This test would fail if settings.RUNNING_INSIDE_TORNADO
was True, which seemed to happen due to other tests changing
that setting, although I did not fully investigate.
2017-02-15 14:57:01 -08:00
Tim Abbott
invinciblycool
Anna Liao
Eeshan Garg
Umair Khan
Yago González
vaibhav
Vishnu Ks
Andrew Archer
Steve Howell
Aditya Bansal
Maxim Averin
Rishi Gupta
Raghav Jajodia