fead14951c
python: Convert assignment type annotations to Python 3.6 style.
...
This commit was split by tabbott; this piece covers the vast majority
of files in Zulip, but excludes scripts/, tools/, and puppet/ to help
ensure we at least show the right error messages for Xenial systems.
We can likely further refine the remaining pieces with some testing.
Generated by com2ann, with whitespace fixes and various manual fixes
for runtime issues:
- invoiced_through: Optional[LicenseLedger] = models.ForeignKey(
+ invoiced_through: Optional["LicenseLedger"] = models.ForeignKey(
-_apns_client: Optional[APNsClient] = None
+_apns_client: Optional["APNsClient"] = None
- notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- signup_notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ signup_notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- author: Optional[UserProfile] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
+ author: Optional["UserProfile"] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
- bot_owner: Optional[UserProfile] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
+ bot_owner: Optional["UserProfile"] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
- default_sending_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
- default_events_register_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_sending_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_events_register_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
-descriptors_by_handler_id: Dict[int, ClientDescriptor] = {}
+descriptors_by_handler_id: Dict[int, "ClientDescriptor"] = {}
-worker_classes: Dict[str, Type[QueueProcessingWorker]] = {}
-queues: Dict[str, Dict[str, Type[QueueProcessingWorker]]] = {}
+worker_classes: Dict[str, Type["QueueProcessingWorker"]] = {}
+queues: Dict[str, Dict[str, Type["QueueProcessingWorker"]]] = {}
-AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional[LDAPSearch] = None
+AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional["LDAPSearch"] = None
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-22 11:02:32 -07:00
ef070ef019
webhooks/github: Improve punctuation.
2019-05-09 13:05:49 -07:00
c4e4ceadb5
webhooks/git: Use proper punctuation for branch creation templates.
2019-05-07 16:45:01 -07:00
ab8aae6d0c
git_webhooks: Use proper punctuation for PR/issue messages.
2019-05-07 16:45:01 -07:00
9ed1dcc4b6
webhooks: Add Bitbucket Server integration.
...
This commit adds support for all "repo" events.
2019-03-24 22:06:29 -02:30
4a2a3e3640
webhooks/gitlab: Support issues with multiple assignees.
...
The fixtures added in this commit were generated by Adam Birds.
2018-12-27 20:15:00 -08:00
ea98a44db3
webhooks: Replace SUBJECT_WITH_* with TOPIC_WITH_*.
2018-11-12 15:47:11 -08:00
67045d65a9
webhooks/gitlab: Include title in Issue Hook event messages.
...
We already include the issue title in the topic. But if one chooses
to group all gitlab notifications under one topic, the message body
is misleading in the sense that only the Issue ID and the description
are displayed, not the title, which isn't super helpful if the topic
doesn't tell you the title either.
I think we should err on the side of always including the title in
the main message body, which is what this commit does.
Fixes #9913 .
2018-07-14 09:38:11 +05:30
1f9244e060
zerver/lib: Change use of typing.Text to str.
2018-05-10 14:19:49 -07:00
9161f8c39b
zerver/lib: Remove u prefix from strings.
2018-02-05 12:12:58 -08:00
bbf24ec68e
mypy: Use Python 3 syntax for typing in `zerver/lib/webhooks/git.py`.
2017-12-26 08:31:43 -05:00
3f4bf2d22f
zerver/lib: Use python 3 syntax for typing.
...
Extracted from a larger commit by tabbott because these changes will
not create significant merge conflicts.
2017-11-21 20:56:40 -08:00
09af29b051
zerver/lib: Text-wrap long lines exceeding 110.
2017-11-15 10:58:03 -08:00
fef7d6ba09
zerver/lib: Remove u prefix from strings.
...
License: Apache-2.0
Signed-off-by: rht <rhtbot@protonmail.com>
2017-11-03 15:34:37 -07:00
8e2cdedf9a
lint: Fix lines in Python codebase longer than 120 characters.
2017-10-26 17:47:30 -07:00
1761a3b1c1
mypy: strict optional fixes.
2017-05-24 18:50:59 -07:00
5687b2cdc5
webhooks/github*: Support pushing a local branch without commits.
...
Changes made to get_push_commits_event_message in
zerver/lib/webhooks/git.py are common to all Git integrations
that use get_push_commits_event_message. These include github,
github_webhook, gitlab, gogs, bitbucket, bitbucket2. In some
cases (for instance, gitlab), no further changes to gitlab/view.py
will be required to support pushing a local branch without commits;
adding a fixture and tests should suffice.
2017-05-16 23:51:19 -02:30
7227f488c8
webhooks: Add support for a GitHub push event deleting a branch.
...
Fixes : #4742 .
2017-05-16 00:11:20 -02:30
ffdd5d3588
webhooks: Don't display "Commits by" when committer is the only author.
...
For our Git integrations, we now only display the number of commits
pushed when the pusher also happens to be the only author of the
commits being pushed.
Part of #3968 .
Follow-up to #4006 .
2017-04-26 18:26:09 -02:30
b7ca533315
webhooks: Add a space between author and number of commits for Git messages.
...
For Git push messages, we now have a single space character between
the name of a commit's author and the number of commits by that
author, plus a period at the end.
Part of #3968 .
Follow-up to #4006 .
2017-04-26 18:26:09 -02:30
e7974b3b65
git: Fix nondeterministic ordering of commit authors.
...
This should fix the nondeterministic test failures introduced by
e7455e276b
2017-04-21 11:45:30 -07:00
e7455e276b
git integrations: Expand details in commit push notifications.
...
We now show a few new things:
(1) The number of commits pushed.
(2) Who authored the commits (just counts, not which specific ones, for brevity).
Add tests for case of multiple committers.
Part of #3968 .
2017-04-21 11:07:44 -07:00
9c5f1d2239
git.py: Add create branch event message.
2017-03-17 12:22:06 -07:00
282d27a934
git.py: Add setup webhook message.
2017-03-17 11:44:01 -07:00
19d1f4cab7
git integration: Change push commits message to show url at the end.
2017-03-16 11:06:03 -07:00
f066e3e8d6
git integrations: Change the limit of shown commits from 10 to 20.
2017-03-14 13:24:45 -07:00
a3a03bd6a5
mypy: Added Dict, List and Set imports.
...
Fixed mypy errors associated with the upgrade.
2017-03-04 14:33:44 -08:00
690d72d35f
mypy: Convert more zerver/lib files to typing.Text.
...
This commit touches files in zerver/lib/bugdown/ and
zerver/lib/webhooks.
2016-12-05 21:17:24 -08:00
074571dddc
Fix English grammar in push/remove tag message.
2016-11-15 10:48:12 -08:00
ed1d7f7997
Add is_truncated param to git integrations push commits event.
...
Add is_truncated param for cases when we know that there were more commits
but we dont know actual number and want just inform about existing of the rest.
2016-11-11 15:36:45 -08:00
6be27a1396
Add get_push_tag_event_message function to git integrations common (git.py).
2016-11-11 15:36:45 -08:00
4dd8cd9879
Replace "Commit" to commits sha in commits comment events in git integrations.
2016-11-02 22:19:51 -07:00
6ad4cce35c
Add object number/id to mention about Issue, PR, etc. to all git integrations.
2016-11-02 22:19:51 -07:00
89d53a0640
Change name of PR subject template to be applicable for issues.
2016-10-20 23:15:30 -07:00
289f400c8c
Add git integrations method to build message for issues events.
2016-10-20 23:15:30 -07:00
2941c1f517
Move converting commits data to text to separate function.
...
Create get_commits_content function for converting
commits list to text.
2016-10-14 16:54:13 -07:00
d2cedd3667
Rename consts in lib/webhooks/git.py to make it more general.
...
Rename:
PUSH_COMMITS_LIMIT to COMMITS_LIMIT
PUSH_COMMIT_ROW_TEMPLATE to COMMIT_ROW_TEMPLATE
PUSH_COMMITS_MORE_THAN_LIMIT_TEMPLATE to COMMITS_MORE_THAN_LIMIT_TEMPLATE
2016-10-14 16:54:13 -07:00
ee70cc5141
Add git integration method to build message for pull requests events.
2016-10-14 16:54:13 -07:00
312905007e
Add EMPTY_SHA const to zerver/lib/webhooks/git.py.
2016-10-10 17:39:05 -07:00
b69b5e55ce
Add git integration method to build message for remove branch events.
...
Add get_remove_branch_event_message method to zerver/lib/webhooks/git.py
for normalizing remove branch message in all git integrations.
2016-10-10 17:39:05 -07:00
5f7c1519d1
Add git integration method to build message for force push events.
...
Add get_force_push_commits_event_message method to zerver/lib/webhooks/git.py
for normalizing force push message in all git integrations.
2016-10-10 17:39:05 -07:00
32934a02e9
Add template for subject that contains repo name and branch name.
2016-10-10 17:39:05 -07:00
8697a1e5a2
Add common git integration method to build message for push events.
...
This adds get_push_commits_event_message method to
zerver/lib/webhooks/git.py for normalizing push messages in all git
integrations.
2016-10-10 17:32:41 -07:00
Anders Kaseorg
Eeshan Garg
Hemanth V. Alluri
Steve Howell
Aditya Bansal
rht
Viraat Chandra
Tim Abbott
Christian Hudon
Siddharth Mahapatra
Akash Kothawale
Raghav Jajodia
Mikebarson
Tomasz Kolek
Tomasz Kolek