7 Commits

Author	SHA1	Message	Date
Priyank Patel	261df2b4dc	js: Rename muting_ui module to muted_topics_ui.	2021-07-09 10:00:45 -07:00
Priyank Patel	5f74e78bee	js: Rename muting module to muted_topics.	2021-06-30 16:32:55 -07:00
Priyank Patel	4dac12144d	refactor: Rename variables that conflict with muting modules rename.	2021-06-30 16:32:55 -07:00
Abhijeet Prasad Bodas	fc53d2c66a	topic muting: Clean up live update code. ... Previously, we used to do a kind of "local echo" whenever the user muted/unmuted a topic. Meaning, we used to do most of the UI update work before making the API call to mute the topic, instead of after receiving the `muted_topics` event. This behavior has been so since the beginning of time (b4b6fa14d3) and isn't ideal because: 1. If the request fails on the backend, the UI could end up in an incorrect state. 2. Adds code complexity. 3. Makes it difficult to catch bugs related to live-update (like the one fixed by f725711ff2). 4. Isn't consistent with other parts of the codebase, which do the UI update while handling events. This commit makes it so that all the UI update work is done only after recieving the `muted_topics` event. The only possible issue with this strategy could be users sending another duplicate request in the small time span before receiving the event. But that isn't a big problem, because all requests involved here are idempotent, and the worst that can happen is a HTTP 400.	2021-04-27 17:53:06 -07:00
Abhijeet Prasad Bodas	2c4505d322	settings/muted-topic: Move list-create code to designated file. ... This code better fits in `settings_muted_topics`.	2021-04-27 17:53:06 -07:00
Abhijeet Prasad Bodas	eff16c934c	settings/muted-topics: Fix unnecessary use of stopImmediatePropogation. ... We do not have any other click handlers for the `settings-unmute-topic` class, so `stopPropogation` should be sufficient.	2021-04-27 17:53:06 -07:00
Abhijeet Prasad Bodas	586f8fe9e0	refactor: Rename settings/muted-topics code to be specific. ... This is a prep change for implementing mute users feature, which will add another settings page with similar naming conventions.	2021-04-05 18:04:31 -07:00