Tim Abbott
7fd2956f29
clear_followup_emails_queue: Rename confusing local variable.
2016-06-03 23:45:29 -07:00
medullaskyline
cb84f72f2d
Annotate zerver/lib/html_diff.py.
2016-06-03 23:21:26 -07:00
Tim Abbott
2ec0114079
test_bugdown: Add tests for mentions.
2016-06-03 23:18:39 -07:00
Tim Abbott
cfff4f1d49
test_bugdown: Add a bugdown test for alert_words functionality.
2016-06-03 23:18:39 -07:00
Tim Abbott
8c757292cf
test_bugdown: Add test for nonmatching realm filters.
2016-06-03 23:18:39 -07:00
Tim Abbott
3a0eb01dda
test_messages: Fix huddle test failing when not on Internet.
2016-06-03 23:18:39 -07:00
Tim Abbott
e89730dc8f
subject_links: Remove useless RealmFilter.DoesNotExist case.
2016-06-03 23:18:39 -07:00
Tim Abbott
68fba3579d
test_bugdown: Add testing of subject_links feature.
2016-06-03 23:18:39 -07:00
gregmccoy
d77e8df3fa
Add tests for zerver/views/realm_emoji.py.
2016-06-03 23:12:53 -07:00
Tim Abbott
03debdf82f
Fix malformed error message when creating invalid Realm Emoji.
...
Thanks to Greg McCoy for his help finding this bug.
2016-06-03 23:12:36 -07:00
David Adamec
8ad20e9775
mypy type annotations for zerver/lib/utils
2016-06-03 22:58:15 -07:00
Tim Abbott
a0b332d6cf
Add missing dependency decorator of ipython.
2016-06-03 19:29:54 -07:00
Tim Abbott
1552b9308b
Fix apnsclient import to match version 0.1.8 used in production.
...
Apparently, apnsclient moved Connection to a different module between
0.1.8 and 0.2.1.
2016-06-03 19:28:36 -07:00
Tim Abbott
9b86fa96e7
Downgrade python-apnsclient in development to match prod.
2016-06-03 19:27:34 -07:00
Tim Abbott
e7d9b28dfc
install-mypy: Pass --upgrade to correctly handle new mypy versions.
2016-06-03 19:11:32 -07:00
Max
0f4673ae3b
Add type annotation to mention.py, redis_utils.py, timestamp.py, user_agent.py
...
Some functions in models.py had input typed as int when they needed to be typed as datetime.datetime
2016-06-03 19:00:16 -07:00
Max
1148f6ff8a
Rename timestamp kwarg in to_presence_dict to dt
...
It is not a timestamp, it is a datetime object. This is better ducktyping
2016-06-03 19:00:16 -07:00
Tim Abbott
5d5f1f46dc
Upgrade mypy and typed_ast to latest versions.
2016-06-03 18:59:55 -07:00
Tim Abbott
654bd663aa
bugdown: Add annotations for a few more functions.
...
This resolves the issue with Typeshed #244 by making `upload_re` start
with `ur`.
2016-06-03 18:11:53 -07:00
Tim Abbott
f97b025a33
push_notifications: Fix incorrect Connection import.
2016-06-03 18:11:53 -07:00
medullaskyline
303bd21068
Annotate zserver.lib.push_notifications.
2016-06-03 17:45:54 -07:00
Oren Leaffer
2916fb30cb
bugdown: add some type annotations.
...
Had to add some "type: ignore" because the pattern used in match
doesn't affect the type returned. A fix for this issue has been pushed
to typeshed - https://github.com/python/typeshed/pull/244
2016-06-03 17:03:52 -07:00
medullaskyline
2213a9f41f
Annotate zerver/lib/cache_helpers.py
2016-06-03 16:34:30 -07:00
Sumana Harihareswara
8c2382deeb
De-duplicate three sections of architecture overview.
2016-06-03 12:56:31 -07:00
Conrad Dean
7f61a5e862
Add type annotations to zerver.lib.test_helpers.
2016-06-03 12:17:26 -07:00
Sumana Harihareswara
4a10923bf1
Add architectural overview documentation.
...
Fixes : #453 .
2016-06-03 11:54:02 -07:00
Max
a6e60419c4
Add types to confirmation/views.py and zerver/tornadoviews.py
2016-06-03 11:26:30 -07:00
Vishnu Ks
4fd569f910
Change add_default_stream method from PATCH to PUT.
...
This is more consistent with our other routes.
2016-06-03 09:52:51 -07:00
Nathan Florea
85c0da67a4
Changed make_request lambda to more readable function.
2016-06-03 09:17:04 -07:00
Nathan Florea
04c71fadc6
More removal of mutable default arguments.
...
I've left a few that clearly aren't being passed and aren't being mutated, but
I think I've gotten the rest of them.
2016-06-03 09:17:04 -07:00
Nathan Florea
5fe9076631
Remove some mutable default arguments.
...
These ones don't fix any bugs, because the mutable arg is never passed
outside of the callable or mutated. But it's good practice to not use
them in case those invariants are changed in the future.
2016-06-03 09:16:56 -07:00
Nathan Florea
2e4283f60a
api: Remove some mutable default arguments.
...
This could be more succinct with a conditional expression, but this is
easier to read.
2016-06-03 09:16:52 -07:00
Ashish Kumar
9b990e3bd0
Type annotation of zerver/views/alert_words.
...
[Tweaked by tabbott to annotate the REQ variables the new way]
2016-06-03 08:07:58 -07:00
Ashish Kumar
31bf6b8259
Type annotation of zerver/models.py
...
[Substantially revised by tabbott]
This probably still has some bugs in it, but having mostly complete
annotations for models.py will help a lot for the annotations folks
are adding to other files.
2016-06-02 23:28:34 -07:00
Tim Abbott
37015fd7c5
Run mypy on zerver/lib/test_auth_backends.py.
2016-06-02 23:01:15 -07:00
Tim Abbott
8cef9675c8
Run mypy on zerver/lib/test_events.py.
2016-06-02 23:00:04 -07:00
Tim Abbott
e6d2b0cdbc
Run mypy on zerver/lib/test_unread.py.
2016-06-02 22:59:00 -07:00
Tim Abbott
f3b07ee9aa
Run mypy on zerver/lib/test_subs.py.
2016-06-02 22:57:07 -07:00
Tim Abbott
1bdbdd1110
Run mypy on test files where it already passes.
2016-06-02 22:53:28 -07:00
Umair Khan
072551a94e
Fix most redownloading in 'vagrant reload --provision'.
...
Fixes #264 .
2016-06-02 22:32:56 -07:00
Oren Leaffer
c2ce5119c6
Annotate zerver.views.tutorial.
2016-06-02 18:49:27 -07:00
Conrad Dean
f8f2f45410
run-mypy: Add --linecount-report and --disallow-untyped-defs flags.
2016-06-02 18:45:52 -07:00
acrefoot
cf15b0b4e6
Fix hanging nc and 'invalid wait time' error on Trusty.
...
Apparently, 0 isn't a supported wait time value in some versions of nc.
2016-06-02 18:02:13 -07:00
Rachel Kelly
df36216914
Change instances of 'coworkers' to 'users'.
...
In order to genericize use of Zulip outside companies,
all instances of coworkers have been changed to users.
NOTABLE EXCEPTION: When the Zulip instance is domain-
locked, the reference to coworkers remains. The reason
for this is twofold: first, the majority of Zulip instances
which require a particular domain will be locked to a
company, and second, the template variable for the domain
necessary should be added to the alert so it is clear
to the user what the domain needs to be for access.
Fixes : #861 .
2016-06-02 16:05:27 -07:00
Pei-Wei Wu
8d2733ae8c
Add mypy type annotations to zerver/views/streams.py.
2016-06-02 15:44:43 -07:00
Ashley Dunn
7826aa7e7f
Type annotation of zerver/views/realm_emoji.
2016-06-02 14:01:28 -07:00
John Hampton
d4dbcb80cc
README.prod.md: Remove redundant unpacking of the tarball.
2016-06-02 10:32:52 -07:00
Taranjeet
a45bde7822
Docs: Fix typos in docs.
2016-06-02 10:31:41 -07:00
Ashish Kumar
cad342aff6
Correct annotation of generic_bulk_cached_fetch in zerver/lib/cache.py.
...
Previously, object_ids was tagged as an int, but it is called from
models.py with a string, so we make it an Any.
2016-06-01 14:00:49 -07:00
Tim Abbott
44929523d6
Harden extraction of AUTH_LDAP_BIND_PASSWORD.
2016-05-31 15:06:43 -07:00