Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
44,372 Commits 28 Branches 142 Tags 698 MiB
Commit Graph

5 Commits

Author SHA1 Message Date
Anders Kaseorg f1a9c87897 openapi: Add missing object types. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-12 16:11:29 -07:00
Anders Kaseorg 06691e1e45 prettier: Disable bracketSpacing. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-17 14:30:52 -07:00
Anders Kaseorg 2794bc1ef4 lint: Reformat YAML files with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-14 16:25:31 -07:00
orientor 529da34513 openapi: Use third-party validator for schema validation. 
Our previous OpenAPI schema validator that we implemented ourselves
was useful training wheels for our understanding OpenAPI properly, and
was mostly correct.  But given that we've finally reached the point
where our OpenAPI file accurately describes the API, it makes sense to
switch to use an official OpenAPI validator.  We lose some ability to
do exclude rules for particular elements, but those were primarily
important for us when we had a lot of them.

As part of this change, we need to add `additionalProperties: false`
for all of our dictonaries/objects where we've documented every
parameter; otherwise the OpenAPI schema checker won't know that we
expect every parameter to be documented.
 2020-07-01 11:21:41 -07:00
orientor fbf647283b openapi: Fix validate_against_openapi_schema nested object validation. 
We had a bug in `validate_against_openapi_schema` that prevented it
from correctly inspecting nested arrays.

Fix the bug and address all the exceptions, either via
EXCLUDE_PROPERTIES or fixing them when simple.  Also add a test case
for nested verification.
 2020-06-20 13:23:39 -07:00