neiljp (Neil Pilgrim)
357c9ed016
mypy: Pass empty dict to makeRecord for args, instead of None.
2017-08-09 18:04:21 -07:00
neiljp (Neil Pilgrim)
a6bb8f552b
mypy: Mark get_session_user() as returning Optional[int].
2017-08-09 18:04:21 -07:00
Tim Abbott
1d10941712
register: Don't display field to enter password unless needed.
...
This should significantly improve the user experience for new users
signing up with GitHub/Google auth. It comes complete with tests for
the various cases. Further work may be needed for LDAP to not prompt
for a password, however.
Fixes #886 .
2017-08-09 13:44:57 -07:00
Umair Khan
2c9a57161a
registration: Add test for password less remote reg.
2017-08-09 13:44:57 -07:00
Umair Khan
4a3fde023f
google: Respect is_signup argument.
...
This allows us to go to Registration form directly. This behaviour is
similar to what we follow in GitHub oAuth. Before this, in registration
flow if an account was not found, user was asked if they wanted to go to
registration flow. This confirmation behavior is followed for login
oauth path.
2017-08-09 13:44:57 -07:00
Umair Khan
5d0ac49f12
registration: Password should be required in form.
...
Password field should be optional only when password auth backend is not
enabled or when password is not required as in Google or GitHub
registration.
2017-08-09 13:44:57 -07:00
Umair Khan
bb0eb76bf3
github: Don't ask for password in registration.
2017-08-09 13:44:57 -07:00
neiljp (Neil Pilgrim)
82bac5ca11
Webhook: Remove duplicate trello code.
2017-08-08 15:55:09 -07:00
Vishnu Ks
f0bb11ef40
management: Use self.get_user in convert_bot_to_outgoing_webhook.
2017-08-08 14:13:19 -07:00
Vishnu Ks
d1bece2ec2
management: Use self.get_realm in create_stream.
2017-08-08 14:13:19 -07:00
Vishnu Ks
9fb5381acb
management: Use self.get_realm in set_default_streams.
2017-08-08 14:13:19 -07:00
Vishnu Ks
3bc475d04f
management: Use self.get_realm in rename_stream.
2017-08-08 14:13:19 -07:00
Vishnu Ks
4e7dbff197
management: Use self.get_realm in realm_filters.
2017-08-08 14:13:19 -07:00
Vishnu Ks
7859ec76cf
management: Use self.get_realm in realm_emoji.
2017-08-08 14:13:19 -07:00
Vishnu Ks
af1c1861da
management: Use self.get_realm in realm_domain.
2017-08-08 14:13:19 -07:00
Vishnu Ks
1b0b135bfc
management: Remove unused imports from process_queue.
2017-08-08 14:13:19 -07:00
Vishnu Ks
0532b35c43
management: Remove unused imports from print_email_delivery_backlog.
2017-08-08 14:13:19 -07:00
Vishnu Ks
164badde13
management: Use self.get_realm in merge_streams.
...
The variable encoding is removed becuase it is not used
anywhere.
2017-08-08 14:13:19 -07:00
Vishnu Ks
6b46762384
management: Fix typo in get_realm CommandError message.
2017-08-08 14:13:19 -07:00
Vishnu Ks
27936fcfd4
management: Remove unused imports from makemessages.
2017-08-08 14:13:19 -07:00
Vishnu Ks
cf61349563
management: Use self.get_realm in logout_all_users.
2017-08-08 14:13:19 -07:00
Vishnu Ks
e28a007487
management: Use self.get_user in knight command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
3a2edc66f1
management: Use get_system_bot in initialize_voyager_db.
2017-08-08 14:13:19 -07:00
Vishnu Ks
f45b80aafe
management: Remove unused imports from initialize_voyager.
2017-08-08 14:13:19 -07:00
Vishnu Ks
05af206392
management: Remove unused imports from import command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
f58efdc3cb
management: Remove unused imports from export_usermessage_batch.
2017-08-08 14:13:19 -07:00
Vishnu Ks
28e76c990a
management: Remove unused imports from email_mirror command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
6687b236bf
management: Remove unused imports from deliver_email command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
b8dacf9bf6
management: Remove unused import from checkconfig command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
5ce0d85ccf
management: Remove unused import from check_redis command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
19f8da4995
management: Use self.get_realm in export command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
4e9dff09fd
management: Use self.get_realm in dump_messages.
2017-08-08 14:13:19 -07:00
Vishnu Ks
bc48c68c09
management: Use self.get_realm in reactivate_realm command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
279af33ea2
management: Use self.get_realm in deactivate_realm.
2017-08-08 14:13:19 -07:00
Vishnu Ks
349d604ad5
management: Use self.get_realm in create_user.
2017-08-08 14:13:19 -07:00
Vishnu Ks
679fece79d
management: Add argument for specifying help in add_realm_args.
2017-08-08 14:13:19 -07:00
neiljp (Neil Pilgrim)
b782db48e1
mypy: Remove superfluous older 'type: ignore' annotations.
2017-08-08 11:27:51 -07:00
neiljp (Neil Pilgrim)
67f1a72aae
mypy: Ensure events test fails only due to settings absence.
2017-08-07 21:27:50 -07:00
neiljp (Neil Pilgrim)
3711da0dc9
mypy: Mark request_data as Optional based on requests API.
2017-08-07 21:27:50 -07:00
neiljp (Neil Pilgrim)
116b8dd9c9
mypy: Set assign_queue() parameter queue_type to not be Optional.
2017-08-07 21:27:50 -07:00
neiljp (Neil Pilgrim)
24cc14c10d
mypy: Refer to default_stream in if statement, allowing type inference.
2017-08-07 21:27:50 -07:00
neiljp (Neil Pilgrim)
60baedcab9
mypy: strict-optional fixes for Trello integration.
2017-08-07 21:27:50 -07:00
neiljp (Neil Pilgrim)
d9e36c8156
mypy: strict-optional fixes in zerver/tornado/socket.py.
2017-08-07 21:27:50 -07:00
Jack Zhang
d9c1ad5db2
hotspots.py: Add SEND_ALL flag.
...
Used to view all hotspots in development.
2017-08-05 18:32:37 -07:00
Harshit Bansal
5a5072730c
realm_emoji: Don't accept animated realm emoji with unequal dimensions.
...
Fixes : #3654 .
2017-08-05 18:07:21 -07:00
neiljp (Neil Pilgrim)
334348cbca
mypy: Use namedtuples for request objects in test_messages.py.
2017-08-05 17:53:18 -07:00
neiljp (Neil Pilgrim)
6bed9da353
mypy: Amend flock contextmanager to accept Union[int, IO[Any]].
2017-08-05 17:53:18 -07:00
Tim Abbott
fc0144f6e4
test_decorators: Annotate fake Request as HttpRequest.
2017-08-05 17:53:18 -07:00
Tim Abbott
4bb979d869
test_helpers: Fix annotation for avatar_disk_path.
2017-08-05 17:53:18 -07:00
neiljp (Neil Pilgrim)
3ca34bebdc
mypy: Use Callable as parameter for simulated_queue_client.
...
Previously the type was annotated as 'type'.
2017-08-05 12:08:59 -07:00