3557c47d76
node tests: Enforce 100% node coverage in user_events.js.
2017-06-23 16:05:16 -04:00
eb39e82629
Update enforce_fully_covered list with pm_list.js.
2017-06-23 11:13:47 -04:00
18eeb962fe
setup-static-analysis: Add wrapper to retry dependancy installation.
2017-06-23 08:23:45 -04:00
a20249b126
tooling: Add tool to clear unused emoji cache.
...
In this commit, we are adding a new tool which can be used to
clear out the emoji cache. Cache cleanup is a good thing to in
general and as well helps keep travis cache small (meaning faster
builds).
Credits to @HarshitOnGitHub as well for suggesting the use of
emoji symlink.
2017-06-22 19:17:12 -04:00
0b03fd97a2
webpack: Don't include katex bundle in base.html.
...
Since we use katex only in the main webapp, we don't need it in things
like landing page etc, so it is better to move it to index.html.
2017-06-22 19:06:32 -04:00
99b12ed0ca
webpack: Use `common.js` to inject webpack dependencies in dev.
2017-06-22 19:06:32 -04:00
c0e4f24a25
webpack: Migrate `common.js` bundle to webpack.
2017-06-22 19:06:32 -04:00
0e24930770
provision: Avoid spending ~3s on apt operations in no-op provision.
...
Fixes #5186
2017-06-22 09:37:40 -04:00
0ed4e22e54
docs: Fix lint/whitespace errors in GCI docs.
2017-06-22 09:30:28 -04:00
d45d9c9ab5
bots: Add linter rule to prevent open() calls.
...
Addresses #5395 .
2017-06-21 10:16:59 -04:00
fd41a481e4
linter: Fix `include_only` rule path comparison.
...
In order for the `include_only` linter rule to not have
any side effects, we need to explicitly add a trailing '/'
after every directory we want to include.
2017-06-21 10:16:59 -04:00
e49afe3ebc
lint: Add code to suggest removing exclusions.
...
If excluded lines no longer exist in a file, print a message
asking the user to remove the exclusion.
2017-06-21 08:12:58 -04:00
bd9459f27d
node test: Enforce 100% node coverage in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
572ea370ea
Speed up custom checkers in `./tools/lint`.
...
The main thing here is to make looping over lines be the inner
loop, instead of looping over rules. This keeps regexes in
cache, and it also avoids some O(N) checks.
This is a significant speedup for me, reducing time from 16s
to 11s.
2017-06-20 22:26:12 -04:00
c50b3672c2
webpack: Migrate `signup.js` bundle to webpack static asset pipeline.
2017-06-20 09:45:26 -04:00
3953734a1c
webpack: Migrate `stats.js` bundle to webpack static asset pipeline.
2017-06-20 09:45:26 -04:00
bccd2caacb
testing: Fix search key.
...
The problem this commit solves is related to how we search for
testcases in the test files. We use a simple 'search_key' in file_data.
This will return a false positive if there is a 'longer_search_key' in
file_data.
While searching for TestCases we should use a longer key to remove the
possibility of collision. Using 'class TestCase(' should be precise
enough.
Fixes #4983
2017-06-20 08:35:07 -04:00
9777496046
repository: Update information with Codecov migration.
2017-06-20 07:17:39 -04:00
b19134d4c2
travis: Remove docker-engine from held package list in production.
...
We are doing this in order to avoid facing troubles when travis
updates its trusty images. Here is a link to the blog post.
https://blog.travis-ci.com/2017-06-19-trusty-updates-2017-Q2
2017-06-20 06:45:40 -04:00
005d06eb38
message_store.js: Add tests for message id change.
...
This gets message_store.js to 100% line coverage.
2017-06-20 06:24:27 -04:00
7980462010
setup-backend: Add wrapper to retry provisioning in case it fails.
...
In this commit we add a wrapper around the provisioning inside
setup-backend to trigger another try at provisioning if it fails
in hopes of it will run this time fine if it was interuppted by a
network issue the first time.
Fixes : #2034 .
2017-06-19 16:14:11 -04:00
924d8266c0
setup-production: Add a wrapper to retry provisioning when it fails.
...
In this commit we basically add a wrapper around provisioning
inside setup-production to trigger a retry in case of failure.
2017-06-19 16:14:11 -04:00
fab4a30cce
production-helper: Add wrapper to retry apt-get dist-upgrade.
...
In this commit we add a conditional inside production helper to just
re run apt-get dist-upgrade in case it fails the first time.
2017-06-19 16:14:11 -04:00
33c0c00cd6
Outgoing webhook System: first Iteration of outgoing webhook UI.
2017-06-19 16:05:54 -04:00
23dc32a0f3
node tests: Enforce 100% coverage in markdown.js and presence.js.
2017-06-19 08:00:55 -04:00
d1408125b2
tools: Make sure missing lines in node test coverage are correct.
2017-06-19 07:59:50 -04:00
7de4c340f6
tooling: Add tool to clean unused NPM cache.
2017-06-19 07:55:23 -04:00
e9fd41bb66
lint: Check if the first word of a commit message is imperative.
...
Only check the first word using a black list approach to reduce
force positive as shown in the current implementation.
2017-06-19 07:01:52 -04:00
7f8ecb62c9
fenced_code.js: Improve coverage to 100%.
2017-06-19 06:53:25 -04:00
eeabc0f6a3
Django 1.11: Bump Django version to 1.11.
...
This commit also makes the following changes:
* Bumps the version of Django to 1.11.2.
* Fixes the HTTP response headers. Now CommonMiddleware sets Content-Length
header for non-streaming response, see
https://docs.djangoproject.com/en/1.11/ref/middleware/#module-django.middleware.common .
Due to this, 'Transfer-Encoding: chunked' header is removed, which signifies
a streaming response.
2017-06-15 14:44:38 -07:00
a2b5d6efcb
provision: Add wrapper to retry apt-get install if it fails first time.
2017-06-14 21:49:15 -07:00
3bc369f1cf
tools: Add wrapper tool 'build-docs' for building documentation.
2017-06-14 20:16:02 -07:00
bbe7ef6c5e
linter_lib: Exclude webhook URLs from long line checks.
...
Now, URLs starting with `{{ external_api_uri_subdomain }}` are
exempted from the 120 char per line requirement.
2017-06-14 17:42:17 -07:00
914ab1040d
integrations/codebase.html: Migrate to Markdown.
2017-06-13 16:32:00 -07:00
4d66d74938
check-templates: Remove exclude for some migrated files.
...
This integration docs have all been moved to markdown.
2017-06-13 16:30:27 -07:00
9a38b51254
check-templates: Fix filter condition in Jinja2 template linting.
...
In this commit we basically stop ignoring 'base.html' from linting
point of view. Basically the condition was implemented in a bad way
resulting in ignorance of every template ending with `base.html`.
As well since removing it doesn't complain about the base.html
non parsable(We have made progress with our linter) we can safely
remove the filter condition.
2017-06-14 04:48:07 +05:30
9cc3e8cf62
followup_day2.html: Cleanup to use 4 space indentation.
2017-06-14 04:48:07 +05:30
39a88019f8
followup_day1.html: Cleanup to use 4 space indentation.
2017-06-14 04:48:07 +05:30
9a0edad604
find_team.html: Cleanup to use 4 space indentation.
2017-06-14 04:48:07 +05:30
9fc16888ca
digest.html: Cleanup to use 4 space indentation.
2017-06-14 04:48:07 +05:30
fa28dcd008
invitation_reminder.html: Cleanup to use 4 space indentation.
2017-06-14 04:48:07 +05:30
07e7482228
confirm_registration.html: Cleanup to use 4 space indentation.
2017-06-14 04:48:07 +05:30
1b82e90331
invitation.html: Cleanup to use 4 space indentation.
2017-06-14 04:48:07 +05:30
e12bb65c0b
confirm_new_email.html: Cleanup to use 4 space indentation.
2017-06-14 04:48:07 +05:30
28874cf26f
webpack: Add --minify option to run-dev.py for to test minification.
2017-06-13 12:45:40 -07:00
1e5ce918e3
webpack: Move app_debug.js to webpack bundle.
2017-06-13 12:45:40 -07:00
04626acd5a
webpack: Move zxcvbn.js to webpack bundle.
2017-06-13 12:45:39 -07:00
ae29d4b8d2
webpack: Move landing-page.js to webpack bundle.
2017-06-13 12:36:55 -07:00
2c6f2fb93a
webpack: Move activity js to webpack.
2017-06-13 12:36:51 -07:00
8e33d9e48b
travis: Update held packages list in production tests.
2017-06-13 11:12:26 -07:00
d2f0e17454
linter: Fix bug resulting in <pre> being indented cyclically.
2017-06-13 08:39:59 -04:00
ef2c0f806e
update-prod-static: Add code to copy CSS from node_modules
2017-06-11 10:15:48 -07:00
e30e244b29
emoji: Moved `unified_reactions.json` file.
...
Moved `unified_reactions.json` file from `tools/setup/emoji` to
`zerver/management/data` so that it can be used in production
environment.
2017-06-09 16:38:58 -07:00
6219128d87
dev: Add /emails/ URL for testing email templates.
...
Fixes #5270 .
2017-06-09 16:21:49 -07:00
6653e19e3a
Add URL for viewing node coverage data on dev server.
...
Running test-js-with-node --coverage now provides a URL
to view the output data on the web.
Fixes #5177 .
2017-06-09 16:17:30 -07:00
8c0e500d6b
webpack: Migrate api and katex js files to Webpack bundler.
...
This also injects the dev webpack sockets to katex, since that's part
of the main web app bundle.
2017-06-09 12:33:52 -07:00
a72b1bd98e
node tests: Enforce 100% test coverage for util.js.
2017-06-07 23:26:46 -07:00
fdb244fd3b
node tests: Add support for enforcing 100% test coverage.
...
Fixes #5178 .
2017-06-07 22:13:02 -07:00
ae7781dd76
Fix bug in pep8 linter.
...
Basically pep8 linter was not running on a selected ignore list of
files for which an extra pep8 rule e261 was to be ignored.
2017-06-07 16:00:01 -06:00
24b1efc74e
Fix pep8 linter bug.
...
In this commit we fix the bug where pep8 linter does not report
false and exit when we got linting issues.
2017-06-07 14:05:03 -07:00
821ff06629
Add `unified_reactions.json` to be used for reactions migration.
...
This file contains the mapping from old emoji names to new codepoints
from iamcal's dataset to be used in reaction migration.
2017-06-06 23:52:41 -07:00
8f8149c0a5
Clean invite_user.html to use 4 space and consistent indentation.
2017-06-06 22:04:55 -07:00
8555770646
Clean zephyr.html to use 4 space and consistent indentation.
2017-06-06 22:04:55 -07:00
864ee6aaf9
Clean left_sidebar.html to use 4 space indentation.
2017-06-06 22:04:55 -07:00
9219298774
Clean main.html to use 4 space indentation.
2017-06-06 22:04:55 -07:00
f9edf8bc0e
Clean accounts_home.html to use 4 space and consistent indentation.
2017-06-06 22:04:32 -07:00
f58d102664
Clean confirm_email_change.html to use 4 space indentation.
2017-06-06 22:00:37 -07:00
d8bfeb6b98
Clean realm_summary_table.html to use 4 space indentation.
2017-06-06 22:00:36 -07:00
f2679448e8
Clean ad_hoc_query.html to use 4 space indentation.
2017-06-06 22:00:36 -07:00
1143aec53b
Clean 404.html to use 4 space indentation.
2017-06-06 22:00:36 -07:00
cb36ce26de
Remove files from ignore list which were migrated to markdown.
2017-06-06 22:00:36 -07:00
c579a0515b
Clean confirm.html to use 4 space and consistent indentation.
2017-06-06 21:28:08 -07:00
2215af4b57
docs: Add a bunch of documentation on Travis CI.
2017-06-06 13:39:51 -07:00
1d183eabf1
testing: Write the .coverage file.
...
We need to call save explicitly to make coverage write the
.coverage file.
2017-06-06 08:03:30 -07:00
a926559889
testing: Use concurrency parameter.
...
Coverage includes a concurrency parameter which can be used
to track files if multiprocessing is used.
2017-06-06 08:03:25 -07:00
b09b60dfff
Revert "test-backend: Enable test coverage in multi-process mode."
...
This reverts commit a22d6d2c2a
2017-06-06 13:07:16 +05:00
fab20ec6fd
templates: Add macro for appending branch names to Git webhook URLs.
2017-06-05 11:20:48 -07:00
a606628b16
Extract tools/linter_lib/pep8.py
2017-06-05 09:20:21 -07:00
9fab41aebb
Extract tools/linter_lib/pyflakes.py
2017-06-05 09:20:21 -07:00
29affda956
Extract tools/linter_lib/exclude.py
2017-06-05 09:20:21 -07:00
40a2ffad98
Extract tools/linter_lib/custom_check.py.
...
As part of extracting this, we exempt the library from all custom
checks on itself. This is expedient, since a lot of our
custom checks are naive about whether things are in strings, and
it is also a pain to configure individual rules.
2017-06-05 09:20:21 -07:00
8ee50f019b
lint: Add "nolint" handling for custom checks.
2017-06-05 09:20:21 -07:00
acefc67f2f
lint: Start enforcing PEP-E261 by default in our linters.
...
In this commit we start to check for violations to PEP-E261 in our
codebase by default in our linters. Also we have introduced a
ignore list which has around 20 files still in violation to
PEP-E261 which we intend to clear up soon.
2017-06-04 09:18:23 -07:00
a9e6106d54
pep8: Add compliance with rule E261 lint.
2017-06-04 09:18:22 -07:00
1be11cbb56
pep8: Add compliance with rule E261 replace-tarball-shebang.
2017-06-04 15:06:12 +05:30
a9e0dbe085
pep8: Add compliance with rule E261 pretty_print.py.
2017-06-04 15:05:51 +05:30
ba74d74dca
lint: Fix incorrectly placed docstring.
2017-06-03 16:02:24 -07:00
9602f73d05
lint: Add validation for the Swagger file.
2017-06-03 15:48:04 -07:00
99b004942f
lint: Explain the purpose of target_langs.
...
Tweaked by tabbott to be a longer docstring.
2017-06-03 15:48:00 -07:00
23baaae980
travis: Stop deleting npm cache in production tests.
...
Now that we're not using the copy_modules functionality (basically
because including node_modules in production tarballs was a huge disk
sink), the production Zulip code isn't using `zulip-npm-cache` anyway.
And deleting that cache had a huge impact on the performance of the
development environment provisioning that we do as part of this suite.
Commit message rewritten by tabbott.
2017-06-03 15:29:08 -07:00
c065f23090
tools: Remove build-api-tarball.
2017-06-02 17:08:00 -07:00
cecf7f1740
provision: Don't regenerate dev database unnecessarily.
...
This reuses the work we did some time ago to avoid regenerating the
test database unnecessarily.
In addition to being a nice convenience for developers (since any
accomulated test data is still available), this also saves about half
the time consumed in a no-op provision.
Fixes #5182 .
2017-06-02 13:27:34 -07:00
a0ef2babab
text_fixtures: Rename migration status file to have test in name.
...
This is preparation for making things clear as we move towards not
always rebuilding the test database in provision.
2017-06-02 13:27:34 -07:00
829491fde7
webhooks/papertrail: Migrate docs to Markdown.
2017-06-01 22:16:12 -07:00
5d868b1612
webhooks/helloworld: Migrate docs to Markdown.
2017-06-01 22:16:12 -07:00
ccd079b425
webhooks/solano: Migrate docs to Markdown.
2017-06-01 22:16:12 -07:00
bf2bc8d44b
lint: Allow empty string in alt arg.
2017-06-01 22:07:43 -07:00
a4b76e78ac
tools: Update clean-branches to clean review branches.
2017-06-01 21:55:33 -07:00
443e31e348
tools: Add script to see PRs as authors intended.
2017-06-01 21:55:08 -07:00
db9918f3d6
bots: Move contrib_bots to api/bots*.
...
This will make it convenient to include these bots in Zulip API
releases on pypi.
Fix #5009 .
2017-06-01 12:31:54 -07:00
feffbb963b
pep8: Add compliance with rule E261 run-mypy.
2017-05-31 17:07:15 -07:00
5b0b8fd8bb
pep8: Add compliance with rule E261 emoji_setup_utils.py.
2017-05-31 17:07:15 -07:00
be66369b72
pep8: Add compliance with rule E261 tools/js-dep-visualizer.py.
2017-05-31 17:07:15 -07:00
2efecd4809
webpack: Fix webpack-dev-server to not inline serve bad sockjs url.
...
Fixes #5118 .
2017-05-31 09:31:29 -07:00
eb1a22a1d2
webpack: Fix webpack-dev-server urls for external resources.
...
This fixes issues some users found using the remote development environment.
2017-05-30 22:38:25 -07:00
e321891f17
test-all: Don't run SVG optimizer by default.
2017-05-30 11:19:53 -07:00
0600e1eb30
tools: Add optimize-svg tool for checking for unoptimized SVG files.
2017-05-30 11:15:56 -07:00
4040cadf7d
coverage: Omit some test runner files from coverage.
...
These files are part of the test runner and can't realisitically have
test coverage due to being imported before coverage in the setup
sequence.
2017-05-29 15:30:49 -07:00
ce26f0e086
integrations: Remove legacy basecamp integration.
...
Now that we have the webhook integration, there's no reason to
maintain the pre-webhook version.
2017-05-29 15:10:59 -07:00
2d73e03e37
ui-refactor: Rename modals.js to overlays.js.
...
Fixed #4702 .
2017-05-29 11:24:46 -07:00
5ffdce9aab
test-js-with-node: Set timezone to UTC for tests.
2017-05-29 08:47:26 -07:00
5f48b51b60
provision: Add `cd /srv/zulip` to profile.
...
I didn't bump the provision version on this change, as it
won't break anything if somebody fails to make this change.
2017-05-29 08:40:49 -07:00
bbb3aad611
Add typescript support to asset compilation.
2017-05-28 17:28:28 -07:00
9b8641d9eb
lint: Add iOS to list of valid weird capitalizations.
2017-05-26 20:59:32 -07:00
7f43ec05f2
lint: Add rule to check alt arg for translation.
2017-05-26 15:28:46 -07:00
ad5780c03e
lint: Mark alt argument for translation.
2017-05-26 15:28:46 -07:00
ccb4c5c26f
bots: Move zephyr-related files to api/integrations/zephyr/.
2017-05-26 15:07:02 -07:00
a1f82e02d6
python: Replace os.system with subprocess.call.
...
Generally, we avoid os.system, since it shells out and thus can be
a cause of security issues.
2017-05-26 15:03:16 -07:00
024101be6b
bots: Add mypy annotations for bots framework.
...
This commit adds mypy annotations for both the main
bots and the bots testing runner. It involves a change
to the BotHandlerApi send_message and update_message
funtions, which is compatible with every bot.
Tweaked by tabbott to use more expressive annotations.
2017-05-26 10:25:06 -07:00
cb311e99d8
Change backend tests to use a webpack stats stub file.
2017-05-25 16:15:32 -07:00
de98dd127d
Remove webpack dependency from tools/minify-js.
2017-05-25 16:15:32 -07:00
fb0d2d6a8e
webpack: Move assets to a separate JSON file so we can process in python.
2017-05-25 16:15:32 -07:00
2d5097868a
webpack: Skip compilation for minified 3rd party libs.
2017-05-25 16:15:32 -07:00
6d2a82ee3c
build-release-tarball: Give helpful message on update-prod-static failure.
2017-05-24 19:17:00 -07:00
3f5d0e69fb
Build and handle jsfiles using webpack instead of django-pipeline.
...
Also renames bundle.js to translations.js.
2017-05-24 18:38:03 -07:00
4f39d4fc22
Split webpack config into 3 files (base, dev, production).
2017-05-24 18:37:58 -07:00
e9b3b56105
webhooks/appfollow: Use parametric Markdown macros.
2017-05-24 17:00:19 -07:00
2e4078cbd2
update-prod-static: Redirect update-authors-json stderr to log file.
2017-05-24 16:44:02 -07:00
8aaf9b1426
Revert "Fix emoji cache setup when not using provision.py."
...
This reverts commit ab2cfadcaa
2017-05-24 10:35:41 -07:00
6038777891
npm: Upgrade webpack to 2.0 version dev and production.
2017-05-23 23:58:25 -07:00
2314c0fb1b
tools/minify-js: Improve type checking.
...
* Use Optional where needed.
* Add type to variables because otherwise it'll be Any.
2017-05-23 22:02:41 -07:00
b805e0ca10
mypy: Assert non-Noneness.
...
Convince mypy that an object cannot be None by using an assert.
2017-05-23 21:56:50 -07:00
7636972a6c
mypy: Wrap return value in Optional.
2017-05-23 21:56:50 -07:00
cc1937c8d5
mypy: Use Optional with strings where required.
2017-05-23 21:56:50 -07:00
481d14df39
mypy: Remove a type: ignore.
...
https://github.com/python/typeshed/pull/693 was merged.
2017-05-23 21:56:48 -07:00
5003283b64
Enforce 100% test coverage for lib/avatar.py.
2017-05-23 20:07:07 -07:00
a22d6d2c2a
test-backend: Enable test coverage in multi-process mode.
...
We enable data_suffix option when creating Coverage instances which
causes the output files to include the hostname, pid, and random id.
Before each run erase is called which clears all existing coverage data
files. And then at the end of the test run use the combine method which
merges the reports.
We collect coverage in the main process which collects data from
imports and also when running in single process mode. In the workers we
collect coverage in run_subsuite. This creates more stats files than
strictly required but I don't see a better place to save the stats when
stopping workers.
Note that this has the side effect of enabling parallel testing in
Travis CI.
2017-05-23 18:25:13 -07:00
ecdc500440
test-backend: Run only one process for --rerun option.
2017-05-23 16:59:22 -07:00
63cc8183ad
tools/run-mypy: Add flags.
2017-05-23 12:02:57 -07:00
bda5517b5c
mypy: Upgrade to latest version of mypy.
2017-05-23 10:42:44 -07:00
09e1136cc8
mypy: Fix casing for List type.
2017-05-23 10:42:44 -07:00
ed8c6943f2
webhooks/airbrake: Use Markdown macros for documentation.
2017-05-22 18:19:14 -07:00
a9f4d56a95
mypy: Add type to info dictionary.
2017-05-22 11:19:06 -07:00
ab2cfadcaa
Fix emoji cache setup when not using provision.py.
...
Moves creating the emoji folder from the provisioning script to
the build_emoji script.
Fixes the fact that the emoji cache directory wasn't being created
when not using the provision.py script.
2017-05-22 11:08:43 -07:00
521bdccb9d
pep8: Add compliance with rule E261 to test-tools.
2017-05-18 03:00:32 +05:30
8b219bea13
pep8: Add compliance with rule E261 to test-api.
2017-05-18 03:00:32 +05:30
306e74c60d
pep8: Add compliance with rule E261 to replace-tarball-shebang.
2017-05-18 03:00:32 +05:30
d6f97f09aa
pep8: Add compliance with rule E261 to renumber-migrations.
2017-05-18 03:00:32 +05:30
171a0ddd4e
pep8: Add compliance with rule E261 to minify-js.
2017-05-18 03:00:32 +05:30
cd7fda993a
pep8: Add compliance with rule E261 to lint.
2017-05-18 03:00:32 +05:30
4d06c567f4
pep8: Add compliance with rule E261 to html-grep.
2017-05-18 03:00:32 +05:30
151712b9cc
pep8: Add compliance with rule E261 to get-handlebar-vars.
2017-05-18 03:00:32 +05:30
bc987c99ca
pep8: Add compliance with rule E261 to create-test-api-docs.
2017-05-18 03:00:32 +05:30
9c29da17fc
pep8: Add compliance with rule E261 to compile-handlebars-templates.
2017-05-18 03:00:32 +05:30
a549013c50
emoji_pickers: Fix broken flag emojis.
...
Due to differences between the codepoints of flag emojis in
`emoji_map.json` and iamcal's dataset, we need to patch the
css classes for the flag emojis temporarily until the migration
to iamcal's dataset is complete inorder to render them properly.
There is a difference between the images of flag emojis in our
old emoji farm and iamcal's spritesheets and since we have not
yet switched to using spritesheets for displaying emojis in
messages, there is a difference between the flag emojis as
rendered in messages and in emoji pickers.
2017-05-17 08:09:50 -07:00
b64a4f9291
minify-js: Fix failure to update JS files on Git deploys.
...
This fixes a significant static asset pipeline bug, which mean that
when we added `moment.js` to the Zulip npm dependencies, it wasn't
properly included in common.js; caching prevented common.js from ever
being rebuilt.
2017-05-16 17:57:20 -07:00
0d28d5d808
build_emoji: Fix the spritesheet CSS generation code.
...
Modify the spritesheet generation code to account for the differences
between emoji_map.json and iamcal's dataset. Due to the differences
between the two mappings, some emojis like 1️⃣ , 2️⃣ etc were not
getting rendered properly in the two emoji pickers where we are using
the iamcal's spritesheets for rendering them. This was so because there
was no CSS class corresponding to the codepoints of these emojis(as
mapped using emoji_map.json) in our spritesheet CSS(generated using
iamcal's dataset).
Fixes : #4775 .
2017-05-16 13:06:12 -07:00
0667297c6e
build_emoji: Fix the coloring of the white emojis.
...
Fix the coloring of the white emojis to match that of the images
in the iamcal's spritesheets.
2017-05-16 13:06:12 -07:00
286f9a40e7
push_notifications: Bring file to 100% coverage.
2017-05-16 12:26:55 -07:00
21e0db03e1
webhooks/appfollow: Migrate docs to Markdown.
2017-05-15 20:14:23 -07:00
0b5711aa7e
webhooks/airbrake: Migrate docs to Markdown.
2017-05-15 20:14:23 -07:00
1769a444de
Remove unnecessary ignore files.
...
In this commit we remove user_sidebar_actions.handlebars from
IGNORE_FILES as well remove the check for files to be in a
IGNORE list thus reaching 100% 4 space indent checking for
handlebar templates.
Fixes : #1661 .
2017-05-15 11:51:21 -07:00
debcf507bd
Clean organization-settings-admin to use 4 space indents.
2017-05-15 11:51:21 -07:00
8530997542
Clean default-streams-list-admin to use 4 space indents.
2017-05-15 11:51:21 -07:00
33f3d773b0
Clean user-list-admin to use 4 space indents.
2017-05-12 12:23:01 -07:00
0c39a45d72
Clean bot-list-admin to use 4 space indents.
2017-05-12 12:23:01 -07:00
232592cc9f
test_sessions: Extends tests to reach 100% coverage of sessions.py.
...
Fixes #3980 .
2017-05-10 10:12:21 -07:00
9f7236eec1
message: Remove unused old gravatar_hash field from message dicts.
...
This was deprecated and replaced some 4 years ago.
2017-05-09 22:33:27 -07:00
86a9283471
Update JS dependency configuration.
2017-05-08 22:04:56 -07:00
abd09cebb2
git tools: Make error messages more clear.
2017-05-08 10:51:59 -07:00
f4a7791d95
pep8: Add compliance with rule E261 to test_template_parser.py.
2017-05-07 23:21:50 -07:00
9fb6d976ca
pep8: Add compliance with rule E261 to test_server.py.
2017-05-07 23:21:50 -07:00
88811e0d34
pep8: Add compliance with rule E261 to test_user_agent_parsing.py.
2017-05-07 23:21:50 -07:00
83db0a98ae
pep8: Add compliance with rule E261 to lister.py.
2017-05-07 23:21:50 -07:00
46b3c14876
pep8: Add compliance with rule E261 to html_grep.py.
2017-05-07 23:21:50 -07:00
47e7437932
pep8: Add compliance with rule E261 to html_branches.py.
2017-05-07 23:21:50 -07:00
ffb8440eef
pep8: Add compliance with rule E261 to graph.py.
2017-05-07 23:21:50 -07:00
c0e1b49b68
pep8: Add compliance with rule E261 to find_add_class.py.
2017-05-07 23:21:50 -07:00
fef732d85b
pep8: Add compliance with rule E261 to css_parser.py.
2017-05-07 23:21:50 -07:00
69f9353ecf
pep8: Add compliance with rule E261 to check_help_documentation.py.
2017-05-07 23:21:50 -07:00
c8902d5d71
settings: Make settings overlay more responsive.
...
This doesn't completely fix settings responsiveness, but it's a big
step along the way. Outstanding issues include:
1. When switching tabs from settings to organization, it will launch
the first item which is more annoying in this view since it brings you
into that tab. Haven’t decided on an elegant solution to this yet.
2. Sidebar scrolling doesn’t work. I have to restructure how the top
section and bottom sections of content are displayed to fix this.
Likely by enforcing min-height of 100% - bottom height on the top piece.
3. Most of it is actually reasonably responsive but some isn’t, and
should be fixed on a case-by-case.
2017-05-05 13:42:09 -07:00
19adf2e327
requirements: Upgrade gitlint to 0.8.2.
...
As of Gitlint v0.8.2, the --extra-path option now accepts both
directories and standalone python modules.
2017-05-05 09:59:39 -07:00
6b1c53059b
testing: Run in parallel mode by default.
...
This commit changes the backend testing framework to run
in parallel mode which is same as --processes=4. If --coverage
is supplied, we enforce serial mode, --processes=1, because
coverage is not compatible with parallel mode at the moment.
2017-05-04 16:06:34 -07:00
c10d3114eb
email: Move and rename followup_day* templates.
2017-05-03 23:26:14 -07:00
21a6377204
email: Move and rename find_team_email templates.
2017-05-03 23:26:14 -07:00
ebfae36494
email: Move and rename digest_email templates.
2017-05-03 23:26:14 -07:00
26ac344b19
email: Move and rename invitation_reminder_email templates.
2017-05-03 23:26:14 -07:00
21a2c7b9d9
email: Remove translation tags from email templates.
...
The only thing being translated in any email was the title of the Zulip
header image in the html file, probably because not doing so breaks a linter
rule.
he name "Zulip" doesn't make sense to translate anyway.
2017-05-03 23:25:33 -07:00
713303deff
email: Move and rename invite_email templates.
2017-05-03 20:54:40 -07:00
ed0c310aa3
email: Move and rename preregistrationuser_confirmation_email templates.
2017-05-03 20:54:40 -07:00
235abe0b72
email: Move and rename emailchangestatus_confirmation_email templates.
2017-05-03 20:54:40 -07:00
c7ba9a2ae5
templates: Remove old Zulip, Inc. privacy policy.
...
This isn't useful for anything anymore, especially now since we have a
sysadmin-configurable PRIVACY_POLICY settings.
2017-05-03 17:59:53 -07:00
ed4866b9f9
message-feed: Improve scroll perf by removing scaling on emojis.
...
This removes scaling from the emojis by changing the background size to
a lower value and then allowing for the widths and heights of the
emojis to be proportionally smaller.
The transform: scale property would cause many more repaints in Chrome
and other browsers than should have been necessary which would render
messages above and below the feed light grey boxes that would
momentarily flash as blank before filling with content.
Modified by tabbott to use a percentage in the background-size.
Fixes #4660 .
2017-05-03 14:49:47 -07:00
110f161288
emoji: Remove code for generating old sprite sheets.
2017-05-03 13:34:30 -07:00
b9cb6199cf
emoji: Use lower-case hex letters in iamcal data.
2017-05-03 13:01:53 -07:00
47eb19331d
ux: Display error on login/registration if no auth backends are enabled.
...
Also makes a small tweak to CSS to ensure the styling is consistent on
the two pages.
Fixes #4525 .
2017-05-01 17:17:37 -07:00
e3edc4d829
Send welcome messages for new streams.
2017-05-01 16:23:38 -07:00
cfeff245c1
emoji: Manage Zulip emoji as a custom/extra realm emoji.
...
This is prerequisite for converting our emoji system to work off of
iamcal sprite sheets.
Also, fixes #4308 .
2017-04-30 16:40:31 -07:00
0965c43238
Add typeahead for syntax highlighting languages.
...
Modified composebox_typeahead.js to recognize the triple backtick
and tilde for code blocks, and added appropriate typeahead functions
in that file and in typeahead_helper.js.
Additionally, a new file pygments_data.js contains a dictionary of
the supported languages, mapping to relative popularity
rankings. These rankings determine the order of sort of the
languages in the typeahead.
This JavaScript file is actually in static/generated/pygments_data.js, as it
is generated by a Python script, tools/build_pymgents_data.py. This is
so that if Pygments adds support for new languages, the JavaScript file
will be updated appropriately. This python script uses a set of popularity
rankings defined in lang.json.
Corresponding unit tests were also added.
Fixes #4111 .
2017-04-28 17:22:59 -07:00
73096e377a
minor: Update JS dependency configuration.
2017-04-28 16:17:52 -07:00
Joshua Pan
Aditya Bansal
Harshit Bansal
sinwar
Vaida Plankyte
Robert Hönig
Steve Howell
Umair Khan
Cynthia Lin
Cory Lynch
vaibhav
Tommy Ip
Eeshan Garg
Tim Abbott
Pweaver (Paul Weaver)
Mehanig
Rafid Aslam
Yago González
Rohitt Vashishtha
Reid Barton
rht
Eklavya Sharma
Jason Michalski
umkay
Jordan Gedney
Carey Metcalfe
Brock Whittaker
Rishi Gupta