zulip

Commit Graph

Author	SHA1	Message	Date
Steve Howell	ac69450681	zjsunit: Clear $ elements in run_test. We now call $.clear_all_elements at the top of run_test. We have to exempt two modules from the new regime: compose settings_user_groups Also, if modules do set_global("$", ...) we don't try to call the non-existent function. It's possible we'll want to move to something like this, but we might want to clean up the two sloppy_$ modules first: // AVOID THIS: // const $ = require("zjquery") run_test("test widget", ({override, $}) => { override(foo, "bar", ...); $.create(...); // do stuff });	2021-02-23 07:55:43 -05:00
Anders Kaseorg	89aa3155a9	node_tests: Don’t read from most deprecated global variables. We still need to write to these globals with set_global because the code being tested reads from them, but the tests themselves should never need to read from them. Signed-off-by: Anders Kaseorg <anders@zulip.com>	2021-02-10 07:40:22 -08:00
Anders Kaseorg	21d432e12c	zjsunit: Deglobalize run_test. Signed-off-by: Anders Kaseorg <anders@zulip.com>	2020-12-01 07:14:00 -05:00

Author

SHA1

Message

Date

Steve Howell

ac69450681

zjsunit: Clear $ elements in run_test.

We now call $.clear_all_elements at the top
of run_test.

We have to exempt two modules from the new regime:

    compose
    settings_user_groups

Also, if modules do set_global("$", ...) we don't
try to call the non-existent function.

It's possible we'll want to move to something like
this, but we might want to clean up the two
sloppy_$ modules first:

    // AVOID THIS:
    // const $ = require("zjquery")

    run_test("test widget", ({override, $}) => {
        override(foo, "bar", ...);
        $.create(...);
        // do stuff
    });

2021-02-23 07:55:43 -05:00

Anders Kaseorg

89aa3155a9

node_tests: Don’t read from most deprecated global variables.

We still need to write to these globals with set_global because the
code being tested reads from them, but the tests themselves should
never need to read from them.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

2021-02-10 07:40:22 -08:00

Anders Kaseorg

21d432e12c

zjsunit: Deglobalize run_test.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

2020-12-01 07:14:00 -05:00

3 Commits